fc841c804 Fix claimpegin and createrawpegin support for multiwallet. (Glenn Willen)
Pull request description:
Fixes#812. @stevenroose, take a look when you get back?
Fix multiple issues with claimpegin and createrawpegin support for
multiple loaded wallets:
- Failure to call EnsureWalletIsAvailable would cause a crash when multiple
wallets were loaded, but one was not specified in the RPC call.
- Failure to propagate the request URL from claimpegin when making an
internal call to another RPC would result in failure when multiple
wallets were loaded, by failing to specify one for that call.
Add a regression test to the feature_fedpeg.py test: at a critical point,
create a second wallet on the sidechaind, and set up the RPC client to
use the first one, to check that it still works correctly.
Tree-SHA512: 38d28319d0bc131f530a03e2477b013a982b28d321383a2316372d9aa94f66b19137ba4c1c7e1fe44e3470fe87e80fabbd435836892925b50134c05613581e10
Fix multiple issues with claimpegin and createrawpegin support for
multiple loaded wallets:
- Failure to call EnsureWalletIsAvailable would cause a crash when multiple
wallets were loaded, but one was not specified in the RPC call.
- Failure to propagate the request URL from claimpegin when making an
internal call to another RPC would result in failure when multiple
wallets were loaded, by failing to specify one for that call.
Add a regression test to the feature_fedpeg.py test: at a critical point,
create a second wallet on the sidechaind, and set up the RPC client to
use the first one, to check that it still works correctly.
This fixes f.e. that when arguments are set in CLI or the config file
without a network attached (`port` instead of `liquidv1.port`), they
will now be assigned to the liquidv1 instead of Bitcoin mainnet.
6ff3125fc Replace Greg with Steven as security contact (Steven Roose)
Pull request description:
Tree-SHA512: d29b1cf63e44511530b8d167af14c88f9e5f30c207b98751c16c6027f65c4c38e2450d57d62893a1db72651c31ba0335c2f52a8d185c06997feb5386590aeec1
ee068ef07 Fix VerifyScript calls in fuzz/script_flags (Gregory Sanders)
Pull request description:
Only is compiled with clang/fuzzer setups I suppose.
Tree-SHA512: 3e4b7a1fc96a684cb1b56565830f9f343a23a77677ddde3b18c86cc18d745bbc98c69bdefe985a0f29b3002f05bfc956d2b2b9b6574a4b48615a89dd70f6e468
00eb6c097 Test funding peg-in psbt (Andrew Chow)
1ce74e07f Be able to fund transactions with peg-ins (Andrew Chow)
74c4d3778 Tests for fundrawtransaction with external inputs (Andrew Chow)
c25874672 allow fundtx rpcs to work with external inputs (Andrew Chow)
9486cdf54 Give a better error when tx size estimation fails (Andrew Chow)
8258aaa73 Allow Coin Selection be able to take external inputs (Andrew Chow)
698340b62 Allow CInputCoin to also be constructed with COutPoint and CTxOut (Andrew Chow)
Pull request description:
Allows `fundrawtransaction` and `walletcreatefundedpsbt` to take transactions with pre-selected peg-in inputs and take them into account when selecting additional inputs to meet the output amounts.
As a side effect, those RPCs will also now allow pre-selected non-wallet inputs so long as the correct additional solving data is provided (scripts and pubkeys are needed to estimate the size for transaction fees).
Based on #751
Ports https://github.com/bitcoin/bitcoin/pull/17211 with some modification to work with elements outputs and such.
Tree-SHA512: 813202adfe2b63780bea01b02975dda393197a489a6c1a9590908ac7252d1d0e5f0984125fbfd1dc271524ddad84dc1778a1e8fa447e61235c7f21c6e6999460
7cb5f6bb0 Sign PSBTs with peg-in data (Andrew Chow)
73711eb0b Merge psbt peg-in data (Andrew Chow)
4ad849fed Finalize psbt peg-ins (Andrew Chow)
b7e369505 Test createpsbt and decodepsbt with peg-ins (Andrew Chow)
8ece8e0a0 Show peg-in info in decodepsbt (Andrew Chow)
646e76f7d Be able to create peg-in PSBTs in createpegin (Andrew Chow)
b5590b20c Add peg-in PSBT fields (Andrew Chow)
Pull request description:
Adds peg-in fields for PSBT. `createpsbt` uses the new peg-in raw tx api to allow specifying the peg-in data and then adds it to the psbt. `decodepsbt`, `finalizepsbt` and `walletsignpsbt` are both updated to handle peg-in stuff too. Also tests.
`walletcreatefundedpsbt` still does not handle peg-in data. It will require handling external inputs which the wallet does not do. I think it would be best to first implement external inputs in `FundTransaction` upstream before allowing `walletcreatefundedpsbt` to accept peg-ins.
Tree-SHA512: 838c2cf0de78b6ad948aaec2932326e2e39b6645c98193c90eedaee7e5cd8ebe3e8ea00e3ba4a67d5f862948195f37aded0e6a08a7c3c20def325d4cabb78ee3
e92ac19a4 Remove 'bitcoin' from address descriptions (Gregory Sanders)
Pull request description:
fixes https://github.com/ElementsProject/elements/issues/777
Alternative would be to have the `-chain` name be put there, but honestly seems overkill.
Tree-SHA512: a54e95f0755134fc6a1df51962a82957678d777406bda62a3f11359f52b8d72cd8c5199248f764ffbcf888b343737801d4ba19a58181a9b41bd4d3e5db656230
ead03a8a1 Make balances in overview scrollable (Andrew Chow)
3743ff53b Set the vertical layout in .ui file instead of programatically (Andrew Chow)
Pull request description:
Makes the balances on the overview page scrollable when therer are lots of assets. It should be both vertically and horizontally scrollable.
Also Fixes the vertical layout so it uses the UI forms and looks better.
Fixes#685
Tree-SHA512: 19f4c2ded210b2e969a64ead2ff1e16076f724c994a223d3edd15dcd758729069f68f4cab746c6b06fe6d384f64868efd6babe735995f3adb61ce137a469a369
60ea625a0 macos: Use correct application name (Philippe McLean)
Pull request description:
fixes#724
- generated DS_Store for dmg was referencing Bitcoin-Qt instead
of the locally built application Elements-Qt
Tree-SHA512: d526b3ff1962e6c968b42ee77d9fb659bef4714195b2fb2dccfdac6443ed33789bc6d9f2edf7803dc78b93b29b5033b5e44811c7e94a3acea880043c12f1a89d
6fc3fe04e Change elements mode to activating BIP9 signaling based on height (Gregory Sanders)
Pull request description:
When based on block time, it's really hard to engineer principled tests for activation of consensus changes.
resolves https://github.com/ElementsProject/elements/issues/779
Tree-SHA512: c5672d54a3a906d1318c82197022b9effd39e951e3f9e5ca4dc92055f2fa638a6359797662014c4928be25795ddd6b3f401769d53a967cf08d4f564210926773
fd5ec4bff HF: Simplify legacy->dynafed transition max sig size (Gregory Sanders)
7b15b4802 HF: Publish full dynafed block no matter epoch age (Gregory Sanders)
1d7847305 HF: Dyanfed pruned header now has extra root (Gregory Sanders)
Pull request description:
andytoshi's motivating text:
"Motivation here is that the functionary wants to be able to compute the root of the parameters and use this to look up the params in the set of supported params (which includes a bunch of extra auxiliary data, in particular the signblock witness script).
If the root is computed differently for compact-encoded params than for full-encoded ones, and indeed does not even commit to the extra data, this lookup is impossible without blockchain context, which is not obvious how to obtain for an unsigned block."
Tree-SHA512: 737b9da99bc4abd28cc63c3a441098e0a6ea0cb2748082f845b24d50fe3a9cd1d1253d622cdca4df91e27c04a4912babc8a54409e7e0f2af14f65a3414a072ad
bf66a93cb Correctly seed the liquidv1 paklist pre-dynafed (Gregory Sanders)
Pull request description:
Currently PAK is blank for anyone running on liquidv1 network. This is wrong.
No PAK list changes are expected prior to dynafed roll-out, so this should remain constant until activation.
Tree-SHA512: eef819c62ee887fdb36b194e52f896306e567a9e7a059fec0620c87b9e126f594a78128e7beec7e86c00976b180c7ea43412a7bb123c3f50e4800d3c837b7f6b
674f3c747 When RPC server disabled, only warn on validatepegin failure (Gregory Sanders)
Pull request description:
QT starts up normally, and fails when `-server=1` is set, and continues otherwise, by turning off peg-in validation.
This should be tested on liquidv1 with fresh syncs.
Tree-SHA512: acf188b2eead8db2f2b8d92ae90b510a05e6ab15639249917a3fb99bf3ec48b3d741e372a4bfcf44b8c632d199e56070bbfe1f6a69ef1c991f126b4d34b218a8
