Commit graph

20512 commits

Author SHA1 Message Date
Gregory Sanders
ee068ef075 Fix VerifyScript calls in fuzz/script_flags 2019-12-05 10:18:47 -05:00
Gregory Sanders
2949ea924f
Merge #751: Peg-in fields for PSBT
7cb5f6bb0 Sign PSBTs with peg-in data (Andrew Chow)
73711eb0b Merge psbt peg-in data (Andrew Chow)
4ad849fed Finalize psbt peg-ins (Andrew Chow)
b7e369505 Test createpsbt and decodepsbt with peg-ins (Andrew Chow)
8ece8e0a0 Show peg-in info in decodepsbt (Andrew Chow)
646e76f7d Be able to create peg-in PSBTs in createpegin (Andrew Chow)
b5590b20c Add peg-in PSBT fields (Andrew Chow)

Pull request description:

  Adds peg-in fields for PSBT. `createpsbt` uses the new peg-in raw tx api to allow specifying the peg-in data and then adds it to the psbt. `decodepsbt`, `finalizepsbt` and `walletsignpsbt` are both updated to handle peg-in stuff too. Also tests.

  `walletcreatefundedpsbt` still does not handle peg-in data. It will require handling external inputs which the wallet does not do. I think it would be best to first implement external inputs in `FundTransaction` upstream before allowing `walletcreatefundedpsbt` to accept peg-ins.

Tree-SHA512: 838c2cf0de78b6ad948aaec2932326e2e39b6645c98193c90eedaee7e5cd8ebe3e8ea00e3ba4a67d5f862948195f37aded0e6a08a7c3c20def325d4cabb78ee3
2019-12-03 11:42:58 -05:00
Steven Roose
dd1478870c
Merge #791: Fix address string assertions in tests
9a51d08ed Fix address string assertions in tests (Gregory Sanders)

Pull request description:

  fixes tests after https://github.com/ElementsProject/elements/pull/778

Tree-SHA512: a634264403edc7f7ea69dfeb154c1391ff23f69512baa25fc87c920226d5aa6800cae64cca3dafccdf00780de52645c9678fab3784ee7e07b00f59da0a0006e3
2019-11-26 14:51:54 +00:00
Gregory Sanders
9a51d08eda Fix address string assertions in tests 2019-11-26 09:03:45 -05:00
Steven Roose
6d00035cae
Merge #778: Remove 'bitcoin' from address descriptions
e92ac19a4 Remove 'bitcoin' from address descriptions (Gregory Sanders)

Pull request description:

  fixes https://github.com/ElementsProject/elements/issues/777

  Alternative would be to have the `-chain` name be put there, but honestly seems overkill.

Tree-SHA512: a54e95f0755134fc6a1df51962a82957678d777406bda62a3f11359f52b8d72cd8c5199248f764ffbcf888b343737801d4ba19a58181a9b41bd4d3e5db656230
2019-11-26 11:07:09 +00:00
Steven Roose
45f04d9753
Merge #784: Fill out expected liquidv1 chain size
547a2f7bd Fill out expected liquidv1 chain size (Gregory Sanders)

Pull request description:

  fixes https://github.com/ElementsProject/elements/issues/765

Tree-SHA512: 7ea4ac2850b086f2aeee1065b308ab6505ff7c4af559242062e88f1db5891f1c6ca0c26f97a5a1c90f8eee284a66ffc9f31d422962f6efa6b870215fa04b955f
2019-11-26 11:05:17 +00:00
Steven Roose
4d5bd19fa0
Merge #785: Fix QR address display for blinded base58 addrs
d837ac40c Fix QR address display for blinded base58 addrs (Gregory Sanders)

Pull request description:

  fixes https://github.com/ElementsProject/elements/issues/763

Tree-SHA512: aea0a9f4211688fde55600f213f375f9117c06519952e656275ec4aca8d132b15718d99cbcdc63547e04f981ad33c75104c416bc7262a3ae6dad0774ca1138f9
2019-11-26 11:02:09 +00:00
Steven Roose
4895540b2f
Merge #788: gui: Make balances scrollable on overview
ead03a8a1 Make balances in overview scrollable (Andrew Chow)
3743ff53b Set the vertical layout in .ui file instead of programatically (Andrew Chow)

Pull request description:

  Makes the balances on the overview page scrollable when therer are lots of assets. It should be both vertically and horizontally scrollable.

  Also Fixes the vertical layout so it uses the UI forms and looks better.

  Fixes #685

Tree-SHA512: 19f4c2ded210b2e969a64ead2ff1e16076f724c994a223d3edd15dcd758729069f68f4cab746c6b06fe6d384f64868efd6babe735995f3adb61ce137a469a369
2019-11-26 10:51:37 +00:00
Andrew Chow
ead03a8a19 Make balances in overview scrollable 2019-11-21 17:22:42 -05:00
Andrew Chow
3743ff53b7 Set the vertical layout in .ui file instead of programatically 2019-11-21 13:26:05 -05:00
Gregory Sanders
fe27ef834e
Merge #786: macos: Use correct application name
60ea625a0 macos: Use correct application name (Philippe McLean)

Pull request description:

  fixes #724
  - generated DS_Store for dmg was referencing Bitcoin-Qt instead
  of the locally built application Elements-Qt

  ![image](https://user-images.githubusercontent.com/565792/69210165-b9085480-0b0e-11ea-80f5-6acef74d6929.png)

Tree-SHA512: d526b3ff1962e6c968b42ee77d9fb659bef4714195b2fb2dccfdac6443ed33789bc6d9f2edf7803dc78b93b29b5033b5e44811c7e94a3acea880043c12f1a89d
2019-11-20 08:31:26 -05:00
Philippe McLean
60ea625a09 macos: Use correct application name
fixes #724
- ds_store was referencing Bitcoin-Qt instead
of built application Elements-Qt
2019-11-19 16:14:02 -08:00
Gregory Sanders
d837ac40c6 Fix QR address display for blinded base58 addrs 2019-11-19 10:47:59 -05:00
Gregory Sanders
547a2f7bdf Fill out expected liquidv1 chain size
Currently it is 1.1 GB according to my local machine.

Overshooting by 3x to account for growth.
2019-11-19 10:30:40 -05:00
Steven Roose
ccf6697e3b
Merge #780: Change elements mode to activating BIP9 signaling based on height
6fc3fe04e Change elements mode to activating BIP9 signaling based on height (Gregory Sanders)

Pull request description:

  When based on block time, it's really hard to engineer principled tests for activation of consensus changes.

  resolves https://github.com/ElementsProject/elements/issues/779

Tree-SHA512: c5672d54a3a906d1318c82197022b9effd39e951e3f9e5ca4dc92055f2fa638a6359797662014c4928be25795ddd6b3f401769d53a967cf08d4f564210926773
2019-11-14 11:40:50 +00:00
Gregory Sanders
6fc3fe04ef Change elements mode to activating BIP9 signaling based on height 2019-11-13 16:07:29 -05:00
Gregory Sanders
e92ac19a45 Remove 'bitcoin' from address descriptions 2019-11-13 10:55:25 -05:00
Steven Roose
ef4231fc00
Merge #776: commit_data is entirely optional
6ba90ef1e commit_data is entirely optional (Gregory Sanders)

Pull request description:

  fixes https://github.com/ElementsProject/elements/issues/775#event-2795298661

Tree-SHA512: 1e3dd7fe416d40366ae0d5b66ff4f6cbc0dd881c3821b3b75ebad40453a9f6993008f780c9f8fe4a36881b3e7117a87118eb4dfd20f707adf6d4aa3903469031
2019-11-13 15:11:57 +00:00
Gregory Sanders
6ba90ef1e7 commit_data is entirely optional 2019-11-13 10:04:37 -05:00
Steven Roose
f60e0684d1
Merge #773: HF: Dyanfed pruned header now has extra root
fd5ec4bff HF: Simplify legacy->dynafed transition max sig size (Gregory Sanders)
7b15b4802 HF: Publish full dynafed block no matter epoch age (Gregory Sanders)
1d7847305 HF: Dyanfed pruned header now has extra root (Gregory Sanders)

Pull request description:

  andytoshi's motivating text:

  "Motivation here is that the functionary wants to be able to compute the root of the parameters and use this to look up the params in the set of supported params (which includes a bunch of extra auxiliary data, in particular the signblock witness script).

  If the root is computed differently for compact-encoded params than for full-encoded ones, and indeed does not even commit to the extra data, this lookup is impossible without blockchain context, which is not obvious how to obtain for an unsigned block."

Tree-SHA512: 737b9da99bc4abd28cc63c3a441098e0a6ea0cb2748082f845b24d50fe3a9cd1d1253d622cdca4df91e27c04a4912babc8a54409e7e0f2af14f65a3414a072ad
2019-11-11 11:35:16 +00:00
Gregory Sanders
fd5ec4bff6 HF: Simplify legacy->dynafed transition max sig size 2019-11-08 14:07:07 -05:00
Gregory Sanders
7b15b4802c HF: Publish full dynafed block no matter epoch age 2019-11-08 14:07:01 -05:00
Gregory Sanders
1d7847305c HF: Dyanfed pruned header now has extra root 2019-11-08 14:07:01 -05:00
Steven Roose
08023b0b4e
Merge #770: Revert errant line change committed in bf66a93cbd
610d8d7af Revert errant line change committed in bf66a93cbd (Gregory Sanders)

Pull request description:

  …b25293e277

Tree-SHA512: 62b2080d75dcb7e3a182be4f184f82150233711356b16d6a538a8cd793d8adc48cd5d47113242e06379a4fa4821fbab4bf9a439e1614de67617a9af73980552d
2019-11-05 17:36:59 +00:00
Gregory Sanders
610d8d7afa Revert errant line change committed in bf66a93cbd 2019-11-05 12:29:50 -05:00
Steven Roose
53afce3b0b
Merge #769: Correctly seed the liquidv1 paklist pre-dynafed
bf66a93cb Correctly seed the liquidv1 paklist pre-dynafed (Gregory Sanders)

Pull request description:

  Currently PAK is blank for anyone running on liquidv1 network. This is wrong.

  No PAK list changes are expected prior to dynafed roll-out, so this should remain constant until activation.

Tree-SHA512: eef819c62ee887fdb36b194e52f896306e567a9e7a059fec0620c87b9e126f594a78128e7beec7e86c00976b180c7ea43412a7bb123c3f50e4800d3c837b7f6b
2019-11-05 16:49:07 +00:00
Steven Roose
5d3b7eb9f8
Merge #768: When RPC server disabled, only warn on validatepegin failure
674f3c747 When RPC server disabled, only warn on validatepegin failure (Gregory Sanders)

Pull request description:

  QT starts up normally, and fails when `-server=1` is set, and continues otherwise, by turning off peg-in validation.

  This should be tested on liquidv1 with fresh syncs.

Tree-SHA512: acf188b2eead8db2f2b8d92ae90b510a05e6ab15639249917a3fb99bf3ec48b3d741e372a4bfcf44b8c632d199e56070bbfe1f6a69ef1c991f126b4d34b218a8
2019-11-05 16:35:43 +00:00
Gregory Sanders
bf66a93cbd Correctly seed the liquidv1 paklist pre-dynafed 2019-11-05 10:39:22 -05:00
Gregory Sanders
674f3c7473 When RPC server disabled, only warn on validatepegin failure 2019-11-05 09:06:56 -05:00
Gregory Sanders
b334392946
Merge #758: dynaParamsToJSON: No lock required
304bdf943 dynaParamsToJSON: No lock required (Gregory Sanders)

Pull request description:

Tree-SHA512: 208ea9f00cda6e717e2ed1840b8eba3c33357bf04119608c005ea7f51ad7cf7882bcedb6659d217941f1b084bcf6a9af21339462f6b3891ccf28f131c7f0814f
2019-10-28 16:00:35 -04:00
Gregory Sanders
304bdf9431 dynaParamsToJSON: No lock required 2019-10-28 14:09:25 -04:00
Steven Roose
1ff3a39d11
Merge #753: getnewblockhex: Take data push for arbitrary data in block coinbase c…
6d9639b21 getnewblockhex: Take data push for arbitrary data in block coinbase commitment (Gregory Sanders)

Pull request description:

  …ommitment

  Useful for non-consensus proof of publication of data.

Tree-SHA512: 8967238c97b5188db50f99d7a8d8a1b26712a6b4c02812880502b5eb9572f7ca6a509a2020cb9661b2931f7d2b06f0580baa8652516b529b2386e92e73767a73
2019-10-28 16:10:48 +01:00
Gregory Sanders
5e89a52087
Merge #754: Update link from README.md to assets tutorial
14126f88d Fix typo in README.md for link to assets tutorial (Philippe McLean)

Pull request description:

Tree-SHA512: 8f6f059b0e310e47e69ce0beb93c8543ba2d971839495f7a3e00464b49ed294467da563c65bbdc9d0e2dbdee5d66b09fec250ce5fc34e67e08d8785b9276cf81
2019-10-28 10:00:16 -04:00
Gregory Sanders
6d9639b211 getnewblockhex: Take data push for arbitrary data in block coinbase commitment 2019-10-28 09:11:05 -04:00
Philippe McLean
14126f88de Fix typo in README.md for link to assets tutorial 2019-10-23 11:34:04 -07:00
Andrew Chow
7cb5f6bb00 Sign PSBTs with peg-in data 2019-10-21 18:02:14 -04:00
Andrew Chow
73711eb0bb Merge psbt peg-in data 2019-10-21 18:02:14 -04:00
Andrew Chow
4ad849fed2 Finalize psbt peg-ins 2019-10-21 18:02:14 -04:00
Andrew Chow
b7e369505f Test createpsbt and decodepsbt with peg-ins 2019-10-21 18:02:14 -04:00
Andrew Chow
8ece8e0a0c Show peg-in info in decodepsbt 2019-10-16 13:58:19 -04:00
Andrew Chow
646e76f7db Be able to create peg-in PSBTs in createpegin 2019-10-16 13:58:19 -04:00
Andrew Chow
b5590b20ce Add peg-in PSBT fields 2019-10-16 12:55:48 -04:00
Gregory Sanders
0d2832a6d1
Merge #741: Allow specifying peg-in data in createrawtransaction
5a4d61169 Test raw transaction peg-in (Andrew Chow)
ac6f052a6 Have find_vout_for_address only get non-confidential address when using elements chain (Andrew Chow)
cefe40767 Allow specifying peg-in info in raw transaction RPC inputs (Andrew Chow)
42babb81f Refactor peg-in input construction into its own function in rpc/rawtransaction.cpp (Andrew Chow)
a90d1521c Refactor peg-in witness construction to it's own function (Andrew Chow)

Pull request description:

  Adds to `createrawtransaction` the fields `pegin_bitcoin_tx`, `pegin_txout_proof`, and `pegin_claim_script` so that raw transactions can contain peg-in inputs too.

  Since `ConstructTransaction` is used by `createpsbt` and `walletcreatefundedpsbt` but those should not support peg-ins yet (the peg-in data should go into PSBT fields for peg-ins but those don't exist yet), an argument is added to it to optionally reject peg-in data.

Tree-SHA512: fcf3e4be87f92bfc5b00321bec405001d98615cefb76118345e0c759c6bfcb90b6050735960b6fbdbe26479fa11c9273f9963873a8adc1fbad9ed31dc7953ee0
2019-10-16 10:16:25 -04:00
Gregory Sanders
63701d117a
Merge #748: Use bytes_to_hex_str instead of .hex()
4b7f3ca90 Use bytes_to_hex_str instead of .hex() (Andrew Chow)

Pull request description:

  Python 3.4 doesn't have .hex(). 3.4 is required by `.python-version` which is used by pyenv. Pyenv users (like myself) will have a hard time running the tests without this.

Tree-SHA512: 8e2f2319e06c8f597b44dd50903e49536277c1c1cd727bf5336579fea977d8a4b5a82744fe1d8dbedc10be3470a63dc1e15435f54fe7cbb0ac96fcea798d1ddc
2019-10-16 09:56:39 -04:00
Andrew Chow
4b7f3ca908 Use bytes_to_hex_str instead of .hex()
Python 3.4 doesn't have .hex().
2019-10-15 18:37:08 -04:00
Andrew Chow
5a4d61169b Test raw transaction peg-in 2019-10-15 15:22:17 -04:00
Andrew Chow
ac6f052a6d Have find_vout_for_address only get non-confidential address when using elements chain 2019-10-15 15:22:10 -04:00
Steven Roose
b117eb4c25
Merge #747: feature_blocksign.py: Allot for possibility of non-empty block 0.5RTT
fcc7051a8 feature_blocksign.py: Allot for possibility of non-empty block 0.5RTT (Gregory Sanders)

Pull request description:

  The way the test is run, the last node(non-signer) can actually become the block producer.

  This, in conjunction with its p2p connection to node 0, means that when node 0 is doing it's compact block back and forth, it can actually create a complete block in 0.5 RTT even if transactions were generated for that block.

  Allow this to happen.

  This may have been a bug in that the non-signer shouldn't have been making blocks, but this is actually more interesting behavior to test, where sometimes partially-complete compact blocks are made, sometimes full, sometimes empty. This exercises more code paths, and so I'm just making sure this succeeds instead, and assert it only succeeds in the expected situation.

Tree-SHA512: f6267208c51344a26636fce4635297f050e2989ec231d2d21463e9a987b58d0a8635bea057b60216fa709ca094cf741ce8acfc0b1d321b6498409c73a19c8fd1
2019-10-15 17:20:22 +01:00
Gregory Sanders
fcc7051a81 feature_blocksign.py: Allot for possibility of non-empty block 0.5RTT 2019-10-15 11:39:51 -04:00
Andrew Chow
cefe40767d Allow specifying peg-in info in raw transaction RPC inputs 2019-10-14 16:58:53 -04:00