Byron Hambly
7ff33d45df
Merge pull request #1330 from delta1/test-fix-getpeginaddress
...
test: fix tests broken by change to getpeginaddress
2024-05-07 09:47:54 +02:00
Byron Hambly
98c8e4f387
test: fix tests broken by change to getpeginaddress
...
Fixes 2 functional tests failing since PR #1327 changes getpeginaddress
to only be valid when IsInitialBlockDownload is false
2024-05-06 14:21:44 +02:00
Byron Hambly
5f1cc1ad8c
Merge pull request #1327 from psgreco/master-nopegin-ibd
...
getpeginaddress cannot be trusted during ibd, it should fail
2024-04-19 17:17:15 +02:00
Pablo Greco
33a15604e8
getpeginaddress cannot be trusted during ibd, it should fail
2024-04-18 17:41:51 -07:00
Byron Hambly
99e502f90c
Merge pull request #1324 from xiaoxianBoy/fix-typos
...
chore: fix typos
2024-04-02 09:33:44 +02:00
snoppy
605acb0a40
chore: fix typos
2024-03-31 23:07:05 +08:00
Byron Hambly
2d298f7e3f
Merge pull request #1294 from psgreco/master-liquid-wallet-descr
...
Remove constrains on liquidv1 pegout bitcoin descriptor
2023-11-23 11:45:30 +00:00
Pablo Greco
d66c283f06
Remove constrains on liquidv1 pegout bitcoin descriptor
2023-11-22 09:57:12 -08:00
Pablo Greco
1b65d4d37b
Merge pull request #1284 from jamesdorfman/schnorr-fix-master
...
pubkey: fix VerifySchnorr bug which is causing testnet validation failure
2023-11-22 04:31:03 -08:00
Byron Hambly
9368fbac1c
test: fix flaky test wallet_groups.py
...
since the SRD coin selection was added, Elements sometimes picks a 1.0
input instead of 0.5 in this test
2023-11-22 08:55:40 +02:00
James Dorfman
48ca8b0f76
test: fix bug in wallet_groups.py functional test that was introduced in merge of bitcoin/bitcoin#22364 in 00f2e32
2023-11-15 20:01:50 +00:00
James Dorfman
ec4c2a4898
test: fix feature_taphash_pegins_issuances.py
...
The first transaction was failing with bad-txns-inputs-missingorspent
because the "input" selected with fundrawtransaction was the
anyonecanspend initialfreecoins.
Fixed by first spending the initialfreecoins to "real" outputs.
2023-11-13 15:33:58 +00:00
Byron Hambly
df8e57296c
Merge ElementsProject/elements#1286 : Script: Move SCRIPT_ERR_COUNT
...
f4243128eeFix #1285
ACKs for top commit:
delta1:
ACK f4243128ee
2023-11-13 13:04:18 +02:00
Byron Hambly
d215bf7f91
test: fix feature_tapscript_opcodes.py
...
The first transaction from create_taproot_utxo was failing with
bad-txns-inputs-missingorspent because the "input" selected with
fundrawtransaction was the anyonecanspend initialfreecoins.
Fixed by first spending the initialfreecoins to "real" outputs.
2023-11-13 09:06:43 +00:00
James Dorfman
8ccb3e1604
test_runner: re-enable the now-passing 'feature_taproot.py'
2023-11-13 03:17:08 +00:00
Christian Lewe
f4243128ee
Script: Move SCRIPT_ERR_COUNT
...
SCRIPT_ERR_COUNT is a pseudo error that returns the number of errors.
It must always be last in the enum.
2023-11-10 17:04:29 +01:00
James Dorfman
eb24b3eb39
test_runner: re-enable the now-passing 'wallet_basic.py --descriptors'
2023-11-09 06:42:33 +00:00
James Dorfman
06423a6aac
test: remove useless comment from feature_taproot_opcodes
...
The line immediately below the commented out code I removed explicitly
tests the exact behaviour which was being questioned in the comment.
This indicates that the comment was incorrect.
2023-11-09 06:34:34 +00:00
James Dorfman
08010b821f
test: fix failing schnorr sig creation in bip341_keypath_test_vectors
2023-11-09 06:31:49 +00:00
James Dorfman
47dff66fa6
pubkey: fix bug in VerifySchnorr introduced in merge of bitcoin/bitcoin#22448 in 09333e2aca
2023-11-03 20:50:42 +00:00
Pablo Greco
20c5630f8c
Merge pull request #1277 from delta1/issues-1259
...
fix: assert failure on non-policy asset consolidation in CreateTransactionInternal
2023-10-27 12:38:05 -03:00
James Dorfman
e02024e53f
test: add new elements_code_tutorial functional test
2023-10-27 15:23:36 +00:00
James Dorfman
39be0f0925
wallet: fix tx credit calculation issues introduced in merge of bitcoin/bitcoin#22100 in 3e939cca and 103069c4
2023-10-27 15:23:19 +00:00
James Dorfman
04cba29faf
coinselection: fail KnapsackSolver if the policy asset doesn't have a solution
2023-10-23 15:55:03 +00:00
James Dorfman
5b72ae23af
coinselection: fail if each non-policy asset doesn't have a solution
2023-10-23 16:51:09 +02:00
Byron Hambly
d3ffd2a380
test: add functional test for issue #1259
...
Adds a functional test to cover the issue uncovered in #1259 , where
calling fundrawtransaction with many non-policy inputs and no policy
recipients results in an assertion failure and a crash.
Fixed in #1258 .
(cherry picked from commit a8b0ed6f96
2023-10-23 16:43:20 +02:00
James Dorfman
c248983aab
Merge pull request #1276 from delta1/issues-1263
...
fix: segfault on getpeginaddress rpc when not in elements mode
2023-10-18 11:51:06 -04:00
goatpig
2e7125c3c8
fix: assert failure on non-policy asset consolidation in CreateTransactionInternal
...
Squash of 2 commits from https://github.com/ElementsProject/elements/pull/1258
- correct application of non_policy_effective_value to policy output in KnapsackSolver
- replace bad fee amount assert with error log and graceful failure in CWallet::CreateTransactionInternal
(cherry picked from commit 0f92a38254cf0f56107b
2023-10-18 16:30:41 +02:00
Pablo Greco
e14d987438
Merge pull request #1275 from delta1/issues-1269
...
test: fix flaky CLTV test in signrawtransaction.py
2023-10-18 10:56:07 -03:00
Byron Hambly
181b9e5932
test: reduce sleep time in witness_script_test and bump precision for csv test
2023-10-18 14:09:09 +02:00
Byron Hambly
5326676ff3
fix: segfault on getpeginaddress rpc when not in elements mode
...
Fixes https://github.com/ElementsProject/elements/issues/1263
When not running in Elements mode, GetValidFedpegScripts returns an
empty vector. Subsequently `calculate_contract` is called with
`fedpegscripts.front().second` which is a null reference. This reference
is passed into `MatchLiquidWatchman` which tries to dereference the null
reference and causes a segfault.
This fix throws an exception in `getpeginaddress` if fedpegscripts is
empty, returning an error to the RPC caller. It also adds a functional
regression test.
2023-10-18 13:02:51 +02:00
James Dorfman
550563e04b
test: give env more time to settle in signrawtransaction.py
2023-10-17 21:00:59 +00:00
Byron Hambly
67bb197647
test: fix flaky CLTV test in signrawtransaction.py
2023-10-16 13:02:43 +02:00
Pablo Greco
c92a8f22f0
Merge pull request #1273 from ElementsProject/master-ci-fixes
...
CI fixes from elements-23.x
2023-10-10 12:52:25 -03:00
Pablo Greco
eed08df346
ci: remove unused param
2023-10-10 08:08:35 -07:00
Byron Hambly
17562593a2
ci: fix arm test file_env placement
2023-10-09 21:17:40 +00:00
James Dorfman
8bf9c630ce
ci: add missing dependencies to native win64 build
2023-10-09 21:17:40 +00:00
dhruv
cb434320b6
build: fix MSVC build after subtree update
...
Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
Co-authored-by: Aaron Clauson <aaron@sipsorcery.com>
2023-10-09 21:17:40 +00:00
Byron Hambly
99ed6e1bee
msvc secp modules
2023-10-09 21:17:40 +00:00
Byron Hambly
0c2fbefe98
add missing 'complete' bool to psbt_updater_test
2023-10-09 21:17:00 +00:00
James Dorfman
5af45ea185
add mising deps to libbitcoinconsensus windows exe build
2023-10-09 20:33:33 +00:00
Pablo Greco
950c4ff0d3
Partial cherry-pick of 5080c9c25f to fix
...
windows builds
2023-10-09 20:33:25 +00:00
Byron Hambly
11c6bfea6c
set ARM CI test to explicitly run on debian:bullseye image
2023-10-09 20:33:00 +00:00
Pieter Wuille
d6fdbf80ca
Disable certain false positive warnings for libsecp256k1 msvc build
...
(cherry picked from commit cabb566123
2023-10-09 20:32:54 +00:00
Hennadii Stepanov
de8b4c87bc
ci: Switch to amd64 container in "ARM" task
...
Tee `arm_container` does not support 32-bit mode anymore.
See: https://github.com/bitcoin/bitcoin/issues/27879
(cherry picked from commit 016fe6d828
2023-10-09 20:32:47 +00:00
Byron Hambly
61cf89586a
ci: remove unused param
2023-10-09 20:32:39 +00:00
Byron Hambly
4d825cd58d
test: specify legacy wallet for failing functional tests on macos13
...
In the "macOS 13 native arm64 [gui, sqlite only]" CI task, the
test_runner defaults to descriptor wallets, causing some Elements
specific tests to fail.
This commit explicitly runs those tests with `--legacy-wallet`.
2023-10-09 20:32:28 +00:00
Pablo Greco
3d2f1c6abb
Merge pull request #1267 from delta1/lint
...
lint: fix codespell warnings
2023-09-27 13:24:41 -03:00
Byron Hambly
3eaccae830
lint: fix codespell warnings
2023-09-27 15:56:20 +02:00
James Dorfman
a582ffd39e
Merge pull request #1264 from psgreco/master-manpages
...
Fix Makefile and placeholders for manpages
2023-09-26 11:50:46 -04:00
