GlcoinCore/elements
1
0
Fork 0
mirror of https://github.com/ElementsProject/elements.git synced 2026-08-13 12:33:42 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1
38905 commits 49 branches 359 tags 252 MiB
Commit graph

38905 commits

This branch
This branch
All branches
Author SHA1 Message Date
Pablo Greco
20c5630f8c
Merge pull request #1277 from delta1/issues-1259 
fix: assert failure on non-policy asset consolidation in CreateTransactionInternal
 2023-10-27 12:38:05 -03:00
James Dorfman
e02024e53f test: add new elements_code_tutorial functional test 2023-10-27 15:23:36 +00:00
James Dorfman
39be0f0925 wallet: fix tx credit calculation issues introduced in merge of bitcoin/bitcoin#22100 in 3e939cca and 103069c4 2023-10-27 15:23:19 +00:00
James Dorfman
04cba29faf coinselection: fail KnapsackSolver if the policy asset doesn't have a solution 2023-10-23 15:55:03 +00:00
James Dorfman
5b72ae23af
coinselection: fail if each non-policy asset doesn't have a solution 2023-10-23 16:51:09 +02:00
Byron Hambly
d3ffd2a380
test: add functional test for issue #1259 
Adds a functional test to cover the issue uncovered in #1259, where
calling fundrawtransaction with many non-policy inputs and no policy
recipients results in an assertion failure and a crash.

Fixed in #1258.

(cherry picked from commit a8b0ed6f96)
 2023-10-23 16:43:20 +02:00
James Dorfman
c248983aab
Merge pull request #1276 from delta1/issues-1263 
fix: segfault on getpeginaddress rpc when not in elements mode
 2023-10-18 11:51:06 -04:00
goatpig
2e7125c3c8
fix: assert failure on non-policy asset consolidation in CreateTransactionInternal 
Squash of 2 commits from https://github.com/ElementsProject/elements/pull/1258

- correct application of non_policy_effective_value to policy output in KnapsackSolver
- replace bad fee amount assert with error log and graceful failure in CWallet::CreateTransactionInternal

(cherry picked from commit 0f92a38254)

Update src/wallet/coinselection.cpp

Co-authored-by: Byron Hambly <byron@hambly.dev>
(cherry picked from commit cf0f56107b)
 2023-10-18 16:30:41 +02:00
Pablo Greco
e14d987438
Merge pull request #1275 from delta1/issues-1269 
test: fix flaky CLTV test in signrawtransaction.py
 2023-10-18 10:56:07 -03:00
Byron Hambly
181b9e5932
test: reduce sleep time in witness_script_test and bump precision for csv test 2023-10-18 14:09:09 +02:00
Byron Hambly
5326676ff3
fix: segfault on getpeginaddress rpc when not in elements mode 
Fixes https://github.com/ElementsProject/elements/issues/1263

When not running in Elements mode, GetValidFedpegScripts returns an
empty vector. Subsequently `calculate_contract` is called with
`fedpegscripts.front().second` which is a null reference. This reference
is passed into `MatchLiquidWatchman` which tries to dereference the null
reference and causes a segfault.

This fix throws an exception in `getpeginaddress` if fedpegscripts is
empty, returning an error to the RPC caller. It also adds a functional
regression test.
 2023-10-18 13:02:51 +02:00
James Dorfman
550563e04b test: give env more time to settle in signrawtransaction.py 2023-10-17 21:00:59 +00:00
Byron Hambly
67bb197647
test: fix flaky CLTV test in signrawtransaction.py 2023-10-16 13:02:43 +02:00
Pablo Greco
c92a8f22f0
Merge pull request #1273 from ElementsProject/master-ci-fixes 
CI fixes from elements-23.x
 2023-10-10 12:52:25 -03:00
Pablo Greco
eed08df346 ci: remove unused param 2023-10-10 08:08:35 -07:00
Byron Hambly
17562593a2 ci: fix arm test file_env placement 2023-10-09 21:17:40 +00:00
James Dorfman
8bf9c630ce ci: add missing dependencies to native win64 build 2023-10-09 21:17:40 +00:00
dhruv
cb434320b6 build: fix MSVC build after subtree update 
Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
Co-authored-by: Aaron Clauson <aaron@sipsorcery.com>
 2023-10-09 21:17:40 +00:00
Byron Hambly
99ed6e1bee msvc secp modules 2023-10-09 21:17:40 +00:00
Byron Hambly
0c2fbefe98 add missing 'complete' bool to psbt_updater_test 2023-10-09 21:17:00 +00:00
James Dorfman
5af45ea185 add mising deps to libbitcoinconsensus windows exe build 2023-10-09 20:33:33 +00:00
Pablo Greco
950c4ff0d3 Partial cherry-pick of 5080c9c25f to fix 
windows builds
 2023-10-09 20:33:25 +00:00
Byron Hambly
11c6bfea6c set ARM CI test to explicitly run on debian:bullseye image 2023-10-09 20:33:00 +00:00
Pieter Wuille
d6fdbf80ca Disable certain false positive warnings for libsecp256k1 msvc build 
(cherry picked from commit cabb566123)
 2023-10-09 20:32:54 +00:00
Hennadii Stepanov
de8b4c87bc ci: Switch to amd64 container in "ARM" task 
Tee `arm_container` does not support 32-bit mode anymore.
See: https://github.com/bitcoin/bitcoin/issues/27879

(cherry picked from commit 016fe6d828)
 2023-10-09 20:32:47 +00:00
Byron Hambly
61cf89586a ci: remove unused param 2023-10-09 20:32:39 +00:00
Byron Hambly
4d825cd58d test: specify legacy wallet for failing functional tests on macos13 
In the "macOS 13 native arm64 [gui, sqlite only]" CI task, the
test_runner defaults to descriptor wallets, causing some Elements
specific tests to fail.

This commit explicitly runs those tests with `--legacy-wallet`.
 2023-10-09 20:32:28 +00:00
Pablo Greco
3d2f1c6abb
Merge pull request #1267 from delta1/lint 
lint: fix codespell warnings
 2023-09-27 13:24:41 -03:00
Byron Hambly
3eaccae830
lint: fix codespell warnings 2023-09-27 15:56:20 +02:00
James Dorfman
a582ffd39e
Merge pull request #1264 from psgreco/master-manpages 
Fix Makefile and placeholders for manpages
 2023-09-26 11:50:46 -04:00
Pablo Greco
0a1b02a9d6 Fix placeholder manpages 2023-09-25 18:39:03 -07:00
Pablo Greco
62b6988786 Update manpage Makefile 2023-09-25 18:34:28 -07:00
Pablo Greco
33f2f6b1fd
Merge pull request #1262 from delta1/merged-master 
Merges up to Bitcoin Core v23 branch point
 2023-09-21 12:34:32 -07:00
Pablo Greco
ae023ea98d
Merge pull request #1217 from delta1/block-header-format 
docs: add block header serialization doc and examples
 2023-09-14 15:00:23 -07:00
James Dorfman
5dc85e0214
build: add dependencies to Makefile.am for libbitcoinkernel 2023-09-13 11:49:11 +02:00
James Dorfman
dabea18f29
rpc: fix bug in 'utxo_size_inc' calculation 2023-09-13 09:27:52 +02:00
Byron Hambly
3ead0ce841
test: fix node_fastmerkle exception in interface_zmq.py 2023-09-08 09:57:28 +02:00
James Dorfman
1bfa980258
chain: make an implicit static cast explicit 2023-09-08 09:25:22 +02:00
James Dorfman
82a2555ad3
build: fix further ASAN issues in CI 2023-09-08 09:24:32 +02:00
Byron Hambly
69e09aa2ea
fix: comment out unused variable until tests are fixed 2023-09-07 16:06:03 +02:00
Byron Hambly
54660d006f
ci: fix unused member function warning in checkqueue.cpp 2023-09-07 13:32:06 +02:00
James Dorfman
0497d1f894 build: fix additional ASAN issues in CI 2023-09-07 05:07:50 +00:00
Byron Hambly
1af35c21de
fixup! docs: add block header serialization doc and examples 2023-09-06 16:35:26 +02:00
James Dorfman
8783a30631
build: fix further ASAN issues in CI 2023-09-06 15:03:51 +02:00
Byron Hambly
860b2c3e4b
fix: move BlindDetails and IssuanceDetails to wallet.h 
resolves the newly introduced circular dependencies correctly
 2023-09-05 14:38:03 +02:00
Byron Hambly
4671addbe0
build: fix forward declaration of CRecipient 2023-09-01 18:13:19 +02:00
Byron Hambly
591749d9f1
build: fix issues from ASAN in CI 2023-09-01 17:17:44 +02:00
Byron Hambly
3911e7e2b3
build: fix compilation warnings 2023-09-01 16:39:08 +02:00
Byron Hambly
c2c7d08de6
lint: add new circular dep to lint-circular-dependencies.sh 2023-09-01 16:38:38 +02:00
Byron Hambly
b59e244da3
lint: fix issues from lint-python.sh 2023-09-01 16:04:39 +02:00