GlcoinCore/elements
1
0
Fork 0
mirror of https://github.com/ElementsProject/elements.git synced 2026-08-19 13:27:35 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

build: fix compilation warnings

Browse source
This commit is contained in:
Byron Hambly 2023-09-01 16:39:08 +02:00
parent c2c7d08de6
commit 3911e7e2b3
No known key found for this signature in database
GPG key ID: DE8F6EA20A661697
4 changed files with 5 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/key.cpp
View file

@ -298,7 +298,7 @@ bool CKey::SignSchnorr(const uint256& hash, Span<unsigned char> sig, const uint2
uint256 tweak = XOnlyPubKey(pubkey_bytes).ComputeTapTweakHash(merkle_root->IsNull() ? nullptr : merkle_root);
if (!secp256k1_keypair_xonly_tweak_add(GetVerifyContext(), &keypair, tweak.data())) return false;
}
bool ret = secp256k1_schnorrsig_sign(secp256k1_context_sign, sig.data(), hash.data(), &keypair, aux.data());
bool ret = secp256k1_schnorrsig_sign32(secp256k1_context_sign, sig.data(), hash.data(), &keypair, aux.data());
if (ret) {
// Additional verification step to prevent using a potentially corrupted signature
secp256k1_xonly_pubkey pubkey_verify;

1
src/test/fuzz/process_messages.cpp
View file

@ -52,7 +52,6 @@ FUZZ_TARGET_INIT(process_messages, initialize_process_messages)
connman.AddTestNode(p2p_node);
}
int elements_iter_count = 0;
LIMITED_WHILE(fuzzed_data_provider.ConsumeBool(), 100) {
// ELEMENTS: this loop runs on a single core and achieves nothing that couldn't
// be achieved by just repeating the fuzz runs. It typically takes around 11

8
src/test/script_standard_tests.cpp
View file

@ -391,7 +391,7 @@ BOOST_AUTO_TEST_CASE(script_standard_taproot_builder)
BOOST_AUTO_TEST_CASE(bip341_spk_test_vectors)
{
using control_set = decltype(TaprootSpendData::scripts)::mapped_type;
// using control_set = decltype(TaprootSpendData::scripts)::mapped_type;
UniValue tests;
tests.read((const char*)json_tests::bip341_wallet_vectors, sizeof(json_tests::bip341_wallet_vectors));
@ -426,9 +426,9 @@ BOOST_AUTO_TEST_CASE(bip341_spk_test_vectors)
// BOOST_CHECK_EQUAL(vec["intermediary"]["merkleRoot"].get_str(), HexStr(spend_data.merkle_root));
}
BOOST_CHECK_EQUAL(spend_data.scripts.size(), scriptposes.size());
for (const auto& scriptpos : scriptposes) {
// BOOST_CHECK(spend_data.scripts[scriptpos.first] == control_set{ParseHex(vec["expected"]["scriptPathControlBlocks"][scriptpos.second].get_str())});
}
// for (const auto& scriptpos : scriptposes) {
// BOOST_CHECK(spend_data.scripts[scriptpos.first] == control_set{ParseHex(vec["expected"]["scriptPathControlBlocks"][scriptpos.second].get_str())});
// }
}
}

1
src/txmempool.cpp
View file

@ -873,7 +873,6 @@ void CTxMemPool::check(const CBlockIndex* active_chain_tip, const CCoinsViewCach
assert(it->GetSizeWithDescendants() >= child_sizes + it->GetTxSize());
TxValidationState dummy_state; // Not used. CheckTxInputs() should always pass
CAmount txfee = 0;
assert(!tx.IsCoinBase());
// ELEMENTS