Commit graph

41 commits

Author SHA1 Message Date
merge-script
ce32bafbb5
Merge JoinMarket-Org/joinmarket-clientserver#1820: ci: no fail-fast for unittests
9eaca78600 ci: no fail-fast for unittests (3np)

Pull request description:

  Let all unittest jobs finish to completion even if one in the matrix fails.

  This should make it easier and quicker to distinguish between:
  - Legitimate new regressions affecting all runtimes
  - Flaky tests
  - Differences between runtimes
  - Whether errors are consistent or intermittent

  without manually restarting or retrying.

  https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#jobsjob_idstrategyfail-fast

  Also ensures results for `master` have complete coverage (for example one was skipped for 5246c1ccb5: https://github.com/JoinMarket-Org/joinmarket-clientserver/actions/runs/18861473464/job/53820509485 )

ACKs for top commit:
  kristapsk:
    cr utACK 9eaca78600

Tree-SHA512: 28c4b9b70b8bd27ef5729ff062c3062faf9954062085d126892f347e1ea430790a89dd46bef53e153b7880b6e0474769a34b1e383b90ec1e39892209388285da
2025-11-29 21:51:35 +02:00
3np
9eaca78600 ci: no fail-fast for unittests 2025-11-01 01:22:13 +00:00
roshii
ea9557ba69 chore(deps): bump python upper version
chore(docs): update python version requirement
2025-10-28 10:52:22 +01:00
3np
b4e3fdda47 Update minimum supported Bitcoin Core version to 28.1 2025-10-27 23:41:40 +00:00
roshii
091ce515e9 fix(deps): bencode library
style: revert formatting

fix(deps): update fastbencode to use rust variant

style: new line

chore: fix typo

Co-authored-by: Marnix Croes <93143998+MarnixCroes@users.noreply.github.com>

chore(deps): bump fastbencode to v0.3.6

chore(deps): remove fastbencode rust extra
2025-10-26 13:51:29 +01:00
Kristaps Kaupe
f952d7df2d
Update minimum supported Bitcoin Core version to 29.0
We should not recommend anything older, there have been vulnerabilty fix. https://bitcoincore.org/en/2025/04/28/disclose-cve-2024-52919/
2025-10-17 22:32:11 +03:00
Kristaps Kaupe
398f1c0e8e CI: Bump Bitcoin Core from 28.0 to 29.0 2025-04-24 18:35:42 +03:00
theborakompanioni
cf5184f244
test(ci): build docker image in github workflow 2025-03-05 17:52:33 +01:00
Kristaps Kaupe
da5603aef6
CI: Run bash scripts with -x 2025-01-08 20:27:59 +02:00
Kristaps Kaupe
6baf4a542d
Bump minimum required Bitcoin Core version from 24.0.1 to 25.1
Security vulnerability has been disclosed for versions older than 25.1, which are also currently EOL. https://bitcoincore.org/en/2024/11/05/cb-stall-hindering-propagation/
2024-11-05 22:18:17 +02:00
Kristaps Kaupe
d9da8bd38e
CI: Bump Bitcoin Core to v28.0 2024-10-23 11:28:41 +03:00
Kristaps Kaupe
b456968c8f
Bump minimum required Bitcoin Core version from 22.0 to 24.0.1
Security vulnerability has been disclosed for versions older than 24.0.1, which are also currently EOL. https://bitcoincore.org/en/2024/09/18/disclose-headers-oom/
2024-09-19 16:12:21 +03:00
Kristaps Kaupe
ee4a3fa75f
Bump minimum required Bitcoin Core version from 0.18 to 22.0
There have been multiple vulnerabilities disclosed for older versions, we should not recommend people using them.

* Disclosure of memory DoS due to malicious P2P message - https://bitcoincore.org/en/2024/07/03/disclose-inv-buffer-blowup/
* Disclosure of CPU DoS due to malicious P2P message - https://bitcoincore.org/en/2024/07/03/disclose-getdata-cpu/
* Disclosure of crash due to malicious BIP72 URI - https://bitcoincore.org/en/2024/07/03/disclose-bip70-crash/
* Disclosure of netsplit due to malicious P2P messages by first 200 peers - https://bitcoincore.org/en/2024/07/03/disclose-timestamp-overflow/
* Disclosure of CPU/memory DoS due to many malicious peers - https://bitcoincore.org/en/2024/07/03/disclose-unbounded-banlist/
* Disclosure of censoring unconfirmed transactions to a specific victim - https://bitcoincore.org/en/2024/07/03/disclose_already_asked_for/
* Security advisories for bugs fixed as of Bitcoin Core v22.0 - https://github.com/bitcoin-core/bitcoincore.org/pull/1049
2024-08-09 12:19:30 +03:00
Kristaps Kaupe
67da0090e7
CI: Bump Bitcoin Core from 27.0 to 27.1 2024-07-10 19:11:12 +03:00
Simon Castano
12d6b5aa06 Bump compatible Python version to 3.12
Signed-off-by: Simon Castano <roshii@riseup.net>
2024-05-19 18:09:51 +02:00
Kristaps Kaupe
30557a498e
CI: Bump Bitcoin Core from 26.1 to 27.0 2024-05-01 20:48:43 +03:00
Kristaps Kaupe
4e75f6ecd9
CI: Bump Bitcoin Core from 26.0 to 26.1 2024-04-25 14:38:51 +03:00
Kristaps Kaupe
39720a8e07
CI: Use x64 not arm64 macOS
ARM (M1) GitHub runner doesn't have Python 3.8 available. EOL of 3.8 is
31 Oct 2024, would be good to continue support, unless there are some
bigger reasons to drop it sooner.

And macos-latest was recently changed to M1, see
<https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories>.

This fixes current non-random always happening CI failures.
2024-04-25 13:46:10 +03:00
Kristaps Kaupe
8e6eca8121
Add CodeQL code scanning 2024-02-01 20:56:07 +02:00
Kristaps Kaupe
658bb00982
Merge JoinMarket-Org/joinmarket-clientserver#1639: Drop Python 3.7 support
204f1171c2 Drop Python 3.7 support (Kristaps Kaupe)

Pull request description:

  It's EOL since 27 Jun 2023 and 3.8+ is required for #1637.

  Also mentioned in docs that JoinMarket is currently not compatible with 3.12 (#1589).

ACKs for top commit:
  AdamISZ:
    utACK https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/1639/commits/204f1171c21cb40654eca73380ae7885f859e88d
  roshii:
    utACK 204f1171c2

Tree-SHA512: 39ee96aca5e305b894e97a2a843d748a645becbfca1bc9e35f02f33c4634a4f7fee37fd36115510cc052e1d11497dceee2d0fafa12d006dd005d050e5ea1cc9f
2024-01-30 19:15:35 +02:00
Kristaps Kaupe
4d15a2cbd9
CI: Add OpenAPI Diff action 2024-01-22 09:48:54 +02:00
Kristaps Kaupe
204f1171c2
Drop Python 3.7 support 2024-01-20 11:43:16 +02:00
Kristaps Kaupe
8684853117
Support Bitcoin Core v26 for tests 2023-12-14 15:29:19 +02:00
Kristaps Kaupe
2e0b3a4bf4
Merge JoinMarket-Org/joinmarket-clientserver#1585: Testing on minimum-required and latest Python version only
4f4945e5c5 Test min and latest Python version only (roshii)

Pull request description:

  Taking the same approach as `bitcoind` version testing, setting only minimum required and latest Python version in CI. Testing so many versions does not bring much added value IMHO.

ACKs for top commit:
  kristapsk:
    ACK 4f4945e5c5

Tree-SHA512: 7678783323828dad9e0899c557077344ba968cc716b6aeccc1f50a4a5eaa23d6b2bf89eb0a607c2e1c31a395e03b26b65187d8ae5386674fc512ae9790cc9560
2023-11-02 22:04:43 +02:00
Kristaps Kaupe
027682ab2c
CI: Add ShellCheck 2023-10-30 23:16:21 +02:00
roshii
4f4945e5c5 Test min and latest Python version only 2023-10-29 10:06:08 +01:00
Kristaps Kaupe
d25457b209
CI: Disable venv caching 2023-10-19 17:47:52 +03:00
Kristaps Kaupe
906eb7169f
CI: Update Bitcoin Core from 25.0 to 25.1 2023-10-19 17:40:37 +03:00
roshii
bfd5b2146c fix linting 2023-10-06 22:21:24 +02:00
roshii
c8eef50e93 Migrate to modern packaging and src layout 2023-10-05 19:32:20 +02:00
Kristaps Kaupe
c92120619e
GitHub workflow update (test multiple Bitcoin Core versions)
* Add support for testing against multiple Bitcoin Core versions, add
  0.18.0 (oldest officially support for test suite) and 25.0 (latest
  stable release). Previously we tested against hardcoded 0.19.1. IMO
  testing against oldest supported and latest makes sense, if tests pass
  on both, they should pass on releases inbetween too, unless there is
  some behaviour affecting us changed twice.
* Update actions/cache from v2 to v3.

Also changed Core downloads from bitcoin.org to bitcoincore.org.
2023-06-03 14:42:04 +03:00
Kristaps Kaupe
3c0b508f0e
Remove unnecessary commands from setup joinmarket + virtualenv step
They are run by install.sh, no need to run them additionally afterwards.
2023-05-09 20:50:10 +03:00
Kristaps Kaupe
198117f14a
CI: Remove editable installs
Co-authored-by: roshii <roshii@riseup.net>
2023-05-07 12:57:05 +03:00
Kristaps Kaupe
3641f1e1a4
Disable venv caching 2023-05-07 12:47:57 +03:00
Kristaps Kaupe
224de08437
CI: Bump used GitHub Actions to newer versions 2023-04-07 00:04:28 +03:00
Kristaps Kaupe
980edd6b2c
CI: Add Python 3.11 2023-01-10 22:53:12 +02:00
Kristaps Kaupe
3c8f247d1a
CI: Run tests on both Linux and macOS 2022-12-24 10:19:04 +02:00
Kristaps Kaupe
b59fdcd623
Remove Python 3.6 (EOL), add 3.10 2022-12-15 17:23:58 +02:00
undeath
e3cc49bc61
github action test runner 2021-06-29 16:18:58 +02:00
Adam Gibson
41a3ae46c9
make flake verbose and remove comments 2021-06-28 14:20:11 +01:00
Adam Gibson
e25dfda0bb
first GA commit 2021-06-28 13:57:08 +01:00