GlcoinCore/joinmarket
1
0
Fork 0
mirror of https://github.com/JoinMarket-Org/joinmarket-clientserver.git synced 2026-08-13 12:33:40 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge JoinMarket-Org/joinmarket-clientserver#1817: Update minimum supported Bitcoin Core version to 28.1

Browse source 
b4e3fdda47 Update minimum supported Bitcoin Core version to 28.1 (3np)

Pull request description:

  Drop minimum supported Bitcoin Core version from 29.0 to 28.1.

  Minimum version was lifted in #1782. The motivating bitcoin-core issue was patched in 28.1. Bitcoin Core 28.1 was released alongside 29.0. Bitcoin Core 28.3 was released in June this year and has more recent fixes backported than 29.0.

ACKs for top commit:
  kristapsk:
    utACK b4e3fdda47

Tree-SHA512: c4d4c4c09156e01667c87d0e0b5815c3106530363e7d2d2e3a015538520a6c6aeeef28edfd3aeb5ee40c6f0c879d81fb64daa244b8148c32da570b8439c917e5
This commit is contained in:
merge-script 2025-10-28 03:50:09 +02:00
commit 5246c1ccb5
No known key found for this signature in database
GPG key ID: 33E472FE870C7E5D
4 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
.github/workflows/unittests.yml vendored
View file

@ -10,7 +10,7 @@ jobs:
matrix:
os: [macos-13, ubuntu-latest]
python-version: ["3.9", "3.12"]
bitcoind-version: ["29.2"]
bitcoind-version: ["28.3", "29.2"]
steps:
- uses: actions/checkout@v3

2
docs/INSTALL.md
View file

@ -136,7 +136,7 @@ If (a), then note the following two points:
##### Installing Bitcoin Core
If you haven't done so yet, install Bitcoin Core, version 29.0 or newer, as described [here](https://bitcoin.org/en/full-node#windows-10). After starting it for the first time, it will start the Initial Block Download. JoinMarket cannot be used until this is finished. More information on that can be found [here](https://bitcoin.org/en/full-node#initial-block-downloadibd).
If you haven't done so yet, install Bitcoin Core, version 28.1 or newer, as described [here](https://bitcoin.org/en/full-node#windows-10). After starting it for the first time, it will start the Initial Block Download. JoinMarket cannot be used until this is finished. More information on that can be found [here](https://bitcoin.org/en/full-node#initial-block-downloadibd).
##### Configuring Bitcoin Core

2
docs/PAYJOIN.md
View file

@ -39,7 +39,7 @@ So just skip those sections if you already know it.
### Preparatory step: configuring for Bitcoin Core.
Joinmarket currently requires a Bitcoin Core full node, version 29.0 or newer, although it can be pruned.
Joinmarket currently requires a Bitcoin Core full node, version 28.1 or newer, although it can be pruned.
First thing to do: in `scripts/`, run:

2
docs/TESTING.md
View file

@ -1,6 +1,6 @@
### Test instructions (for developers):
Work in your `jmvenv` virtual environment as for all Joinmarket work. Make sure to have [bitcoind](https://bitcoin.org/en/full-node) 29.0 or newer installed. Also need miniircd installed to the root (i.e. in your `joinmarket-clientserver` directory):
Work in your `jmvenv` virtual environment as for all Joinmarket work. Make sure to have [bitcoind](https://bitcoin.org/en/full-node) 28.1 or newer installed. Also need miniircd installed to the root (i.e. in your `joinmarket-clientserver` directory):
(jmvenv)$ cd /path/to/joinmarket-clientserver
(jmvenv)$ git clone https://github.com/Joinmarket-Org/miniircd