0331feb018 Remove cirrus YML file (Tom Trevethan)
09d9486fa0 Migrate CI to GHA (Tom Trevethan)
Pull request description:
Migration of Elements CI from Cirrus (which is closing 1st June) to Github actions.
Notes:
GHA runners have IPV6 disabled in their linux containers. So `feature_proxy.py` and `rpc_blind.py --ipv6` disabled for these, as in https://github.com/bitcoin/bitcoin/pull/30193
`windows-2019` is being deprecated and no runners appear to be readily available. https://github.com/actions/runner-images/issues/12045 (consider changing to `windows-2022`) for `win64-msvc` jobs.
`previous-releases` requires a persistent self-hosted runner. This job was being skipped by Cirrus (with `No public persistent worker pools found!`).
ACKs for top commit:
delta1:
ACK 0331feb018; tested locally
Tree-SHA512: 5c1976a9afc4faa8d41f403f10f1e771763509e751506f9ffcf13e8174ba7a6c1464cfe2045c72f497177654df566f355f2c9e760ffa2ade81cd6c34dc094710
8a0afee1f2 Merge bitcoin/bitcoin#26777: rpc: Remove duplicate field in RPCHelpMan for gettransactions (MarcoFalke)
Pull request description:
Merge https://github.com/bitcoin/bitcoin/pull/26777: rpc: Remove duplicate field in RPCHelpMan for gettransactions
090ad51c80 rpc: Remove duplicate field in RPCHelpMan for gettransactions (Joshua Kelly)
Pull request description:
The field 'comment' appears twice in TransactionDescriptionString, incorrectly - this commit removes the instance of the comment field without a description, preserving the one with a description.
On master, the duplicate fields can be be viewed here: https://github.com/bitcoin/bitcoin/blob/master/src/wallet/rpc/transactions.cpp#L419-L423
TransactionDescriptionString is included in RPC calls such as listtransactions which have functional tests.
ACKs for top commit:
delta1:
ACK 8a0afee1f2; tested locally
Tree-SHA512: c0f0349c571c62e14b2145691e72fbe079c8815015a8e5a26d45fe88a1a68cd39153dba11300084f0e7a8b74a10a836b2b850654bbc338868bf616f73c851d40
090ad51c80 rpc: Remove duplicate field in RPCHelpMan for gettransactions (Joshua Kelly)
Pull request description:
The field 'comment' appears twice in `TransactionDescriptionString`, incorrectly - this commit removes the instance of the comment field without a description, preserving the one with a description.
On master, the duplicate fields can be be viewed here: https://github.com/bitcoin/bitcoin/blob/master/src/wallet/rpc/transactions.cpp#L419-L423
`TransactionDescriptionString` is included in RPC calls such as `listtransactions` which have functional tests.
ACKs for top commit:
w0xlt:
ACK https://github.com/bitcoin/bitcoin/pull/26777/commits/090ad51c80fe02a73f8988c1d5b867d2e90ab2f3
Tree-SHA512: 4bacdafdb517dda2af6d1c193f331b634ae74bd62ac6289c0c288957f39f98a73d07aeab72fbe5bf1ece5532406d4a40a5b8a2277be50115f76c92bb938e21fa
a76dc401d6 Merge bitcoin/bitcoin#24502: wallet: don't create long chains by default (MarcoFalke)
Pull request description:
Cherry pick of bitcoin/bitcoin#24502 with additional functional test to check rejection.
ACKs for top commit:
delta1:
ACK a76dc401d6; tested locally
Tree-SHA512: e053109dfda4cc2603a286641a1376d83f3d6cbaa42603d23d38e02d77e6c56d1e0192d2fb504b70c6ba44d92850f449c65d5bc22cba8bf108eb6cb5bb64ab82
b6369329ce wallettool: do not use fs::remove_all in createfromdump cleanup (Ava Chow)
086e185a8d wallet: introduce method to return all db created files (furszy)
552ce5ca2c use break-system-packages for pip (Tom Trevethan)
53cef282f4 change test order in feature_discount_ct to fix intermittent failure (Tom Trevethan)
Pull request description:
Cherry pick of https://github.com/bitcoin/bitcoin/pull/34215
Required new Files() method to return all db created files for sqlite and bdb (1de423e0a0)
ACKs for top commit:
delta1:
ACK b6369329ce; tested locally
Tree-SHA512: effa9fbaf2c2c2381b1e0f937da4761ded7b017afd0e5d308182767848806df31a318545cd132e0c0f1959b3a16f43d98f72825f4b46285257abfacd52278cea
03d9d8308c Update manpages (Pablo Greco)
d5c0e5bc11 Bump version to 23.4.0-rc2 (Pablo Greco)
6e079ea838 updated documentation for elements chain types (Tom Trevethan)
56b2572cef enabled > 21m for issued assets in GUI amount field (Tom Trevethan)
Pull request description:
Updates master to 8db19e90c8, which fixes a GUI issue after ELIP 203 and a small documentation fix.
Also and bumps version/manpages
ACKs for top commit:
delta1:
ACK 03d9d8308c; tested locally
tomt1664:
Tested ACK 03d9d8308c
Tree-SHA512: a892c33e413dde5c6243e8c7b21987fae8c791154cb356a4c78b68a46cbe8e151df1bc7786d11343def99a92eee22e60efe15d5691c708e5f456a301a8df557d
6e079ea838 updated documentation for elements chain types (Tom Trevethan)
Pull request description:
Change config and RPC documentation for Elements chain type options.
ACKs for top commit:
delta1:
ACK 6e079ea838; just an RPC documentation update
Tree-SHA512: 4128669f5dda2700562706f7d341f37fecbd8e1c5deee2aed56869b20995f474e51af86d6228246c06a2c90fda1251066a7f86bb2fa55732ab46e58deb55b476
56b2572cef enabled > 21m for issued assets in GUI amount field (Tom Trevethan)
Pull request description:
Only pegged asset limited to `MAX_MONEY` for the GUI amount field. Issued assets can have amounts displayed > MAX_MONEY.
ACKs for top commit:
delta1:
ACK 56b2572cef; ran tests locally but have not tested the GUI
Tree-SHA512: 9a04ed9016b420a32bbaa98b80712725691619c5ca854a6b6d0b07e5a91c9ff818e6367a93f6f5c54ae8e0e9e799b6367042c0f823b6c066c5e25a9624b8adc2
de274e59be Update manpages (Pablo Greco)
a36a96175c Bump version to 23.4.0-rc1 (Pablo Greco)
56eb713150 Log status of ELIP 203 (Pablo Greco)
d8052363f3 liquidv1: allow enabling -acceptunlimitedissuances (Pablo Greco)
bd59321098 contrib: upstream my merge-prs.sh changes (Byron Hambly)
Pull request description:
Updates master to c990492c48, which adds support for enabling ELIP 203 in liquidv1. ELIP 202 support was added in 23.3.3rc1, which was renamed to 24.x. Also and bumps version/manpages
ACKs for top commit:
delta1:
ACK de274e59be; tested locally
tomt1664:
Tested ACK de274e59be
Tree-SHA512: 073080a6392cd1c10ce3b26e2faef061f583f7f1759fa3c76a71d8418aa5f9e20c0f128cae244910bacb4c09f69039dd70361bd3ab359845f27e8bb12ab21f95
56eb713150 Log status of ELIP 203 (Pablo Greco)
d8052363f3 liquidv1: allow enabling -acceptunlimitedissuances (Pablo Greco)
Pull request description:
Preparation for the activation of [ELIP 203](https://github.com/ElementsProject/ELIPs/blob/main/elip-0203.mediawiki), we need to move from a hardcoded false to an optionin liquidv1
ACKs for top commit:
tomt1664:
Tested ACK 56eb713150
delta1:
ACK 56eb713150; tested locally, changes allow acceptunlimitedissuances to be configurable on liquidv1 chain
Tree-SHA512: 1671634af6f3dfeaf48c9c6f9aa8598fed1eddc6a279b7bbbfd6d7d7062b89d85a60ec561560308d55ef4e80790db760b8dd20c19167db248d13d41570893314
da2bc865d6 [wallet] don't create long chains by default (glozow)
Additional functional test for too-long-chains rejected.
Pull request description:
Default mempool policy doesn't let you have chains longer than 25 transactions. This is locally configurable of course, but it's not really safe to assume that a chain longer than 25 transactions will propagate. Thus, the wallet should probably avoid creating such transactions by default; set `DEFAULT_WALLET_REJECT_LONG_CHAINS` to true.
Closes#9752Closes#10004
ACKs for top commit:
MarcoFalke:
re-ACK da2bc865d6 only change is fixing typos in tests 🎏
Tree-SHA512: 65d8e4ec437fe928adf554aa7e819a52e0599b403d5310895f4e371e99bbc838219b3097c4d2f775bc870ac617ef6b4227b94291f2b376f824f14e8f2b152f31
bd59321098 contrib: upstream my merge-prs.sh changes (Byron Hambly)
Pull request description:
Cleaned up and lightly documented my updates to the `merge-prs.sh` script. Still need to write a usage doc.
ACKs for top commit:
delta1:
ACK bd59321098; this script is currently being used for merging
Tree-SHA512: 16ca19af21441424d471263ba1bf817856bf3c7d5801a2ce55e83b22cacf62cb92c3bcc84c9f485d173a15b0dda4e0b8b1ec99b3c9cef4835b16aaaafe461d1f
43f9542cad Bump version to 23.3.2 final (Pablo Greco)
Pull request description:
Only version bump changes since rc2
ACKs for top commit:
tomt1664:
ACK 43f9542cad
delta1:
ACK 43f9542cad; only changes RC version for release
Tree-SHA512: a3424d432a8adefa3e4d31d28781e20e8d7fb01ad10286455a722d138621a3d21fc608eb6300085f26f71fbd999866a5b5e062fc1f0e329b41e8cc6ffeb11e8b
73db0cf72b Bump version to 23.3.2-rc2 (Pablo Greco)
6544256fcb Update manpages (Pablo Greco)
4c79d5a572 fix: use liquidnetwork or liquidtestnet for uri in elements mode (Byron Hambly)
8f28d82f57 docs: add github-merge.py process for merging PRs (Byron Hambly)
6c7788adf3 Avoid Simplicity header dependency propogation (Russell O'Connor)
Pull request description:
Updates master to 6bb916a57f which includes fixes for simplicity header dependency and qr code generation for QT
ACKs for top commit:
delta1:
ACK 73db0cf72b; diff looks as expected, tested locally successfully
Tree-SHA512: d23312a81033b759466f9bc2d8bbb0bfcdd5bfd0a1d80b101e8461e62a151841910310e82ed8a1ba4ed6bb8a363f53dc2e8e5674c27b9ebafe02169a88b08ed9
4c79d5a572 fix: use liquidnetwork or liquidtestnet for uri in elements mode (Byron Hambly)
Pull request description:
fixes#1529
ACKs for top commit:
tomt1664:
ACK 4c79d5a572
psgreco:
ACK 4c79d5a572
Tree-SHA512: 00862c3851bd1663ed17dfde9ef155840d4d735b3e61ad890155dccdc9cb7fb4fc086021a9ae1a1030ff8e809dc6ffb46a5aeed35d3c5625b44f65ec6cdae421
8f28d82f57 docs: add github-merge.py process for merging PRs (Byron Hambly)
Pull request description:
Documents how to merge PRs using the github-merge.py script from Bitcoin maintainer tools repo.
ACKs for top commit:
psgreco:
ACK 8f28d82f57
Tree-SHA512: b263dd7715fa71926ceeae053e453a4a19b64fa89c88cb0f84fa15bafbcc1051f35ca4f28a05f41dfc8d3af1d1de9eb2bb6cd832867cf7d7d7772a3c7267777b
6c7788adf3 Avoid Simplicity header dependency propogation (Russell O'Connor)
Pull request description:
The problem with including <simplicity/elements/env.h> in interpreter.h is that now everyone who needs to include interpreter.h also needs access to Simplicity's header files too.
This commit breaks that dependency chain by using forward declarations. It will pay signifigant dividends when elements switches to CMake.
ACKs for top commit:
delta1:
ACK 6c7788a; built and tested locally
apoelstra:
ACK 6c7788adf3; successfully ran local tests
Tree-SHA512: 78d043a094f0a2bb51e0f103313ae568b42ec2852d8fe9a3fbbcad9c0fbf6829ef1347f83bfd361547ec165c01965e7342188a38d8faacfcf90ef70c5b7001f6
