Commit graph

18031 commits

Author SHA1 Message Date
Gregory Sanders
e532664298 allow grabbing genesis transaction(s) when connected 2018-10-25 12:51:53 -04:00
Gregory Sanders
c7e5549317 [#9102] really don't validate genesis block 2018-10-25 12:51:53 -04:00
Gregory Sanders
ccf40db968 connect genesis block transaction outputs to coin db 2018-10-25 12:51:53 -04:00
Gregory Sanders
866da4496b
Merge #447: pin flake8 version to avoid breaking compatibilities
77e8fa4 pin flak8 version to avoid breaking compatibilities (Gregory Sanders)

Pull request description:

  This happened upstream too.

Tree-SHA512: a6d05c86e1421c03ac38ee69c4b5ff7174d7c00b0c965fcd6016a9f9b94510e4a68dce162f4bb47a2ba5d624bfc33cc6ae53fc47264d98e117632f0a6a580bed
2018-10-25 12:08:04 -04:00
Gregory Sanders
77e8fa4ac7 pin flak8 version to avoid breaking compatibilities 2018-10-25 11:25:20 -04:00
Gregory Sanders
725e62ad36
Merge #446: Duplicate serializations of consensus objects to use as Bitcoin seria…
5b4aff7 Duplicate serializations of consensus objects to use as Bitcoin serialization (Gregory Sanders)

Pull request description:

  …lization

  This will allow us to break elements serialization in other PRs such as height in block header.

Tree-SHA512: 1c58bb6caeef8d874579abcf536c7ca4541538e85441f51709971b7c7c5ce9e48e0c6dc09626a27aed0f045fbb1fe21c756b1d3986ce75489cf06fecc16eb15b
2018-10-24 15:27:56 -04:00
Gregory Sanders
5b4aff7108 Duplicate serializations of consensus objects to use as Bitcoin serialization 2018-10-24 15:11:19 -04:00
Gregory Sanders
3d274183d2
Merge #445: [0.17] Duplicate bitcoin functional tests
ef039f0 Add travis build that tests bitcoin functional tests (Gregory Sanders)

Pull request description:

  We're going to keep these tests alive as long as possible to increase modularity/QA of the codebase.

Tree-SHA512: c0639422fe518cd9a5f6eb06f24a4c812d38bdde95f37a6787b10ab009e6ee9ff22b30ea8f79e6cf47581bd0d7577fe149f3e636c4c6f0488c9c6555730b8315
2018-10-24 11:00:37 -04:00
Gregory Sanders
e63e500658
Merge #443: [0.17] add block subsidy argument to allow different/non-inflation chains
7bac720 add block subsidy argument to allow different/non-inflation chains (Gregory Sanders)

Pull request description:

  Previously we just set this to 0 and continued, this allows tests to otherwise pass up until this point.

Tree-SHA512: e4e6ae85779a6079ccad38941b4b0dbb3362fa4d902aff5cedbea4641201646f6946cc0d140cb0fdac81c5009ff983baabebcbeeed99f089e44ad492fd6cd1ee
2018-10-24 10:57:48 -04:00
Gregory Sanders
ef039f001b Add travis build that tests bitcoin functional tests 2018-10-23 13:29:57 -04:00
Gregory Sanders
7bac720925 add block subsidy argument to allow different/non-inflation chains 2018-10-23 09:45:16 -04:00
Jorge Timón
146d80ff9d
Merge #441: rename mandatory coinbase test, add it to test_runner list
2d6f137 rename mandatory coinbase test, add it to test_runner list (Gregory Sanders)

Pull request description:

Tree-SHA512: cd35c6360cbc59db480dd4ced1d07699b947ecaede985e331a9ca389af9636e942bea29bbd8d976405f0abc1e3fe8f6fbbaa36ef1d70bdbb9267e19ce61bcfbe
2018-10-22 18:18:46 +02:00
Gregory Sanders
2d6f1374c2 rename mandatory coinbase test, add it to test_runner list 2018-10-22 09:49:07 -04:00
Gregory Sanders
101ec23faa
Merge #430: [0.17] Mandatory coinbase feature
0d20b55 add mandatory coinbase functional test (Gregory Sanders)
edb0532 add consensus.mandatory_coinbase_destination (Gregory Sanders)

Pull request description:

  Includes functional test

Tree-SHA512: e7fdf4584c5a61516778dff272c0f4c9964fee515b705c4fd3ade842954bcc7426bdaf5273a64e4b2472fedc940ead7552c0ec80b4608aac381f91a8f2356d95
2018-10-22 09:22:24 -04:00
Gregory Sanders
0d20b55374 add mandatory coinbase functional test 2018-10-18 15:17:15 -04:00
Gregory Sanders
edb053276b add consensus.mandatory_coinbase_destination 2018-10-18 15:17:15 -04:00
Gregory Sanders
de842cb58f
Merge #432: [0.17] QA: Use resgtest2 chain instead of regtest for rpc tests
a1e0c56 QA: Use resgtest2 chain instead of regtest for rpc tests (Jorge Timón)
4454c52 QA: Adapt BitcoinTestFramework for chains other than "regtest" (Jorge Timón)
a06be15 Testchains: Introduce custom chain whose constructor... (Jorge Timón)
46749eb Testchains: Qt: Simplify network/chain styles and add a default purple (Jorge Timón)
c0c1e38 Testchains: Generic selection with -chain=<str> in addition of -testnet and -regtest (Jorge Timón)
56515c3 9102: Really don't validate genesis block (Gregory Sanders)

Pull request description:

  Backport of https://github.com/bitcoin/bitcoin/pull/8994

  The tests seem to pass with:

  ```
  python3 ./test/functional/test_runner.py -j4 --extended
  ```

  Let's please try to keep all general review things on https://github.com/bitcoin/bitcoin/pull/8994 and elements-specific things here.

  Dependencies:

  - [x] [0.17] Don't edit Chainparams after initialization #427
  - [x] [0.17] Test: Fix example_test.py #434

Tree-SHA512: e216587b6f9d3a462372915e01c8eb3c65a61e4ea29f398e65a7fc03a3ea5676c4711527b5cc2c115893591e7cd5b0ecd2f1fac4faf7ef747a022e2657bc99d4
2018-10-16 14:19:47 -04:00
Jorge Timón
a1e0c56a55
QA: Use resgtest2 chain instead of regtest for rpc tests 2018-10-16 18:32:20 +02:00
Jorge Timón
4454c52ae6
QA: Adapt BitcoinTestFramework for chains other than "regtest" 2018-10-16 18:32:19 +02:00
Jorge Timón
a06be15279
Testchains: Introduce custom chain whose constructor...
...reads params from regular arguments
2018-10-16 18:32:17 +02:00
Jorge Timón
46749eba94
Testchains: Qt: Simplify network/chain styles and add a default purple
...for unkown chains
2018-10-16 18:30:08 +02:00
Jorge Timón
c0c1e38647
Testchains: Generic selection with -chain=<str> in addition of -testnet and -regtest 2018-10-16 18:30:07 +02:00
Gregory Sanders
56515c34cb
9102: Really don't validate genesis block 2018-10-16 17:03:11 +02:00
Jorge Timón
504269835d
Merge #434: [0.17] Test: Fix example_test.py
1f1c7df Test: Fix example_test.py (Jorge Timón)

Pull request description:

  Fix this useful test in -extended.

  IMO should be backported to bitcoin/0.17, but I'm not sure if it's wanted there.

Tree-SHA512: d67c186c3dd59d13ec7c9cc79ae6dfd5a0dbd2ea76a8e3b5eb0020dedd08e004929741ed7b4ac9ca2a30da10b11e73179b0967023f59892eb59cb8d68ca67294
2018-10-16 17:00:55 +02:00
Gregory Sanders
0a142d9d3c
Merge #435: [0.17] add jtimon/gsanders/stevenroose git signing keys
f9179fe add jtimon/gsanders/stevenroose git signing keys (Gregory Sanders)

Pull request description:

Tree-SHA512: d0f563c68bf1c469bd4ef6a7ef6582f96f8e06f2372ace05db06e1f1a5edea83e814e0b35f820ca2668db11e99c8b6bb6dbfde715a71766b5452f1b35c8c6868
2018-10-15 15:10:27 -04:00
Gregory Sanders
f9179fe6b4 add jtimon/gsanders/stevenroose git signing keys 2018-10-15 14:45:36 -04:00
Jorge Timón
1f1c7df5a6
Test: Fix example_test.py 2018-10-15 00:35:38 +02:00
Jorge Timón
a31ab0ec26
Merge #427: [0.17] Don't edit Chainparams after initialization
06f1b42 Don't edit Chainparams after initialization (Jorge Timón)
875a47c MOVEONLY: Move versionbits info out of versionbits.o (Jorge Timón)

Pull request description:

  This is a backport of https://github.com/bitcoin/bitcoin/pull/13311 since it's already merged, merging this in elements-0.17 should at least make the next rebase slightly easier. And since we're heavily touching chainparams in elements, I think it's a good thing.

Tree-SHA512: 177f6396a34ecf87b609b39a108cc2b1e5b49bd8d12b705a4ae0241c7a5007db754ff01d6d045ee1e6a219ec6c6767663cd98558752c83961c4aff3378aef5a2
2018-10-13 03:16:19 +02:00
Jorge Timón
06f1b422cf
Don't edit Chainparams after initialization 2018-10-12 20:51:55 +02:00
Jorge Timón
875a47cc41
MOVEONLY: Move versionbits info out of versionbits.o 2018-10-12 20:51:54 +02:00
Wladimir J. van der Laan
e1ed37edae
Merge #14157: [0.17] doc: merge upstream release-notes from bitcoin-core/bitcoin-devwiki
786825c719 doc: Update release-notes.md from upstream devwiki (fanquake)

Pull request description:

  sipa [suggested in IRC](https://botbot.me/freenode/bitcoin-core-dev/2018-09-06/?msg=104094793&page=1) that now would be a good time to merge the release notes from the [bitcoin-devwiki](https://github.com/bitcoin-core/bitcoin-devwiki).

Tree-SHA512: 6d9631e12147b4e64f5382a64cceb71b84ca21bdb3fc516248de79968f7f26e74ab5d569e3767018581bcda4d5b8c8ec103b1795929e98f7e9c4d6e95379f7de
2018-10-01 12:04:33 +02:00
fanquake
786825c719
doc: Update release-notes.md from upstream devwiki 2018-09-30 09:44:19 +08:00
Cory Fields
480d6bb078
depends: fix bitcoin-qt back-compat with older freetype versions at runtime
A few years ago, libfreetype introduced FT_Get_Font_Format() as an alias for
FT_Get_X11_Font_Format(), but FT_Get_X11_Font_Format() was kept for abi
backwards-compatibility.

Our qt bump to 5.9 introduced a call to FT_Get_Font_Format(). Replace it with
FT_Get_X11_Font_Format() in order to remain compatibile with older freetype,
which is still used by e.g. Ubuntu Trusty.

Github-Pull: #14348
Rebased-From: 430bf6c7a1
Tree-SHA512: fd22b824e7251a7975d9e9222eff06d2b04ebf30e13aeccab580596c042b3abe2f62da1f0ef75106b0b171368ee1062ef2f459cfa435aa54826766a9005b80df
2018-09-29 14:24:02 +02:00
Wladimir J. van der Laan
c64128df58
Merge #14248: [0.17] Fix crash bug with duplicate inputs within a transaction
0d49c82edd [qa] backport: Test for duplicate inputs within a transaction (Suhas Daftuar)
833180f538 Fix crash bug with duplicate inputs within a transaction (Suhas Daftuar)

Pull request description:

  This is a backport of #14247.

Tree-SHA512: 4d3b6244d501a48f56a728c571dac9a346019a671434edac943f4f535ef8f94ec6bfd569a0585ad5e23a6e488ecd7e0079510cbb10a2a22f576eb36d73accb0c
2018-09-18 01:20:52 +02:00
Suhas Daftuar
0d49c82edd [qa] backport: Test for duplicate inputs within a transaction 2018-09-17 16:15:18 -04:00
Suhas Daftuar
833180f538 Fix crash bug with duplicate inputs within a transaction
Introduced by #9049
2018-09-17 16:14:31 -04:00
Pieter Wuille
465a583f9d
Replace duplcate reference with reference to reference doc
Github-Pull: #14096
Rebased-From: 2b5d6f8df2
Tree-SHA512: 79af808c581ebb17d60aab8322b1debcc4182480b84eaedcbfac1e67c8b543c61df22789095742d67d732dba35e7e5fad77912385b695f89fb0f44f75db11560
2018-09-06 14:52:00 +02:00
Pieter Wuille
eece974d0a
Adjust TODO link
Github-Pull: #14096
Rebased-From: 89709db7a2
Tree-SHA512: 0bf74e1179bee6e616d8fd2c125411ef30611d9aa3b32412025615a793abbc629a7b6d89a89ef05b11ac3541cc869c0caebba2d00942fdd6ab8d2e98d9b9caca
2018-09-06 14:51:59 +02:00
Pieter Wuille
0f681cecad
Add descriptor reference documentation
Github-Pull: #14096
Rebased-From: 9254ffcf2d
Tree-SHA512: 1fc466177dbe3b57b0025c102b1e75e4b05544440819885da7a85b70d20329fc3f6f4cbf89d7d6a48881e6ad176d81f7396f02925586140e19468a2f28f3414e
2018-09-06 14:51:54 +02:00
MarcoFalke
eb202ea21d
test: Add test for config file parsing errors
Github-Pull: #14105
Rebased-From: ed2332aeff
Tree-SHA512: 17fa88a2848f1c9c9c8a127b5ea4c45761ce8e06a609dd40f8e90bb9117d88c9d2c81e752c9c0f1a44ecadbb5bedd2973bc4548da2a6d463c789797191e85ab1
2018-09-06 13:54:05 +02:00
Wladimir J. van der Laan
83aafd5b32
util: Report parse errors in configuration file
Report errors while parsing the configuration file, instead of silently
ignoring them.

    $ src/bitcoind -regtest
    Error reading configuration file: parse error on line 22: nodebuglogfile, if you intended to specify a negated option, use nodebuglogfile=1 instead
    $ src/bitcoind -regtest
    Error reading configuration file: parse error on line 22: sdafsdfafs
    $ src/bitcoind -regtest
    Error reading configuration file: parse error on line 24: -nodebuglogfile=1, options in the configuration file must be specified without leading -

Github-Pull: #14105
Rebased-From: a66c0f78a9
Tree-SHA512: 2b6be1ab643623e6ef9b53354820147a6c5d2baae3795ffe428fc60d8563ec00a68a379aee4029380f80f892abe23763afb1c75c32b60a13bffe7b82496bf2bb
2018-09-06 13:54:01 +02:00
Wladimir J. van der Laan
6ba1f15432
Merge #14152: [0.17] doc: Change documentation for =0 for non-boolean options
6bfee8a8c2 doc: Update v0.17.0.0 manpages (MarcoFalke)
2936dbc557 doc: Change documentation for =0 for non-boolean options (Wladimir J. van der Laan)

Pull request description:

  Github-Pull: #14100
  Rebased-From: e9a78e9b3b

  Includes the bumped manpages.

Tree-SHA512: 73d2dadb45418882122313975c0ab0e9f58310697d996dd2edeb400ebe73b3a45f1157c8a7fe65ae1f53d9ce68a88aae7c701f3e82e0b4db4c9417b36ddfecc0
2018-09-06 11:22:00 +02:00
MarcoFalke
6bfee8a8c2 doc: Update v0.17.0.0 manpages 2018-09-05 14:50:53 -04:00
Wladimir J. van der Laan
2936dbc557 doc: Change documentation for =0 for non-boolean options
PR #12713 changed the interpretation for negation of non-boolean options
(e.g. -noconnect) to no longer set the option to 0, but to remove it
from the options.

I think this is better because it gets rid of the special meaning of
'0'.

However it needs to be documented. I attempt to do so in this PR.
Addreses #14064.

Github-Pull: #14100
Rebased-From: e9a78e9b3b
2018-09-05 14:39:36 -04:00
Gregory Sanders
2307a6eb2b
fix walletcreatefundedpsbt deriv paths, add test
Github-Pull: #14055
Rebased-From: 61fe653bd9
Tree-SHA512: 2f3edf62318fab4b405b47788096005f59cbe6ba4723fe51ce3b386539a58b7ea7369c31c3840c6baa76cdf6ba8f8440f977c36e2ee2916e711d7872bd1eadad
2018-08-28 23:11:41 +02:00
Wladimir J. van der Laan
5f71eac634
Merge #14084: [0.17] qa: Backports
cf3d7f94c2 Use assert when running from multithreaded code as BOOST_CHECK_* are not thread safe (Jesse Cohen)
fab0fbefcf qa: Stop txindex thread before calling destructor (MarcoFalke)
b5ec6d4bf8 Docs: Fix help message typo optiona -> optional (Ben Woosley)

Pull request description:

  Fixes to make the unit tests and bench pass with the thread sanitizer (beside the issue with fChecked https://github.com/bitcoin/bitcoin/issues/14058#issuecomment-416042917).

  For testing: `./configure --with-sanitizers=undefined,thread && make -j 16 && ./src/test/test_bitcoin`

Tree-SHA512: 5cb85ecc278b719dba03240265e93424ed1a28671834da7590adab88c2d43c6e6cbf3269bbe2fd79e5ed3a85ec77a268e05301e7a7421cf6a97d413dddac6327
2018-08-28 11:58:19 +02:00
Jesse Cohen
cf3d7f94c2 Use assert when running from multithreaded code as BOOST_CHECK_* are not thread safe
Github-Pull: #14069
Rebased-From: 737670c036
2018-08-27 13:44:41 -04:00
MarcoFalke
fab0fbefcf qa: Stop txindex thread before calling destructor
Github-Pull: #14071
Rebased-From: faf4a9b674
2018-08-27 13:44:14 -04:00
Ben Woosley
b5ec6d4bf8 Docs: Fix help message typo optiona -> optional
Github-Pull: #14056
Rebased-From: 7d0a8ad310
2018-08-27 13:43:55 -04:00
Luke Dashjr
3e4829af09
Bugfix: NSIS: Exclude Makefile* from docs
Otherwise, the generated Makefile is included in the NSIS-installed documentation, which can lead to non-determinism (eg, if gawk is installed on some build VMs, but others only have mawk)

Github-Pull: #14018
Rebased-From: 8563341714
Tree-SHA512: 2d219a4a2027bcd7359b7320bafc6b7cd3bde3dcf9309ddd6198ff67407470025baa71e6d0ed3d6cec081834ddc9a0247043865eb26737e6fd0d2f09574f5932
2018-08-22 15:29:22 +02:00