56eb713150 Log status of ELIP 203 (Pablo Greco)
d8052363f3 liquidv1: allow enabling -acceptunlimitedissuances (Pablo Greco)
Pull request description:
Preparation for the activation of [ELIP 203](https://github.com/ElementsProject/ELIPs/blob/main/elip-0203.mediawiki), we need to move from a hardcoded false to an optionin liquidv1
ACKs for top commit:
tomt1664:
Tested ACK 56eb713150
delta1:
ACK 56eb713150; tested locally, changes allow acceptunlimitedissuances to be configurable on liquidv1 chain
Tree-SHA512: 1671634af6f3dfeaf48c9c6f9aa8598fed1eddc6a279b7bbbfd6d7d7062b89d85a60ec561560308d55ef4e80790db760b8dd20c19167db248d13d41570893314
bd59321098 contrib: upstream my merge-prs.sh changes (Byron Hambly)
Pull request description:
Cleaned up and lightly documented my updates to the `merge-prs.sh` script. Still need to write a usage doc.
ACKs for top commit:
delta1:
ACK bd59321098; this script is currently being used for merging
Tree-SHA512: 16ca19af21441424d471263ba1bf817856bf3c7d5801a2ce55e83b22cacf62cb92c3bcc84c9f485d173a15b0dda4e0b8b1ec99b3c9cef4835b16aaaafe461d1f
43f9542cad Bump version to 23.3.2 final (Pablo Greco)
Pull request description:
Only version bump changes since rc2
ACKs for top commit:
tomt1664:
ACK 43f9542cad
delta1:
ACK 43f9542cad; only changes RC version for release
Tree-SHA512: a3424d432a8adefa3e4d31d28781e20e8d7fb01ad10286455a722d138621a3d21fc608eb6300085f26f71fbd999866a5b5e062fc1f0e329b41e8cc6ffeb11e8b
73db0cf72b Bump version to 23.3.2-rc2 (Pablo Greco)
6544256fcb Update manpages (Pablo Greco)
4c79d5a572 fix: use liquidnetwork or liquidtestnet for uri in elements mode (Byron Hambly)
8f28d82f57 docs: add github-merge.py process for merging PRs (Byron Hambly)
6c7788adf3 Avoid Simplicity header dependency propogation (Russell O'Connor)
Pull request description:
Updates master to 6bb916a57f which includes fixes for simplicity header dependency and qr code generation for QT
ACKs for top commit:
delta1:
ACK 73db0cf72b; diff looks as expected, tested locally successfully
Tree-SHA512: d23312a81033b759466f9bc2d8bbb0bfcdd5bfd0a1d80b101e8461e62a151841910310e82ed8a1ba4ed6bb8a363f53dc2e8e5674c27b9ebafe02169a88b08ed9
4c79d5a572 fix: use liquidnetwork or liquidtestnet for uri in elements mode (Byron Hambly)
Pull request description:
fixes#1529
ACKs for top commit:
tomt1664:
ACK 4c79d5a572
psgreco:
ACK 4c79d5a572
Tree-SHA512: 00862c3851bd1663ed17dfde9ef155840d4d735b3e61ad890155dccdc9cb7fb4fc086021a9ae1a1030ff8e809dc6ffb46a5aeed35d3c5625b44f65ec6cdae421
8f28d82f57 docs: add github-merge.py process for merging PRs (Byron Hambly)
Pull request description:
Documents how to merge PRs using the github-merge.py script from Bitcoin maintainer tools repo.
ACKs for top commit:
psgreco:
ACK 8f28d82f57
Tree-SHA512: b263dd7715fa71926ceeae053e453a4a19b64fa89c88cb0f84fa15bafbcc1051f35ca4f28a05f41dfc8d3af1d1de9eb2bb6cd832867cf7d7d7772a3c7267777b
6c7788adf3 Avoid Simplicity header dependency propogation (Russell O'Connor)
Pull request description:
The problem with including <simplicity/elements/env.h> in interpreter.h is that now everyone who needs to include interpreter.h also needs access to Simplicity's header files too.
This commit breaks that dependency chain by using forward declarations. It will pay signifigant dividends when elements switches to CMake.
ACKs for top commit:
delta1:
ACK 6c7788a; built and tested locally
apoelstra:
ACK 6c7788adf3; successfully ran local tests
Tree-SHA512: 78d043a094f0a2bb51e0f103313ae568b42ec2852d8fe9a3fbbcad9c0fbf6829ef1347f83bfd361547ec165c01965e7342188a38d8faacfcf90ef70c5b7001f6
Changes tweakfedpegscript to return both p2wsh and p2shwsh version of
the tweaked address.
"address" has been removed from the result and replaced with "p2wsh" and
"p2shwsh".
In CreatePeginWitnessInner, the MerkleBlock is always serialized without
witness: PROTOCOL_VERSION | SERIALIZE_TRANSACTION_NO_WITNESS
In DecomposePeginWitness before this change, the MerkleBlock was
deserialized with witness: PROTOCOL_VERSION
This was only noticed as an issue in the pegin subsidy implementation,
in a failure in the feature_dynafed functional test. In the
test_transition_mempool_eject test case, the Merkle block proof is coming
from the same chain where we are creating a pegin.
See the comment: "hack: since we're not validating peg-ins in parent chain,
just make both the funding and claim tx on same chain (printing money)"
I haven't investigated enough to explain why this causes a
deserialization failure in this specific case, but presumably this change
is correct since we're always serializing without witness. Before this
DecomposePeginWitness was only used in src/psbt.cpp
87c0b44f78 Squashed 'src/simplicity/' changes from 6d503ea4f8..49b96499a6 (Byron Hambly)
73d1e521bf docs: add simplicity code update instructions (Byron Hambly)
Pull request description:
Updates Simplicity C source subtree from current master BlockstreamResearch/Simplicity@d190505509
Adds new document describing the process.
Pushed the C-master branch subtree split to my repo [delta1/simplicity/tree/C-master](https://github.com/delta1/simplicity/tree/C-master) and upstreamed in BlockstreamResearch/Simplicity#330
ACKs for top commit:
delta1:
ACK 4539002bee; compiled and tested locally
Tree-SHA512: e9fab8baa728ac122597bf2e3c5ae4fe1c5956c655fc336e1cc7a2be591f1deebcab32004a8b6b4ad359c51154ad47bca5f40c21d06823d5d059a6d66efb15af
49b96499a6 Replace Bitcoin Relative Timelock Jets
89ddb43eed Mark depricated parts of the TxEnv as obsolete
ff5d6fe4f7 Deprecate Broken Jets
ae008201ac Test Bitcoin jet deserialization
e81b68f197 Add GenPrimitive --bitcoin option
7887d16f24 Bitcoin specific fee jets
68603073b3 Bitcoin specific environment
ae3287e60f Refactor Makefile
99e3804e2d C: replace string initializations with arrays
c3dd9331cd Allow building on non-intel systems
git-subtree-dir: src/simplicity
git-subtree-split: 49b96499a6bb93b31d2f712fc1d4524f341ae640
The problem with including <simplicity/elements/env.h> in interpreter.h is that
now everyone who needs to include interpreter.h also needs access to
Simplicity's header files too.
This commit breaks that dependency chain by using forward declarations. It will
pay signifigant dividends when elements switches to CMake.
eb64d2486f Merge bitcoin/bitcoin#32473: Introduce per-txin sighash midstate cache for legacy/p2sh/segwitv0 scripts (merge-script)
Pull request description:
Backport of https://github.com/bitcoin/bitcoin/pull/32473
Additional cache index bit added for sighash combination with `SIGHASH_RANGEPROOF`
ACKs for top commit:
delta1:
ACK eb64d2486f
Tree-SHA512: 94014e726ff16473809672f3e01a8e4d11c4abd38b3ae3ae64b8b9ae61be2e3c246157dca5a3a3afc4b85cc8ec69e23181af8f11c36e0b43cfac2dcb3e2e8d70
