f2161b411 Improve raw peg-in creation logic/help and add basic tests (Gregory Sanders)
Pull request description:
shores up concerns in https://github.com/ElementsProject/elements/issues/465 and fixes a return variable help text. Adds tests.
Tree-SHA512: d32305a355c3bbac22c9cf5ceab57825f9dd1ced40a401cda62d25cba4313a832032720b0ecc30f2ca0025c3992099d32660fec566955dd00973ffb42362e32b
0064b03 Add Asset parameter to MutateTxAddOutData (yoshihide shimada)
0dd6605 Remove comma for `claimpegin` in command line help info (Stefan Liu)
a2715eb validation: change pindexPrev->nHeight + 1 to nHeight (shafisher)
16113d8 Removed redundant .rpcuser, .rpcpassword (wintercooled)
370e797 Changed config file to work with new core v0.17 format as well as previous versions (wintercooled)
Pull request description:
Core v0.17 now handles config file settings differently and loads the existing config settings as mainnet and not regtest. This means our e1 and e2 nodes in the tutorial can't connect.
This PR makes the bitcoin.conf file compatible with both formats. Without this change the tutorial code fails if you are using bitcoind v0.17.0.0.
REF: https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes/release-notes-0.17.0.md
If the following options are not in a section, they will only apply to mainnet:
`addnode=`, `connect=`, `port=`, `bind=`, `rpcport=`, `rpcbind=` and `wallet=`.
The options to choose a network (`regtest=` and `testnet=`) must be specified
outside of sections.
Tested with bitcoind v0.16.2.0 and v0.17.0.0
Tree-SHA512: 3136703da17570e410c1e86ab31f3ac0bca60847164dd10e75a57affd1b7b67fdfbba2be5437ad9ffdd5428c10f6d34073d3e746f55dacda858ab47b517cd3fc
61cbc79 changed link name for easier diff (wintercooled)
ef0451d added link to schnorr as research (wintercooled)
2652861 Modified intro text (wintercooled)
f68ba12 Modified what is elements? text (wintercooled)
b0ac198 changed link from github.io to .org (wintercooled)
7b2a331 Amend links to point at new .org site content (wintercooled)
abb7b01 Add some additional comments about BitcoindRPCCheck infra (Gregory Sanders)
62c56f4 don't set CorruptionPossible for peg-in transaction failure (Gregory Sanders)
5d7cd6b parameterize the rpc re-checking of peg-in validation failed blocks (Gregory Sanders)
ba8d498 bitcoind rpc check should take main locks for mapBlockIndex, check for key (Gregory Sanders)
Previously the peg-in validation logic was done in script
which means it was handled correctly by mempool/block logic.
We then moved these checks outside of script, which means
that these checks aren't multithreaded/batched, and return
the specific error states, including CorruptionPossible.
This means that blocks are never considered permanently invalid and
in certain circumstances tried in an infinite loop.
Instead we mark it as a normal failure, and allow the peg-in invalid
block queue to take care of it instead.
0184575 re-enable failing travis build (Gregory Sanders)
f6875bd fix use after free in peg-in mempool logic (Gregory Sanders)
ea9d92d only try to set best chain if signal is registered (Gregory Sanders)
61c5491 fix undefined behavior in confidential commitment serialization (Gregory Sanders)
9545ca3 qa: Disable -printtoconsole in feature_fedpeg (Steven Roose)
1451e86 qa: Remove pegging.py in favor of feature_fedpeg.py (Steven Roose)
498877e QA: Fix feature_fedpeg.py to work with 0.17.0 (Jorge Timón)
a7736f8 QA: Add test to get 'Given claim_script is not hex' error (Jorge Timón)
35364b6 rpc: reject non-hex strings for claim_script (Gregory Sanders)
07c617b qa: Support using bitcoind in fedpeg test (Steven Roose)
729969d QA: Special case for regtest, expected to be used for binaries that lack -chain (Jorge Timón)
