Commit graph

6136 commits

Author SHA1 Message Date
Jon Atack
7f56623441 Put lock logging behind DEBUG_LOCKCONTENTION preprocessor directive 2025-02-15 00:22:57 -08:00
Byron Hambly
2f1b86e84a
lint: fix shellcheck, spelling, and locale 2025-02-13 16:08:39 +02:00
Byron Hambly
5cb3acef29
Merge pull request #1310 from GoodDaisy/master
Fix typos
2025-02-13 09:47:55 +02:00
Byron Hambly
e41b225107
Merge pull request #1384 from apoelstra/2024-12--simple-fuzz
simplicity: add fuzz target
2025-02-12 14:15:27 +02:00
Byron Hambly
2c9c6cd7a0 test: add discountvsize test vectors 2025-02-11 11:21:18 -08:00
Andrew Poelstra
bd852baca6
ci: add more ubsan suppressions 2025-02-11 16:12:29 +00:00
MarcoFalke
56eec70de4
Fix signed integer overflow in prioritisetransaction RPC
Cherry-pick of fa52cf8e11
https://github.com/bitcoin/bitcoin/pull/23418 (2/2)
2025-02-11 13:47:57 +00:00
Byron Hambly
99c2ee7f9a
Merge pull request #1399 from apoelstra/2025-02--fuzz-fixes
various bugfixes for new fuzz test vectors
2025-02-11 09:49:42 +02:00
Byron Hambly
22089ac8f6
Merge pull request #1372 from delta1/issues-1371
decodepsbt: add asset/assetcommitment to input.witness_utxo
2025-02-11 08:47:17 +02:00
Andrew Poelstra
b90ef38727
ubsan: add suppression for simplicity 2025-02-11 03:00:51 +00:00
Pablo Greco
e6aa6e773e CI: example_elements_code_tutorial test test uses initialfreecoins, disable for descriptor wallets 2025-02-06 13:35:38 -08:00
Pablo Greco
a33ceacdbc CI: feature_tapscript_opcodes test uses initialfreecoins, disable for descriptor wallets 2025-02-06 13:35:38 -08:00
Pablo Greco
87808101be CI: feature_taphash_pegins_issuances test uses initialfreecoins, disable for descriptor wallets 2025-02-06 13:35:20 -08:00
Pablo Greco
e3c318b2b8 CI: discounttests use initialfreecoins, disable for descriptor wallets 2025-02-06 13:35:20 -08:00
Pablo Greco
6991cf7960 CI: trim_headers test uses combineblocksigs, disable for descriptor wallets 2025-02-06 13:35:20 -08:00
Pablo Greco
1ecd5821e8 CI: wallet_elements_regression_1263 uses getpeginaddress, disable for descriptor wallets 2025-02-06 13:35:20 -08:00
Pablo Greco
74cae2d9ec CI: use default wallet name in wallet_elements_21million 2025-02-06 13:35:20 -08:00
Andrew Poelstra
b1b4e6d5c9 Sanitize libsimplicity
Without this patch, the --with-sanitizers config flag has no effect on
the copy of libsimplicity in Elements Core. This means that we aren't
running asan or tsan when we intend to, and also means that when fuzzing
we aren't instrumenting the Simplicity binary.

The result is extremely bad fuzz coverage and missed bugs.

ubsan suppression for simplicity sha256.c

ubsan detects when a left shift would overflow an integer type. This is
not UB (it would be if you tried to shift more than the type's width in
one shot) but "may be unintentional" and is therefore detected.

Add a whitelist to the giant list of whitelists.
2025-01-31 11:43:23 -05:00
Byron Hambly
4303fa500d
test: add functional test for issue 2025-01-14 15:25:05 +02:00
Byron Hambly
248b93dd9f
decodepsbt: add asset/assetcommitment to input.witness_utxo 2024-11-01 09:22:18 +02:00
Andrew Poelstra
626e3aeafb
test: add functional simplicity activation test 2024-10-08 14:41:40 +00:00
Andrew Poelstra
850b82095c
disable simplicity on regtest
We want to test Simplicity activation using evbparams.
2024-10-08 14:41:39 +00:00
Russell O'Connor
afee926dca Simplicity Functional Tests. 2024-10-07 14:39:10 -04:00
Russell O'Connor
bcd508f409 Add Simplicity Deployment structure 2024-10-07 14:39:10 -04:00
Russell O'Connor
5224c1abbb Exclude simplicity directory 2024-10-07 14:38:19 -04:00
Byron Hambly
09c5068ab1
discount: fix weight calculation
Thanks to Jon Griffiths for picking up that the amount and nonce discount
should be multiplied by the witness scaling factor as they form part of
the base transaction.
2024-09-25 15:18:38 +02:00
Byron Hambly
d0f714638a
feat: add discountweight to TxToUniv 2024-09-20 14:39:13 +02:00
Byron Hambly
f107021869
fix: discountct package mining 2024-09-09 12:03:33 +02:00
Byron Hambly
b0d6cde2d0
fix: use discountvsize in miner if discount enabled 2024-08-16 12:35:04 +02:00
Byron Hambly
47d6c34382
discount: fix override for creatediscountct 2024-07-24 09:34:16 +02:00
Byron Hambly
eed85dc5df
getblockchaininfo: add trim_headers field 2024-06-05 11:21:16 +02:00
Byron Hambly
4171939b58
test: add trim_headers functional test
(cherry picked from commit 630870f21d)
2024-05-30 16:02:27 +02:00
James Dorfman
6fb780d8d8 CI: fix linting errors 2024-05-21 05:34:30 +00:00
Byron Hambly
3ebc35359f
discount: add functional tests 2024-05-14 19:03:37 +02:00
Byron Hambly
98c8e4f387
test: fix tests broken by change to getpeginaddress
Fixes 2 functional tests failing since PR #1327 changes getpeginaddress
to only be valid when IsInitialBlockDownload is false
2024-05-06 14:21:44 +02:00
GoodDaisy
662e11857f fix typo in test/functional/feature_tapscript_opcodes.py 2024-01-12 21:50:33 +08:00
GoodDaisy
97d7bccc4a fix typo in test/functional/feature_blocksign.py 2024-01-12 21:48:48 +08:00
GoodDaisy
3516afccf7 fix typo in test/bitcoin_functional/functional/README.md 2024-01-12 21:48:42 +08:00
Byron Hambly
9368fbac1c
test: fix flaky test wallet_groups.py
since the SRD coin selection was added, Elements sometimes picks a 1.0
input instead of 0.5 in this test
2023-11-22 08:55:40 +02:00
James Dorfman
48ca8b0f76 test: fix bug in wallet_groups.py functional test that was introduced in merge of bitcoin/bitcoin#22364 in 00f2e32 2023-11-15 20:01:50 +00:00
James Dorfman
ec4c2a4898 test: fix feature_taphash_pegins_issuances.py
The first transaction was failing with bad-txns-inputs-missingorspent
because the "input" selected with fundrawtransaction was the
anyonecanspend initialfreecoins.

Fixed by first spending the initialfreecoins to "real" outputs.
2023-11-13 15:33:58 +00:00
Byron Hambly
d215bf7f91 test: fix feature_tapscript_opcodes.py
The first transaction from create_taproot_utxo was failing with
bad-txns-inputs-missingorspent because the "input" selected with
fundrawtransaction was the anyonecanspend initialfreecoins.

Fixed by first spending the initialfreecoins to "real" outputs.
2023-11-13 09:06:43 +00:00
James Dorfman
8ccb3e1604 test_runner: re-enable the now-passing 'feature_taproot.py' 2023-11-13 03:17:08 +00:00
James Dorfman
eb24b3eb39 test_runner: re-enable the now-passing 'wallet_basic.py --descriptors' 2023-11-09 06:42:33 +00:00
James Dorfman
06423a6aac test: remove useless comment from feature_taproot_opcodes
The line immediately below the commented out code I removed explicitly
tests the exact behaviour which was being questioned in the comment.

This indicates that the comment was incorrect.
2023-11-09 06:34:34 +00:00
Pablo Greco
20c5630f8c
Merge pull request #1277 from delta1/issues-1259
fix: assert failure on non-policy asset consolidation in CreateTransactionInternal
2023-10-27 12:38:05 -03:00
James Dorfman
e02024e53f test: add new elements_code_tutorial functional test 2023-10-27 15:23:36 +00:00
James Dorfman
5b72ae23af
coinselection: fail if each non-policy asset doesn't have a solution 2023-10-23 16:51:09 +02:00
Byron Hambly
d3ffd2a380
test: add functional test for issue #1259
Adds a functional test to cover the issue uncovered in #1259, where
calling fundrawtransaction with many non-policy inputs and no policy
recipients results in an assertion failure and a crash.

Fixed in #1258.

(cherry picked from commit a8b0ed6f96)
2023-10-23 16:43:20 +02:00
James Dorfman
c248983aab
Merge pull request #1276 from delta1/issues-1263
fix: segfault on getpeginaddress rpc when not in elements mode
2023-10-18 11:51:06 -04:00