4aad8c1a14 script: cache transaction weight per-transaction (Andrew Poelstra)
Pull request description:
This is an O(N) operation so we want to make sure that we're not recomputing
it every time we hit the INSPECTTXWEIGHT opcode.
ACKs for top commit:
sanket1729:
Cr ACK 4aad8c1a14
Tree-SHA512: c6bf6db748ede3f29c1294363a9415b54252bec784cfe270d8db1e7d845dc680fc9af37ad3ceaa33f9439c1dcdfde683a15fa3086fe79f50fdc487bfbf602921
c0936ba2a3 test: fix surjectionproof overflow functional test for new RPC changes (Andrew Poelstra)
Pull request description:
This fixes an undetected merge conflict between #1014 and #900.
ACKs for top commit:
gwillen:
utACK c0936ba
psgreco:
UTACK c0936ba2a3
Tree-SHA512: a39d98db91d92f7e0e739e06d7a1bb13814d2bc7751cb6105a759af04ed0d61d206d1650f5e4e087feaeafcf1c482587b05b66d9cc497bc594a45df6bf23c07a
f7e1fb6708 blind: add functional test that attempting to spend more than 256 inputs fails "gracefully" (Andrew Poelstra)
ba538cbe2a blind.cpp: refuse to create surjection proofs that would trigger an assertation failure (Andrew Poelstra)
Pull request description:
There isn't really any reasonable way to recover from this situation but we can at least gracefully fail instead of triggering an assertation failure.
Fixes#979Fixes#880
ACKs for top commit:
gwillen:
utACK f7e1fb6.
Tree-SHA512: 6f95732964503e5ac6fc85fd6b45958f1b1719b1f9ecf3d6295d571489112837cdb4429a02a389da82e8d5fcd55527241cba50bceff00bb4facd8be037c7dcab
31c232a39b clarify that secp scalars are unsigned big endian (sanket1729)
f11fe0ad9c Update spec for rolling sha256 opcodes (sanket1729)
3055e85042 Rename taptweak (sanket1729)
a651f7ed4b More updates to spec (sanket1729)
147b9b7f6a Remove binary operations for 64 bits (sanket1729)
95f82f5080 Update spec for inputoutpoint (sanket1729)
6c4971dfbd Confirm overflow behaviour of scalars (sanket1729)
1d778dd632 Remove shifts, update output spk introspection (sanket1729)
49978abf5a Renumber opcodes; minor fixups (sanket1729)
3be79d1257 Update LE32 to read only unsigned (sanket1729)
d3cff9eea4 Update overflow behavior (sanket1729)
50733b8826 Flatten out introspection opcodes (sanket1729)
4bce8af953 Remove MULTISCALAREXPVERIFY. Sigops budget calculation is mentioned in respective opcode sections (sanket1729)
5ae2945da7 [WIP] updated spec for tapscript opcodes (sanket1729)
Pull request description:
This is an updating document for the latest specification of tapscript opcodes. This will be updated in parallel while the implementation is in progress
ACKs for top commit:
apoelstra:
ACK 31c232a39b
Tree-SHA512: 6862c9c09e340674d30d53cddc9a6adbcb67edcc00871c934a2b775f64537382ae4679a03b9a71e2a63aba0f66f181d1355051f452f7ef1a9017601fa9190127
That results in a much safer interface (making the tweak commit
to the key implicitly using a fixed tag means it can't be used for
unrelated tweaking).
https://github.com/bitcoin/bitcoin/pull/22051 (5/9)
We actually preserve the "unrelated tweaking" method so we can
use it in OP_TWEAKVERIFY
This commit addresses #20809.
We add an additional 'error' property in the result of 'validateaddress' in case the address is not valid that gives a short description of why the address in invalid. We also change the error message returned by 'getaddressinfo' in case the address is invalid.
https://github.com/bitcoin/bitcoin/pull/20832 (1/1)
ELEMENTS: Merge conflicts resolved based on d6c85c5620 (from 22.0 rebase)
2612017031 Address post merge feedback for Taphash (sanket1729)
Pull request description:
Addressing the review by @roconnor-blockstream on #1002 .
ACKs for top commit:
apoelstra:
ACK 2612017031
Tree-SHA512: 62121ba33cf1fccda75cd2402c22799ccee437ba64575e6f5561b0aa1c571b6d94f3981fb4c1260a8c2848a26e1790d770364ade2af3edb5a98be29c23d6e0a2
