When we decode or sign a PSBT given to us via RPC, first check that, if
it contains blinded output values, they verifiably match the unblinded
output values contained in the original transaction proposal. Otherwise fail.
d8af6598f Use gitian infrastructure to install librsvg2-2 (in lieu of hard-coded wget) (Jeff Frontz)
Pull request description:
This removes the hardcoded `wget` of libsrvg2-2 package from the internal gitian `script` and instead uses the `packages` capability (the `wget`-based implementation causes unintended dependencies on internet infrastructure; it is also brittle).
Tree-SHA512: 35fb6914e316f40a98e7ca20269a64bbb372423099df0d8faf91217c016d7ea2bcfa3854498141ae1f2c02ccac41b36a7e4f4fd02227e6e41a2eb5710796c37d
3386cae45 Make error messages distinct at each failure location. (Glenn Willen)
a4c279e29 Fix logic issues with randomization of outputs in [re]issueasset_base; minor refactoring. (Glenn Willen)
Pull request description:
Fixes#885. This is a more comprehensive alternative to #887.
One note: The existing code claimed to assume (and mostly did assume) that fee outputs always go at the end. Other code does not necessarily appear to assume that. I have added explicit checks for it, so it should be obvious enough if it causes problems in practice (and with a small fix, the integration tests do pass.) If we're concerned about whether the assumption is valid, I'm willing to relax the assumption (but then the old code makes even less sense.)
@stevenroose for review? (@jhfrontz also, since #887 was yours so maybe you have opinions.)
Tree-SHA512: 512407922a574f5fcf4a7508f32b0eb9270f93acc2de561ca313bde5d737065e4af743089fcb41943e8f49700c737c84a1658ec1063847c1a086065a01a2ddfb
011cea3e8 build: Fix search for brew-installed BDB 4 on OS X (Glenn Willen)
Pull request description:
Backport of my upstream fix https://github.com/bitcoin/bitcoin/pull/19356 .
Net effect is to change the include order slightly for macOS homebrew users with BDB 4.8 installed privately (not linked into system directories) -- our configure scripts will prefer BDB 4.8 if they find it there, even if it is not system default. This fixes a build break that would occur in this situation when some _other_ BDB _is_ installed in system directories. The previous search order would use headers from system directories, but libs from 4.8, causing a crash.
----
On OS X, when searching Homebrew keg-only packages for BDB 4.8, if we find it,
use BDB_CPPFLAGS and BDB_LIBS instead of CFLAGS and LIBS for the result. This
is (1) more correct, and (2) necessary in order to give this location
priority over other directories in the include search path, which may include
system include directories with other versions of BDB.
Tree-SHA512: ee5425400f8ee9c69268ce9d938c60cc7935e4686f718d6d7ec64aea77383934fd0d8f1553b04eec0aa3ed9ace69cfbd5ba7ee39563b4d9520c913aa3cc259df
On OS X, when searching Homebrew keg-only packages for BDB 4.8, if we find it,
use BDB_CPPFLAGS and BDB_LIBS instead of CFLAGS and LIBS for the result. This
is (1) more correct, and (2) necessary in order to give this location
priority over other directories in the include search path, which may include
system include directories with other versions of BDB.
a9f51d724 Update build docs for FreeBSD 12.1-RELEASE (wiz)
Pull request description:
Fixes#814 by setting basic build configuration:
* Use gmake instead of make
* Use clang instead of gcc
* Add /usr/local to include path
Tree-SHA512: e65ac047c3281eda67d0514d038523d85168f8da3dd0fa3d194eafe6ccea6d9fbb01e8cbd96a4428612de10df71b118ed4be29122cde80c266cad12a76b6d595
425691623 Add test to make sure issuances to wrong addresses fail (Steven Roose)
1b8bf85d8 Make issuance fail for invalid addresses (Steven Roose)
Pull request description:
Fixes https://github.com/ElementsProject/elements/issues/853.
Tree-SHA512: fd4e8dbede4c08a52c081abd57d2609ee7057b952b6de60ddc296574400f7488dd5ec33ac4874211cd029b8902a64741e52f1ed40b4a1e565274bacfd67e5075
98e42a0db Fix HasValidFee potential overflow (Steven Roose)
Pull request description:
Dmitry pointed out this potential overflow. They can't really happen
because of the `CheckTransaction` check on explicit amounts that
happens earlier in the verification chain. But it's a good idea to
add the check here as well so that a potential relaxing of other rules
cannot accidentally introduce an overflow risk.
Tree-SHA512: 0c6abb7719d4cf84596da5cb31e700bee53d26d6ffc6da0ba8f1300b3357ca3d29fb46e2754d182e64cb5794fd58fa1efed5ebf9c1bd58d08e2fb7841725ca66
536939e5e init: update the elementsd.service file with some additions found in last Bitcoin Core version, ie PermissionsStartONly=true, ExecStartPre=/bin/chgrp elements /etc/elements, TimeoutStopSec=600 and ProtectHome=true (Sosthene00)
c884cadc7 init: renamed bitcoind.service to elementsd.service (Sosthene00)
Pull request description:
(This is a cleaned up version of #849 )
I set up a Bitcoin Core and an Elements node on a Ubuntu machine for testing, and noticed that there was no elementsd.service file available in Elements repo as I expected, but a bitcoind.service file that seems to be an outdated version of the file in the Bitcoin Core repository.
Since I needed to create a systemd service, I modified the most recent version of bitcoind.service file for elementsd as it seems fit to me.
Besides replacing all occurrences of bitcoin and bitcoind, I also moved the debug.log file to another dir and the path to the bin is also different (/usr/local/bin/elementsd). This might be too specific to my project though.
I suggest to add it to the Elements repository along the existing files, as maybe some people might find it useful.
I'm pretty rookie with systemd too, I tried to stick to the example and recommandation in the Bitcoin Core repository, but I'd be glad if someone had suggestions to improve this.
Tree-SHA512: 8b07203b5e7c44d46fe5a9e6ba399ee44b89e037d000b51a0ecd473c4e924f5f8305369a8c7718d9d058a6d1a299d52fa1a397a264cd4c4e5733e286567caad2
45fb11978 Changing Elements Icon to just the graphic without text, fixing issue with gitian builds on icon, removing color change based on testnet for Elements, and compatible svg with build script. (Allen Piscitello)
Pull request description:
The icon used previously had text in it, that made it unreadable on most screens. This has been replaced with just the graphic part of the icon.
In addition, Gitian builds had an issue where the icon was not formatted correctly. Changes were made to the icon to be more similar of an svg format than the previous one that worked.
Lastly, the changing of the icon color based on testnet was removed since Elements has many networks and it would not make sense to change for each.
Tree-SHA512: 6dfd93362d37cc6bf6bcd005781ee35750bd1348d322e6b9605ef4f286496254971e493befd54aaa45b93143013afad04bf60999ea61e213dc27d8b8f2ede120
Dmitry pointed out this potential overflow. They can't really happen
because of the `CheckTransaction` check on explicit amounts that
happens earlier in the verification chain. But it's a good idea to
add the check here as well so that a potential relaxing of other rules
cannot accidentally introduce an overflow risk.
607cfc3df Remove another mention of Liquid-Qt (Steven Roose)
Pull request description:
This should be the last mention of `#if LIQUID` and `Liquid-Qt` that my grep can find.
Tree-SHA512: 75c3675c075787de076fbb3f191b779e9db4afee872aaef229f03eb419ec1fdc0393b41728cf8e3baf5730271f2e76b0fab9000c37a4932bbc439cd7725849ec
9f10f78d2 Change the logo file from Liquid to Elements (Steven Roose)
Pull request description:
Tree-SHA512: f3e50dc0272fbe1bed902fb3c653ff109d146d78efb3ead1c032acdbea73b9435356ce04604b0d98a00b72293d4720a064828b556a552ced45ad3a07272309aa
5e3019570 Add parameter for chain name in initial download string (Philippe McLean)
f5aa08f53 Replace some Bitcoin mentions with Elements (Steven Roose)
Pull request description:
Solves https://github.com/ElementsProject/elements/issues/667.
Tree-SHA512: fdee9fe38cfef9946bd2672f6f13317f5ebc6874b16bb87027e39130fe8d46e7cd04d6cb01ea1d1e203188be93ecdf8b027a81344f033a15e40c586cd485d140
34ef25072 Move GetNumIssuances to issuance.cpp (Steven Roose)
f9925853c Remove the GetNumIssuances in the assertion (Steven Roose)
Pull request description:
This is in response to @dgpv 's https://github.com/ElementsProject/elements/issues/842.
I'm not 100% confident this is correct, but it seems so. It also passed all tests on my machine.
Tree-SHA512: 65206ac5e464a222b379043ca7943e9764382d25db6afc3ade89a1c637404c9f902d9ac21e1671722f1a29592a135b69c2c9164932958929d6a6588a12a14ac2
8aab8a24c Optimize size estimation in FundTransaction (Steven Roose)
6939a7248 Support fee estimation for fees lower than 1 sat/byte (Steven Roose)
Pull request description:
The fee estimation buckets also have a minimum of 1000 sat/kB.
This PR lowers that limit and also discards old estimates files.
Tree-SHA512: a097915b4f8f31cb2185afbbf6a247816945f1bfe01469260a1f4c90fed36eea2b7ec63b85143c35e335f9fc6877d7392b8969fc2ab1811c27e67bc94b4d6133
edfa40eb6 Remove the min(max( construction for the ct_exponent argument (Steven Roose)
Pull request description:
As per @dgpv's suggestion here: https://github.com/ElementsProject/elements/pull/834#discussion_r396333202
@dgpv could you review?
Tree-SHA512: 6c91a0a86a593f22ff42fb617aa96aeb97e2e5225e2b5b6980aa470f45ee613dab53de49dbbae20aecf7a4bf21cc005839be770917d55cfb2c9afd821c2d0231
fd4dcf9c7 Improve coinbase and issuance tx testing for txindex (Steven Roose)
ac9966f65 Index the genesis block with txindex (Steven Roose)
Pull request description:
This reverts commit ed12d5df1b in which Core removed the genesis txs from the txindex.
Since they are spendable in Elements (as opposed to Core), they should be added to the index as well.
Tree-SHA512: a9067032f80a78f5393437d287022756816a4baa6bfb8fc382d04dc7831a536dc68959a039636aa4b1bb268b2b849e67a0d4ca59abe835c2834ac358f8175e9e
We removed the similar construction for ct_bits in an earlier commit.
The construction is to keep the value between -1 and 18. This kind of
means that a user that inputs a value outside that range will not get an
error, but will use the value on the edge of the range instead.
It's probably better to return an error (generated by secp256k1) in the
case of invalid input.
c780a5186 nit: Comment in blind_tests.cpp was wrong (Steven Roose)
e87b39040 Some readability improvements in blind.cpp (Steven Roose)
26e5490e8 Switch default bits of hiding to 52 (Gregory Sanders)
Pull request description:
Replaces https://github.com/ElementsProject/elements/pull/793 and is basically that MR but rebased. (I can't rebase on Greg's branch.)
Tree-SHA512: 2c321d7f50d1c16f73e9eafc905b3a21a1aa7a4c44a2da39b1adda7f7c12d74c0f49379c7995afe605b5c07410e8e2f0e3468826e4d246c91c8a1c2c8a03e5dc
bfb77ad44 Reduce mintxfee to 0.1 sat/vbyte and fallback fee to 2 sat/vb (Steven Roose)
Pull request description:
This follows the reduction of the `minrelaytxfee` in the previous release to the same value. Using this value, the wallet will be able to make transactions with a 0.1 sat/vbyte fee by default.
Tree-SHA512: a8a977e48abdb103f4514cfe92014be4e7d720d7d1626c4648d021f0cdad55ff839d0bb146158186676f4d72515b7b6112140b041de2d86f765c8f443e567560
