a189d636184b1c28fa4a325b56c1fab8f44527b1 add release note for datacarriersize default change (Greg Sanders)
a141e1bf501bb2660f3a62083a65678250085e56 Add more OP_RETURN mempool acceptance functional tests (Peter Todd)
0b4048c73385166144d0b3e76beb9a2ac4cc1eca datacarrier: deprecate startup arguments for future removal (Greg Sanders)
63091b79e70b8e230a122fa6fb3dac91c80638e7 test: remove unnecessary -datacarriersize args from tests (Greg Sanders)
9f36962b07eff2369577a17c8adeaa0433697e1c policy: uncap datacarrier by default (Greg Sanders)
Pull request description:
Retains the `-datacarrier*` args, marks them as deprecated, and does not require another startup argument for multiple OP_RETURN outputs.
If a user has set `-datacarriersize` the value is "budgeted" across all seen OP_RETURN output scriptPubKeys. In other words the total script bytes stays the same, but can be spread across any number of outputs. This is done to not introduce an additional argument to support multiple outputs.
I do not advise people use the option with custom arguments and it is marked as deprecated to not mislead as a promise to offer it forever. The argument itself can be removed in some future release to clean up the code and minimize footguns for users.
Tree-SHA512: 3da2f1ef2f50884d4da7e50df2121bf175cb826edaa14ba7c3068a6d5b2a70beb426edc55d50338ee1d9686b9f74fdf9e10d30fb26a023a718dd82fa1e77b038
(cherry picked from commit 983cf90c00)
0ecea5ceb8 Update manpages (Pablo Greco)
1d767802c6 Bump version to 23.3.3 final (Pablo Greco)
6e079ea838 updated documentation for elements chain types (Tom Trevethan)
56b2572cef enabled > 21m for issued assets in GUI amount field (Tom Trevethan)
Pull request description:
Updates master to 8db19e90c8, which fixes a GUI issue after ELIP 203 and a small documentation fix.
Also and bumps version/manpages for release
ACKs for top commit:
tomt1664:
Tested ACK 0ecea5ceb8
delta1:
ACK 0ecea5ceb8; tested locally
Tree-SHA512: 5493957cae60b0dd11f28d8ff560f25bff6a27b88f19af98ddd8c7c0b634d784daea459ff487d09a54ae94663633e20ee9d5fd1e20eb205184e448616dd81428
72e4e1cf21 use break-system-packages for pip (Tom Trevethan)
Pull request description:
Add --break-system-packages to PIP_PACKAGES in macos CI, to allow for macos-runner images to update homebrew packages.
ACKs for top commit:
delta1:
ACK 72e4e1cf21; fixes macos ci task
Tree-SHA512: 27dc712309940afde1d21c9f465c244eb49d0d1bb8bbf2faba3bf64d00a63f975943825019cd45f1c32e462ab6b5d74490cb0876aeb5e6397da20e668fff2823
6515f58351 change test order in feature_discount_ct to fix intermittent failure (Tom Trevethan)
Pull request description:
Prevents blinded output being selected intermittently and resulting in vszie and fee assertions failing.
ACKs for top commit:
delta1:
ACK 6515f58351; fixes discount_ct test flakiness
Tree-SHA512: 32d8c64011125e5531dd19ce84dbe39b2d4496a02c5bf5ece0cbc2f0c2bf6660816d6d61593fe32a615dd96a8632d94cba6bc09e792ffa6ea57fbdc4f52424da
6e079ea838 updated documentation for elements chain types (Tom Trevethan)
Pull request description:
Change config and RPC documentation for Elements chain type options.
ACKs for top commit:
delta1:
ACK 6e079ea838; just an RPC documentation update
Tree-SHA512: 4128669f5dda2700562706f7d341f37fecbd8e1c5deee2aed56869b20995f474e51af86d6228246c06a2c90fda1251066a7f86bb2fa55732ab46e58deb55b476
56b2572cef enabled > 21m for issued assets in GUI amount field (Tom Trevethan)
Pull request description:
Only pegged asset limited to `MAX_MONEY` for the GUI amount field. Issued assets can have amounts displayed > MAX_MONEY.
ACKs for top commit:
delta1:
ACK 56b2572cef; ran tests locally but have not tested the GUI
Tree-SHA512: 9a04ed9016b420a32bbaa98b80712725691619c5ca854a6b6d0b07e5a91c9ff818e6367a93f6f5c54ae8e0e9e799b6367042c0f823b6c066c5e25a9624b8adc2
56eb713150 Log status of ELIP 203 (Pablo Greco)
d8052363f3 liquidv1: allow enabling -acceptunlimitedissuances (Pablo Greco)
Pull request description:
Preparation for the activation of [ELIP 203](https://github.com/ElementsProject/ELIPs/blob/main/elip-0203.mediawiki), we need to move from a hardcoded false to an optionin liquidv1
ACKs for top commit:
tomt1664:
Tested ACK 56eb713150
delta1:
ACK 56eb713150; tested locally, changes allow acceptunlimitedissuances to be configurable on liquidv1 chain
Tree-SHA512: 1671634af6f3dfeaf48c9c6f9aa8598fed1eddc6a279b7bbbfd6d7d7062b89d85a60ec561560308d55ef4e80790db760b8dd20c19167db248d13d41570893314
bd59321098 contrib: upstream my merge-prs.sh changes (Byron Hambly)
Pull request description:
Cleaned up and lightly documented my updates to the `merge-prs.sh` script. Still need to write a usage doc.
ACKs for top commit:
delta1:
ACK bd59321098; this script is currently being used for merging
Tree-SHA512: 16ca19af21441424d471263ba1bf817856bf3c7d5801a2ce55e83b22cacf62cb92c3bcc84c9f485d173a15b0dda4e0b8b1ec99b3c9cef4835b16aaaafe461d1f
43f9542cad Bump version to 23.3.2 final (Pablo Greco)
Pull request description:
Only version bump changes since rc2
ACKs for top commit:
tomt1664:
ACK 43f9542cad
delta1:
ACK 43f9542cad; only changes RC version for release
Tree-SHA512: a3424d432a8adefa3e4d31d28781e20e8d7fb01ad10286455a722d138621a3d21fc608eb6300085f26f71fbd999866a5b5e062fc1f0e329b41e8cc6ffeb11e8b
73db0cf72b Bump version to 23.3.2-rc2 (Pablo Greco)
6544256fcb Update manpages (Pablo Greco)
4c79d5a572 fix: use liquidnetwork or liquidtestnet for uri in elements mode (Byron Hambly)
8f28d82f57 docs: add github-merge.py process for merging PRs (Byron Hambly)
6c7788adf3 Avoid Simplicity header dependency propogation (Russell O'Connor)
Pull request description:
Updates master to 6bb916a57f which includes fixes for simplicity header dependency and qr code generation for QT
ACKs for top commit:
delta1:
ACK 73db0cf72b; diff looks as expected, tested locally successfully
Tree-SHA512: d23312a81033b759466f9bc2d8bbb0bfcdd5bfd0a1d80b101e8461e62a151841910310e82ed8a1ba4ed6bb8a363f53dc2e8e5674c27b9ebafe02169a88b08ed9
4c79d5a572 fix: use liquidnetwork or liquidtestnet for uri in elements mode (Byron Hambly)
Pull request description:
fixes#1529
ACKs for top commit:
tomt1664:
ACK 4c79d5a572
psgreco:
ACK 4c79d5a572
Tree-SHA512: 00862c3851bd1663ed17dfde9ef155840d4d735b3e61ad890155dccdc9cb7fb4fc086021a9ae1a1030ff8e809dc6ffb46a5aeed35d3c5625b44f65ec6cdae421
8f28d82f57 docs: add github-merge.py process for merging PRs (Byron Hambly)
Pull request description:
Documents how to merge PRs using the github-merge.py script from Bitcoin maintainer tools repo.
ACKs for top commit:
psgreco:
ACK 8f28d82f57
Tree-SHA512: b263dd7715fa71926ceeae053e453a4a19b64fa89c88cb0f84fa15bafbcc1051f35ca4f28a05f41dfc8d3af1d1de9eb2bb6cd832867cf7d7d7772a3c7267777b
6c7788adf3 Avoid Simplicity header dependency propogation (Russell O'Connor)
Pull request description:
The problem with including <simplicity/elements/env.h> in interpreter.h is that now everyone who needs to include interpreter.h also needs access to Simplicity's header files too.
This commit breaks that dependency chain by using forward declarations. It will pay signifigant dividends when elements switches to CMake.
ACKs for top commit:
delta1:
ACK 6c7788a; built and tested locally
apoelstra:
ACK 6c7788adf3; successfully ran local tests
Tree-SHA512: 78d043a094f0a2bb51e0f103313ae568b42ec2852d8fe9a3fbbcad9c0fbf6829ef1347f83bfd361547ec165c01965e7342188a38d8faacfcf90ef70c5b7001f6