Andrew Poelstra
381cd9cd01
Merge 4ee8a58ce7 into merged_master (Bitcoin PR #17373 )
...
This PR associates OutputType::BECH32 to PAK online keys, where before we
were able to directly access keys from the keypool. In a future refactoring
we should give PAK keys their own output type (and own scriptpubkey manager)
so that the wallet won't accept payments "to the PAK key".
Also changes `ReserveDestination::SetBlindingPubKey` to use a visitor pattern
to apply a blinding pubkey to a destination directly, rather than using the
old hacky method of regenerating the destination by pulling its key (which
is no longer contained in the class) out and giving it to a new constructor.
This was a long-overdue refactoring and the minimal-diff way to get the code
compiling (and it's not bad, maybe 10LOC to add a new visitor class) but
nonetheless I apologize for sticking this into a merge commit.
2020-11-14 16:51:54 +00:00
Andrew Poelstra
32095fb7b7
Merge da1af855f9 into merged_master (Bitcoin PR #17275 )
2020-11-14 16:51:54 +00:00
Andrew Poelstra
c59a715d27
Merge cb11324a63 into merged_master (Bitcoin PR #17051 )
2020-11-14 16:51:53 +00:00
Andrew Poelstra
9c6556d44a
Merge c7c9c44278 into merged_master (Bitcoin PR #17663 )
2020-11-14 16:51:53 +00:00
Andrew Poelstra
719c7784db
Merge cf43f3f0a8 into merged_master (Bitcoin PR #17674 )
2020-11-14 16:51:53 +00:00
Andrew Poelstra
09818751b1
Merge 5d0b7f9e3d into merged_master (Bitcoin PR #17670 )
2020-11-14 16:51:53 +00:00
Andrew Poelstra
96822eee94
Merge 910a4301b1 into merged_master (Bitcoin PR #17522 )
2020-11-14 16:51:53 +00:00
Andrew Poelstra
4b5f023c60
Merge 6fff333c9f into merged_master (Bitcoin PR #17507 )
2020-11-14 16:51:53 +00:00
Andrew Poelstra
0c0b496469
Merge 5aee0e2163 into merged_master (Bitcoin PR #17650 )
2020-11-14 16:51:53 +00:00
Andrew Poelstra
c7bf5baf96
Merge 526e802d69 into merged_master (Elements PR #755 )
...
This Elements PR includes components of Core PR #17211 , which since the
refactors to use effective value landed, no longer provides the right
error message when a user provides an unowned input from a wallet tx.
See https://github.com/bitcoin/bitcoin/pull/17211#pullrequestreview-528389011
This breaks a functional test which was included in this PR, but which
conveniently has been changed in the current version of the Core PR. I
fixed the behavior (commented, in SelectCoins) rather than updating the
test to the most recent version.
2020-11-14 16:51:53 +00:00
Andrew Poelstra
5a48ca16e3
Merge fee01bb053 into merged_master (Bitcoin PR #17517 )
2020-11-14 16:51:52 +00:00
Andrew Poelstra
b2a52fdd5f
Merge 41919631d5 into merged_master (Bitcoin PR #17573 )
2020-11-14 16:51:52 +00:00
Andrew Poelstra
932da45ee4
Merge dcbe024f5e into merged_master (Bitcoin PR #17648 )
2020-11-14 16:51:52 +00:00
Andrew Poelstra
e536f17cb2
Merge bce44089db into merged_master (Bitcoin PR #17547 )
2020-11-14 16:51:52 +00:00
Andrew Poelstra
4522262447
Merge e354db7877 into merged_master (Bitcoin PR #17637 )
2020-11-14 16:51:52 +00:00
Andrew Poelstra
1b4ef5d628
Merge 54b12e425b into merged_master (Bitcoin PR #17555 )
2020-11-14 16:51:52 +00:00
Andrew Poelstra
fd78a12518
Merge 2949ea924f into merged_master (Elements PR #751 )
2020-11-14 16:51:52 +00:00
Andrew Poelstra
255c478c5a
Merge 1fdaa04ceb into merged_master (Bitcoin PR #17641 )
2020-11-14 16:51:52 +00:00
Andrew Poelstra
df14d3c511
Merge 1705f1949a into merged_master (Bitcoin PR #17549 )
2020-11-14 16:51:51 +00:00
Andrew Poelstra
c3c860b38a
Merge 69ca6cdd66 into merged_master (Bitcoin PR #17599 )
2020-11-14 16:51:51 +00:00
Andrew Poelstra
05bbc1a822
Merge 2b6575d989 into merged_master (Bitcoin PR #17643 )
2020-11-14 16:51:51 +00:00
Andrew Poelstra
f5606e5e2b
Merge 35eda631ed into merged_master (Bitcoin PR #17634 )
2020-11-14 16:51:51 +00:00
Andrew Poelstra
27de4bdecf
Merge 19698ac6bc into merged_master (Bitcoin PR #17568 )
2020-11-14 16:51:51 +00:00
Andrew Poelstra
5ae9f8e2dc
Merge 2ecb7e1556 into merged_master (Bitcoin PR #17521 )
2020-11-14 16:51:51 +00:00
Andrew Poelstra
02fbc40c11
Merge abb30de63f into merged_master (Bitcoin PR #17587 )
2020-11-14 16:51:51 +00:00
Andrew Poelstra
45e9b96648
Merge 114e89e596 into merged_master (Bitcoin PR #17624 )
2020-11-14 16:51:51 +00:00
Andrew Poelstra
84702646f3
Merge 23cecd6cd5 into merged_master (Bitcoin PR #17604 )
2020-11-14 16:51:51 +00:00
Andrew Poelstra
b4d7d9d503
Merge 1f59885d27 into merged_master (Bitcoin PR #17361 )
2020-11-14 16:51:50 +00:00
Andrew Poelstra
6a5fc1dd58
Merge d8a66626d6 into merged_master (Bitcoin PR #17283 )
2020-11-14 16:51:50 +00:00
Andrew Poelstra
1b46c58527
Merge 4fb82e916b into merged_master (Bitcoin PR #17567 )
2020-11-14 16:51:50 +00:00
Andrew Poelstra
cc2097087c
Merge dd1478870c into merged_master (Elements PR #791 )
2020-11-14 16:51:50 +00:00
Andrew Poelstra
16744f7ec2
Merge f2ab130961 into merged_master (Bitcoin PR #17606 )
2020-11-14 16:51:50 +00:00
Andrew Poelstra
569c46ca22
Merge 6d00035cae into merged_master (Elements PR #778 )
2020-11-14 16:51:50 +00:00
Andrew Poelstra
28623acd36
Merge 45f04d9753 into merged_master (Elements PR #784 )
2020-11-14 16:51:50 +00:00
Andrew Poelstra
3b10648977
Merge 4d5bd19fa0 into merged_master (Elements PR #785 )
...
Manually applied this one
2020-11-14 16:51:50 +00:00
Andrew Poelstra
d133c5b353
Merge 4895540b2f into merged_master (Elements PR #788 )
2020-11-14 16:51:49 +00:00
Andrew Poelstra
1df4f4164c
Merge 0ee914ba9e into merged_master (Bitcoin PR #17584 )
2020-11-14 16:51:49 +00:00
Andrew Poelstra
0e603ca0d7
Merge 2c1c43754b into merged_master (Bitcoin PR #17591 )
2020-11-14 16:51:49 +00:00
Andrew Poelstra
18b511b048
Merge 12230529e3 into merged_master (Bitcoin PR #17596 )
2020-11-14 16:51:49 +00:00
Andrew Poelstra
a6da77f108
Merge 89a1f7a250 into merged_master (Bitcoin PR #17592 )
2020-11-14 16:51:49 +00:00
Andrew Poelstra
e281d39855
Merge e6f167bfdf into merged_master (Bitcoin PR #17569 )
2020-11-14 16:51:49 +00:00
Andrew Poelstra
434dfec482
Merge 7463181798 into merged_master (Bitcoin PR #17538 )
2020-11-14 16:51:49 +00:00
Andrew Poelstra
0e349f28b2
Merge 239d199667 into merged_master (Bitcoin PR #17574 )
2020-11-14 16:51:49 +00:00
Andrew Poelstra
60735c16e6
Merge 2eeacdfe44 into merged_master (Bitcoin PR #17527 )
2020-11-14 16:51:48 +00:00
Andrew Poelstra
7a8b5877f2
Merge 9cbd87d8ee into merged_master (Bitcoin PR #17518 )
2020-11-14 16:51:48 +00:00
Andrew Poelstra
026518a36f
Merge 2c98e2024d into merged_master (Bitcoin PR #17571 )
2020-11-14 16:51:48 +00:00
Andrew Poelstra
d9dcd52ea5
Merge 33c103e2fe into merged_master (Bitcoin PR #17539 )
2020-11-14 16:51:48 +00:00
Andrew Poelstra
dbec7759bf
Merge 0b79caf658 into merged_master (Bitcoin PR #17447 )
2020-11-14 16:51:48 +00:00
Andrew Poelstra
6da00c1830
Merge 4effd67bf4 into merged_master (Bitcoin PR #17387 )
2020-11-14 16:51:48 +00:00
Andrew Poelstra
810568e0fa
Merge a6f5b6f47d into merged_master (Bitcoin PR #17550 )
2020-11-14 16:51:48 +00:00
