d710cb588 rawissueasset: don't make explicit 0-value which gets blinded later (Gregory Sanders)
Pull request description:
This matches the behavior of `issueasset`.
Resolves https://github.com/ElementsProject/elements/issues/643
Tree-SHA512: 655d84a45c686f31867eccaa423279bb81481b9321eb061a85af78f12a6652899ddd1c25357e36f1257e61af6c6d9b5b007d1615c18d7a4a826844102649fe45
fcbb45729 Update msft build version too (Gregory Sanders)
10177bece Fix version number to post-0.18 master (Gregory Sanders)
Pull request description:
Tree-SHA512: 8c114c9ba43e7c370b40771458f7b8fb7350a6ea88a2999f457b9521b1a24a93f479d5576a276f55657843270d80b769143fd13e237a083dd9da855fa0a2fa7b
7737d29b7 have peg-in witness creation strip witness for space savings (Gregory Sanders)
Pull request description:
Cheaper peg-in witness for those with segwit transactions in Bitcoin.
resolves https://github.com/ElementsProject/elements/issues/628
Tree-SHA512: defc4f38b2456c6f45cf2ebd48a3d5f9e39544bd048606257ef6cf90623595c159f61e3df56845fb7a37a44b5019614e692663978a9664dd9b4d01b77bedeb86
1ae68dc0b Fix qt usages of txout-based GetCredit (Gregory Sanders)
c17af5d2d Delete unused non-CWalletTx GetCredit (Gregory Sanders)
Pull request description:
First commit is dead code that we don't want to accidentally try to use.
Second fixes actually-used code in QT for looking at transaction details.
resolves https://github.com/ElementsProject/elements/issues/630
Tree-SHA512: 181fead8c385de6d91d637607619014bb1668fa2a6c3c81fb6c575750582f3204e4f94fcf28e68f42c2c02a97e42a818ac8c3add5a9700e263f5620718973bcc
5de1e3f9d Disallow issuance calls in bitcoin mode (Gregory Sanders)
Pull request description:
Enough people are running `-regtest` and getting confused as to why they cannot issue assets to make some checks worth it even though we don't intend people to run bitcoin mode at all.
Tree-SHA512: cb595839d01a000b5a48be4ae5c7084a687bb5c252be8f812f56455082ed78e66cb15313ab15934941cd403040ae253d8270faf6e85995d5caa0d1a66ccd3c6c
770d0f60b travis: Properly cache and error on timeout (MarcoFalke)
1630bac38 travis: Switch to ubuntu keyserver to avoid timeouts (MarcoFalke)
3c0f3d7bc Disable feature_notifications functional test (Steven Roose)
20f3b1df1 Fix more Travis builds (Steven Roose)
ee900196f Fixup after merge with master (Steven Roose)
45c06d29d Fix Travis builds (Steven Roose)
738a3c91a MERGE-FIX: Fix bitcoin-tx duplicate -h argument (Steven Roose)
de81c0d97 MERGE-FIX: Fix linter (mostly RPC help) (Steven Roose)
efe4e8ff0 MERGE-FIX: Fix functional tests (Steven Roose)
473e1e9ca MERGE-FIX: Fix compatibility functional tests (Steven Roose)
420e38ae8 MERGE-FIX: Update compatibility functional tests (Steven Roose)
3a01200e3 MERGE-FIX: Fix unit tests (Steven Roose)
a39bad4a9 MERGE-FIX: manpage fixes (Steven Roose)
52f6f6905 WIP: Fix compilation after merge (Steven Roose)
de5dc0325 MERGE-FIX: Rebrand bitcoin-wallet to elements-wallet (Steven Roose)
39c2906dc MERGE-FIX: Update src/primitives/bitcoin/ (Steven Roose)
519b0bc5d Make last disconnected block BLOCK_FAILED_VALID, even when aborted (Pieter Wuille)
8d220417c Optimization: don't add txn back to mempool after 10 invalidates (Pieter Wuille)
9ce9c3700 Prevent callback overruns in InvalidateBlock and RewindBlockIndex (Pieter Wuille)
9bb32eb57 Release cs_main during InvalidateBlock iterations (Pieter Wuille)
9b1ff5c74 Call InvalidateBlock without cs_main held (Pieter Wuille)
241b2c74a Make RewindBlockIndex interruptible (Pieter Wuille)
880ce7d46 Call RewindBlockIndex without cs_main held (Pieter Wuille)
436f7d735 Release cs_main during RewindBlockIndex operation (Pieter Wuille)
1d342875c Merge the disconnection and erasing loops in RewindBlockIndex (Pieter Wuille)
32b2696ab Move erasure of non-active blocks to a separate loop in RewindBlockIndex (Pieter Wuille)
9d6dcc52c Abstract EraseBlockData out of RewindBlockIndex (Pieter Wuille)
39e20fc54 Add missing #include. (Daniel Kraft)
fa9b60c84 Remove unused TransactionError constants (MarcoFalke)
53b310390 refactor: Drop redundant wallet reference (João Barbosa)
a786c3b30 Slight tweak to the verify-commits script directions (Douglas Roark)
7cb1a1401 Explain that unused mempool memory is added to -dbcache (Sjors Provoost)
55e05a82c Added some factors that affect the dependency list (Martin Erlandsson)
901baf2c9 doc: update FreeBSD build guide for 12.0 (fanquake)
3782075a5 Move all PID file stuff to init.cpp (Hennadii Stepanov)
561e375c7 Make PID file creating errors fatal (Hennadii Stepanov)
745a2ace1 Improve PID file removing errors logging (Hennadii Stepanov)
1a062b85f tests: remove byte.hex() to keep compatibility (Akio Nakamura)
8e4b4f683 Address test todos by removing -txindex to nodes. Originally added when updating getrawtransaction to stop searching unspent utxos. (Amiti Uttarwar)
e3e1a5631 [test] functional: set cwd of nodes to tmpdir (Sjors Provoost)
0bedcbafd Use a single wallet batch for UpgradeKeyMetadata (Jonas Schnelli)
5b76c314d doc: Add separate productivity notes document (Carl Dong)
6aaa0abc1 Remove manual byte editing in wallet_tx_clone func test (Gregory Sanders)
1435fabc1 Use RdSeed when available, and reduce RdRand load (Pieter Wuille)
a083f75ba Update assumevalid, minimumchainwork, and getchaintxstats to height 563378. (Gregory Maxwell)
3ec56bea0 appveyor: Remove unused NDEBUG removal (Chun Kuan Lee)
8a1f0a38d scripted-diff: Remove NDEBUG pre-define (Chun Kuan Lee)
d3661a3fd [Doc] add missing newline to witnessScript in listunspent help (David A. Harding)
a607c9ae4 [Doc] importmulti: add missing description of keypool option (David A. Harding)
d067e81dc msvc: add rapid check property tests (Chun Kuan Lee)
fd637be8d Add checksums to descriptors.md (Pieter Wuille)
be62903c4 Make descriptor checksums mandatory in deriveaddresses and importmulti (Pieter Wuille)
b52cb6368 Add getdescriptorinfo to compute checksum (Pieter Wuille)
3b40bff98 Descriptor checksum (Pieter Wuille)
540729ef4 Implement analyzepsbt RPC and tests (Andrew Chow)
77542cf2a Move PSBT UTXO fetching to a separate method (Andrew Chow)
cb40b3abd Figure out what is missing during signing (Andrew Chow)
08f749c91 Implement joinpsbts RPC and tests (Andrew Chow)
7344a7b99 Implement utxoupdatepsbt RPC and tests (Andrew Chow)
fab6b07c1 test: txindex: interrupt threadGroup before calling destructor (MarcoFalke)
fab15ff70 fuzz: Script validation flags (MarcoFalke)
fabcfa5f0 fuzz: Move deserialize tests to test/fuzz/deserialize.cpp (MarcoFalke)
7cee85807 Add compile time verification of assumptions we're currently making implicitly/tacitly (practicalswift)
fa178a638 [rpc] mining: Omit uninitialized currentblockweight, currentblocktx (MarcoFalke)
88a91e2c9 [build] AppVeyor: clean cache when build configuration changes (Sjors Provoost)
543ef7d62 tests: Add missing cs_main locks required when accessing pcoinsdbview, pcoinsTip or pblocktree (practicalswift)
f4b00b70e Import public keys in order (Andrew Chow)
9e1551b9c Test pubkey import to keypool (Andrew Chow)
513719c5f Add option to importmulti add an imported pubkey to the keypool (Andrew Chow)
9b81fd19a Fetch keys from keypool when private keys are disabled (Andrew Chow)
99cccb900 Add a method to add a pubkey to the keypool (Andrew Chow)
cb3511b9d Add release notes for importing key origin info change (Andrew Chow)
4c75a69f3 Test importing descriptors with key origin information (Andrew Chow)
02d6586d7 Import KeyOriginData when importing descriptors (Andrew Chow)
3d235dff5 Implement a function to add KeyOriginInfo to a wallet (Andrew Chow)
eab63bc26 Store key origin info in key metadata (Andrew Chow)
345bff601 Remove hdmasterkeyid (Andrew Chow)
bac8c676a Add a method to CWallet to write just CKeyMetadata (Andrew Chow)
e7652d3f6 Add WriteHDKeypath function and move *HDKeypath to util/bip32.{h,cpp} (Andrew Chow)
c45415f73 Refactor keymetadata writing to a separate method (Andrew Chow)
0890339fb build: prefer python3.4 even if newer versions are present on the system (Sjors Provoost)
fa535af92 fuzz: test_runner: Better error message when built with afl (MarcoFalke)
fa7ca8ef5 qa: Add test/fuzz/test_runner.py (MarcoFalke)
eeeee58bc travis: Combine --disable-bip70 into existing job (MarcoFalke)
6ca836ab3 Add release note for listunspent P2WSH change (MeshCollider)
928beae00 Add test for P2SH-P2WSH in signrawtransactionwithkey and listunspent (MeshCollider)
314784a60 Make listunspent and signrawtransaction RPCs support witnessScript (MeshCollider)
7257353b9 Select orphan transaction uniformly for eviction (Pieter Wuille)
94086fb59 gui: Add close wallet action (João Barbosa)
f77ba3431 gui: Add closeWallet to WalletController (João Barbosa)
f6122abe0 interfaces: Add remove to Wallet (João Barbosa)
fd46c4c00 Bump minimum Qt version to 5.5.1 (Sjors Provoost)
84f53154e Travis: Add test without BIP70 (but still full wallet + tests) (Luke Dashjr)
113f0004b GUI: If BIP70 is disabled, give a proper error when trying to open a payment request file (Luke Dashjr)
9975282fa GUI: If BIP70 is disabled, attempt to fall back to BIP21 parsing (Luke Dashjr)
4a43eb8cd [build] Makefile.am: add rule for src/bitcoin-wallet (Sjors Provoost)
3c6ef0393 msvc: Fix silent merge conflict between #13926 and #14372 part II (Chun Kuan Lee)
8c3fdd3a6 fixes m_assumed_blockchain_size variables values: (marcoagner)
102faad81 Factor out combine / finalize / extract PSBT helpers (Glenn Willen)
78b9893d0 Remove op== on PSBTs; check compatibility in Merge (Glenn Willen)
bd0dbe876 Switch away from exceptions in refactored tx code (Glenn Willen)
c6c3d42a7 Move PSBT definitions and code to separate files (Glenn Willen)
81cd95884 Factor BroadcastTransaction out of sendrawtransaction (Glenn Willen)
c734aaa15 Split DecodePSBT into Base64 and Raw versions (Glenn Willen)
162ffefd2 Add pf_invalid arg to std::string DecodeBase{32,64} (Glenn Willen)
a4b92e467 Log full paths for wallets (Hennadii Stepanov)
318b1f7af [wallet] Close bdb when flushing wallet. (John Newbery)
5039e4b61 Remove unnecessary const_cast (Julian Fleischer)
fa0ad4e7c RPCHelpMan: Check default values are given at compile-time (MarcoFalke)
b651ef7e1 submitheader: more directly test missing prev block header (Gregory Sanders)
1e7f74174 remove some magic mining constants in functional tests (Gregory Sanders)
8c9b8a366 Replace script name with special parameter (Hennadii Stepanov)
dc3b2ccb5 tests: Added missing tests for RPC wallet errors (Ben Carman)
1951ea434 gui: Show indeterminate progress dialog while opening walllet (João Barbosa)
8847cdaaa gui: Add OpenWalletActivity (João Barbosa)
4c8982a88 interfaces: Avoid interface instance if wallet is null (João Barbosa)
be82dea23 gui: Add thread to run background activity in WalletController (João Barbosa)
6c49a55b4 gui: Add Open Wallet menu (João Barbosa)
32a8c6abf gui: Add openWallet and getWalletsAvailableToOpen to WalletController (João Barbosa)
ab288b4e5 interfaces: Add loadWallet to Node (João Barbosa)
17abc0fd5 wallet: Factor out LoadWallet (João Barbosa)
15b31032a appveyor: Remove outdated libraries (Chun Kuan Lee)
ae892adce tests: accept unicode characters on Windows (Chun Kuan Lee)
1cdb9bb51 minor p2p_sendheaders fix of height in coinbase (Gregory Sanders)
a99999cc0 util: Add SetupHelpOptions() (MarcoFalke)
a94e47092 A few textual improvements (Martin Erlandsson)
50e647210 Move ParseConfirmTarget from rpc/mining to rpc/util (Russell Yanofsky)
1a0139cba trivial: correct parameter name in comments (andrewtoth)
30d0f7be6 rpc: Fix for segfault if combinepsbt called with empty inputs (benthecarman)
7687f7873 [wallet] Support creating a blank wallet (Andrew Chow)
dfbf117bb Move maxTxFee initialization to init.cpp (Jordan Baczuk)
5d35d4384 Update release notes through to cb35f1d3 (David A. Harding)
9ad5ca17d Release notes: integrate detached & rm backports (David A. Harding)
fae8b8bb1 qa: Add tool-prefix to functional test readme (MarcoFalke)
faf3d2272 test_runner: Remove unused --force option (MarcoFalke)
faa46475d wallet: Add lock annotation for mapAddressBook (MarcoFalke)
eea02be70 Add locking annotation for vNodes. vNodes is guarded by cs_vNodes. (practicalswift)
d855e4cac Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an invalid string is passed to DecodeSecret(...) (practicalswift)
1cff3d6cb Change in transaction pull scheduling to prevent InvBlock-related attacks (Gleb Naumenko)
b985e9c85 Add release notes for importmulti descriptor support (MeshCollider)
fbb5e935e Add test for importing via descriptor (MeshCollider)
9f48053d8 [wallet] Allow descriptor imports with importmulti (MeshCollider)
d2b381cc9 [wallet] Refactor ProcessImport() to call ProcessImportLegacy() (John Newbery)
4cac0ddd2 [wallet] Add ProcessImportLegacy() (John Newbery)
a1b25e12a [wallet] Refactor ProcessImport() (John Newbery)
595283851 [rpc] util: add deriveaddresses method (Sjors Provoost)
6440e6137 qa: Drop RPC connection if --usecli (João Barbosa)
87aa0b48a netaddress: Make IPv4 loopback comment more descriptive (Carl Dong)
6180b5f32 netaddress: Fix indentation in IsLocal (Carl Dong)
fa2a69fcb doc: Add cs_main lock annotations for mapBlockIndex (practicalswift)
fa1e28154 doc: Add missing wallet-tool manpages (MarcoFalke)
fa0fe3b8a contrib: Add missing wallet tool to gen-manpages.sh (MarcoFalke)
e8db6b804 Qt: Fix update headers-count (Jonas Schnelli)
7bb45e4b7 Qt: update header count regardless of update delay (Jonas Schnelli)
fa1db331d travis: Only exit early if compilation took longer than 30 min (MarcoFalke)
7fdb92e53 Update linearize-hashes.py (OverlordQ)
13782b8ba docs: add perf section to developer docs (James O'Beirne)
58180b5fd tests: add utility to easily profile node performance with perf (James O'Beirne)
47012391e [Docs] Small updates to getrawtransaction description (Amiti Uttarwar)
ef0b01217 tests: Make updatecoins_simulation_test deterministic (practicalswift)
364cff1ca Fix issue #9683 "gui, wallet: random abort (segmentation fault) running master/HEAD". (Chris Moore)
d3bf3b930 qa: Test .walletlock file is closed (João Barbosa)
2f8b8f479 wallet: Close wallet env lock file (João Barbosa)
8602a1e6a wallet: Close dbenv error file db.log (João Barbosa)
0164b0f5c build: Remove WINVER pre define in Makefile.leveldb.inlcude (Chun Kuan Lee)
d0522ec94 Drop defunct Windows compat fixes (Ben Woosley)
d8a299206 windows: Call SetProcessDEPPolicy directly (Chun Kuan Lee)
1bd9ffdd4 windows: Set _WIN32_WINNT to 0x0601 (Windows 7) (Chun Kuan Lee)
851380ce1 remove deprecated mentions of signrawtransaction from fundraw help (Gregory Sanders)
aebafd0ed Rename Chain getLocator -> getTipLocator (Russell Yanofsky)
2c1fbaa77 Drop redundant get_value_or (Russell Yanofsky)
84adb206f Fix ScanForWalletTransactions start_block comment (Russell Yanofsky)
2efa66b46 Document rescanblockchain returned stop_height being null (Russell Yanofsky)
db2d09323 Add suggested rescanblockchain comments (Russell Yanofsky)
a8d645c93 Update ScanForWalletTransactions result comment (Russell Yanofsky)
95a812b59 Rename ScanResult stop_block field (Russell Yanofsky)
e1b6436aa Fix build after pr 15266 merged (Hennadii Stepanov)
77777c562 log: Construct global logger on first use (MarcoFalke)
107623c26 net: Correct comparison of addr count (Carl Dong)
bad1716c6 init: Modify docs and add release note for 12255 (Carl Dong)
b0c7b54d0 init: Use systemd automatic directory creation (Carl Dong)
df8a7d340 qt: Pre-0.18 split-off translations update (Wladimir J. van der Laan)
fa6b7b9cf travis: Revert "Run extended tests once daily" (MarcoFalke)
bef8fdd6e msvc: Fix silent merge conflict between #13926 and #14372 (ken2812221)
712d35bc5 wallet: Add missing cs_db lock (João Barbosa)
fae169c95 test: Make bloom tests deterministic (MarcoFalke)
0dd6a8c12 Check m_internals in UnregisterValidationInterface (João Barbosa)
fd6d499bd gui: Fix m_node.startShutdown() order (João Barbosa)
07b9aadcf gui: Expose BitcoinGUI::unsubscribeFromCoreSignals (João Barbosa)
60e190ceb gui: Fix WalletController deletion (João Barbosa)
fac3a054c test: Fix race in p2p_invalid_messages (MarcoFalke)
11e0fd8d6 Descriptor expansions only need pubkey entries for PKH/WPKH (Pieter Wuille)
facaae4cc travis: Save cache when compilation took very long (MarcoFalke)
faee6c9ca travis: Remove unused FUNCTIONAL_TESTS_CONFIG (MarcoFalke)
119d360aa travis: Document whether functional tests are run in the job name (Ben Woosley)
64f28545e Revert "travis: Compile trusty with depends for now" (Ben Woosley)
267eac00f Prefer boost::optional#get_value_or over #value_or (Ben Woosley)
1971f5ba0 Piecewise construct to avoid invalid construction (Ben Woosley)
fa5278a41 qa: Use wallet to retrieve raw transactions (MarcoFalke)
fa2198328 qa: Style-only fixes in touched files (MarcoFalke)
e6c58d3b0 Do not import private keys to wallets with private keys disabled (Andrew Chow)
b5c5021b6 Refactor importwallet to extract data from the file and then import (Andrew Chow)
1f77f6754 tests: unify RPC argument to cli argument conversion and handle dicts and lists (Andrew Chow)
2e023419c tests: unify RPC argument to cli argument conversion and handle dicts and lists (Andrew Chow)
82dcacb82 msvc: build leveldb locally (Chun Kuan Lee)
52091066b msvc: build secp256k1 locally (Chun Kuan Lee)
3617f1173 Fix assertion in CKey::SignCompact (João Barbosa)
14bc2a17d Trivial: add doxygen-compatible comments relating to BerkeleyEnvironment (Pierre Rochard)
88b1d956f Tests: add unit tests for GetWalletEnv (Pierre Rochard)
f1f4bb734 Free BerkeleyEnvironment instances when not in use (Russell Yanofsky)
3c3e31c3a [tests] Add wallet-tool test (João Barbosa)
49d2374ac [tools] Add wallet inspection and modification tool (Jonas Schnelli)
f96dbd1bb gdb attaching to process during tests has non-sudo solution (Gregory Sanders)
2bc4c3eaf Notify the GUI that the keypool has changed to set the receive button (Andrew Chow)
14bcdbe09 Check for more than private keys disabled to show receive button (Andrew Chow)
fa3745bda qa: Add tests for invalid message headers (MarcoFalke)
e1c27da30 doc: correct logging rpc return type and example (fanquake)
f24ed6d39 Delete README_osx.md and move its contents into build-osx.md (Martin Erlandsson)
a6cd50dec Add gitian PGP key for hebasto (Hennadii Stepanov)
2d483142a Remove 'boost::optional'-related gcc warnings (Hennadii Stepanov)
fa5ce3f10 travis: Compile trusty with depends for now (MarcoFalke)
fa83999d9 travis: Compile once on trusty (MarcoFalke)
2ca632e5b test: Build fuzz targets into seperate executables (MarcoFalke)
fab4bed68 [test] fuzz: make test_one_input return void (MarcoFalke)
6f6514a08 Correct units for "-dbcache" and "-prune" (Hennadii Stepanov)
fa5e6ef55 wallet: Fixup rescanblockchain result doc (MarcoFalke)
04da9f483 [RPC] Update getrawtransaction interface (Amiti Uttarwar)
65bc38d1c [doc] add notes on release notes (John Newbery)
4f2e6c8b8 Squashed 'src/leveldb/' changes from 524b7e36a8..f545dfabff (MarcoFalke)
44de1561a Remove remaining chainActive references from CWallet (Russell Yanofsky)
db21f0264 Convert CWallet::ScanForWalletTransactions and SyncTransaction to the new Chain apis (Russell Yanofsky)
2ffb07929 Add findFork and findBlock to the Chain interface (Russell Yanofsky)
d93c4c1d6 Add time methods to the Chain interface (Russell Yanofsky)
700c42b85 Add height, depth, and hash methods to the Chain interface (Russell Yanofsky)
0297be61a Allow connections from misbehavior banned peers. (Gregory Maxwell)
faa1522e5 RPCHelpMan: Pass through Result and Examples (MarcoFalke)
fa5f890ae rpc: Compile on GCC4.8 (MarcoFalke)
70e7cee96 Trivial: Doxygenize existing CBufferedFile and VectorReader comments (Ben Woosley)
9431e1b91 Trivial: fixup a few doxygen comments (Ben Woosley)
ad5e5a105 Scripts and tools: Drop no-longer-relevant copyright holder names (Ben Woosley)
2434ab5c2 Scripts and tools: Fix devtools/copyright_header.py to always honor exclusions (Ben Woosley)
f618c58b7 Docs: Update python docs to reflect that wildcard imports are disallowed (Ben Woosley)
b09dab0f2 Prevent mutex lock fail even if --enable-debug (Akio Nakamura)
a36d97d86 Default -whitelistforcerelay to off (Suhas Daftuar)
5a5ea93e8 Doc: add information about security to the JSON-RPC doc (David A. Harding)
fdf82ba18 Update all subprocess.check_output functions in CI scripts to be Python 3.4 compatible (Graham Krizek)
42ff30ec6 [Docs] add short documentation for /rest/blockhashbyheight (Jonas Schnelli)
579d418f7 [QA] add rest tests for /rest/blockhashbyheight/<HEIGHT>.<FORMAT> (Jonas Schnelli)
eb9ef04c4 REST: add "blockhashbyheight" call, fetch blockhash by height (Jonas Schnelli)
da6011826 Fix macOS launch-at-startup memory issue (Jonas Schnelli)
516437a1b Qt: remove macOS launch-at-startup option when compiled with > macOS 10.11 (Jonas Schnelli)
948d8f4f1 lint: Enable python linters via an array (Ben Woosley)
b301950df Made expicit constructor CTransaction(const CMutableTransaction &tx). (lucash-dev)
faf29dd01 Minimal changes to comply with explicit CMutableTransaction -> CTranaction conversion. (lucash-dev)
223de8d94 Document RNG design in random.h (Pieter Wuille)
f2e60ca98 Use secure allocator for RNG state (Pieter Wuille)
cddb31bb0 Encapsulate RNGState better (Pieter Wuille)
152146e78 DRY: Implement GetRand using FastRandomContext::randrange (Pieter Wuille)
a1f252eda Sprinkle some sweet noexcepts over the RNG code (Pieter Wuille)
4ea8e5083 Remove hwrand_initialized. (Pieter Wuille)
9d7032e4f Switch all RNG code to the built-in PRNG. (Pieter Wuille)
16e40a8b5 Integrate util/system's CInit into RNGState (Pieter Wuille)
2ccc3d3aa Abstract out seeding/extracting entropy into RNGState::MixExtract (Pieter Wuille)
aae8b9bf0 Add thread safety annotations to RNG state (Pieter Wuille)
d3f54d1c8 Rename some hardware RNG related functions (Pieter Wuille)
05fde14e3 Automatically initialize RNG on first use. (Pieter Wuille)
2d1cc5093 Don't log RandAddSeedPerfmon details (Pieter Wuille)
6a57ca91d Use FRC::randbytes instead of reading >32 bytes from RNG (Pieter Wuille)
de7266fc3 [net] add dnsseed.emzy.de to DNS seeds (Stephan Oeste)
18185b57c scripted-diff: batch-recase BanMan variables (Carl Dong)
c2e04d37f banman: Add, use CBanEntry ctor that takes ban reason (Carl Dong)
1ffa4ce27 banman: reformulate nBanUtil calculation (Carl Dong)
daae598fe banman: add thread annotations and mark members const where possible (Cory Fields)
84fc3fbd0 scripted-diff: batch-rename BanMan members (Cory Fields)
af3503d90 net: move BanMan to its own files (Cory Fields)
d0469b2e9 banman: pass in default ban time as a parameter (Cory Fields)
2e56702ec banman: pass the banfile path in (Cory Fields)
4c0d961eb banman: create and split out banman (Cory Fields)
83c1ea2e5 net: split up addresses/ban dumps in preparation for moving them (Cory Fields)
136bd7926 tests: remove member connman/peerLogic in TestingSetup (Cory Fields)
7cc2b9f67 net: Break disconnecting out of Ban() (Cory Fields)
ca91661ad Fix wallet selector size adjustment (Hennadii Stepanov)
7cf994d5c qa: Improve tests of /rest/headers and /rest/block (João Barbosa)
0825b86b2 doc: /rest/block responds with 404 if block does not exist (João Barbosa)
be625f7c5 doc: Explain empty result of /rest/headers (João Barbosa)
3046e5fc0 Update zmq to 4.3.1 (Dimitris Apostolou)
85f0ca95f Remove errant past from walletcreatefundedpsbt for nLocktime replaceability (Gregory Sanders)
f1dc6932e zmq: log outbound message high water mark when reusing socket (fanquake)
1ed425ea1 gui: Fix window title update (João Barbosa)
5b4283cb8 Add comment describing fDisconnect behavior (Carl Dong)
a2a6c8f45 rpc: remove duplicate solvable field from getaddressinfo (fanquake)
979bc0c20 Improve "help-console" message (Hennadii Stepanov)
4e81438f6 build: Drop macports support (Ben Woosley)
0dd9bdefa gui: Refactor to use WalletController (João Barbosa)
8fa271f08 gui: Add WalletController (João Barbosa)
cefb399e2 gui: Use AutoConnection for WalletModel::unload signal (João Barbosa)
7c572c488 Add workaround for QProgressDialog bug on macOS (Hennadii Stepanov)
a51754179 Remove no longer needed shellcheck suppressions (practicalswift)
0b7196eca Fix warnings introduced in shellcheck v0.6.0 (practicalswift)
07a53dce9 Remove repeated suppression. Fix indentation. (practicalswift)
638e53b47 Pin shellcheck version to v0.6.0 (practicalswift)
31097b7b0 docs: Spelling error fix on fuzzing.md (benthecarman)
24313fbf7 Remove redundant stopExecutor() signal (Hennadii Stepanov)
1c0e0a5e3 Remove redundant stopThread() signal (Hennadii Stepanov)
89282379b threads: fix unitialized members in sched_param (Cory Fields)
b745e149c [docs] Expand help text for importmulti changes (John Newbery)
4a86a0acd Make SafeDbt DB_DBT_MALLOC on default initialization (Ben Woosley)
1a9f9f7e5 Introduce SafeDbt to handle DB_DBT_MALLOC raii-style (Ben Woosley)
951a44e9c Drop unused setRange arg to BerkeleyBatch::ReadAtCursor (Ben Woosley)
b9dafe7d9 Fix remaining compiler warnings (MSVC). Move disabling of specific warnings from /nowarn to project file. (practicalswift)
e4a0c3547 Improve blocksdir functional test. (Hennadii Stepanov)
c3f1821ac Make blockdir always net specific (Hennadii Stepanov)
4412a59bf qa: Remove race between connecting and shutdown on separate connections (João Barbosa)
3537c8345 Do not deselect peer when switching away from tab (Hennadii Stepanov)
b0037c519 Improve Peers tab layout (Hennadii Stepanov)
f1bd219a5 contrib: Allow use of github API authentication in github-merge (Wladimir J. van der Laan)
a4c5bbfcd contrib: Add support for http[s] URLs in github-merge (Wladimir J. van der Laan)
059a3cffd contrib: Detailed reporting for http errors in github-merge (Wladimir J. van der Laan)
cbd9091ed refactor/lint: Add ignored suggestions to an array (Vidar Holen)
04215eb32 [doc] explain what .python-version does (Sjors Provoost)
fe7048b39 gui: Show current wallet name in window title (João Barbosa)
8a7926112 gui: Keep network style in BitcoinGUI (João Barbosa)
f411c8b35 gui: Remove unused return type in some BitcoinGUI methods (João Barbosa)
fa5e37336 validation: Add cs_main locking annotations (MarcoFalke)
fa5c346c5 doc: Add comment to cs_main and mempool::cs (MarcoFalke)
fafe941bd test: Add missing validation locks (MarcoFalke)
fac455846 sync: Add RecursiveMutex type alias (MarcoFalke)
03b8596dd Add checksum in gitian build scripts for ossl (TheCharlatan)
fb3ce7580 Don't label transactions "Open" while catching up (Hennadii Stepanov)
a88640e12 Fix minimized window bug on Linux (Hennadii Stepanov)
645e905c3 doc: Add release notes for unloadwallet change to synchronous call (João Barbosa)
c37851de5 rpc: Make unloadwallet wait for complete wallet unload (João Barbosa)
a0ac15459 doc: Add getrpcinfo release notes (João Barbosa)
251a91c1b qa: Add tests for getrpcinfo (João Barbosa)
d0730f5ce rpc: Add getrpcinfo command (João Barbosa)
068a8fc05 rpc: Track active commands (João Barbosa)
bf4383277 rpc: Remove unused PreCommand signal (João Barbosa)
f652f85d0 qa: Ignore shellcheck warning SC2236 (João Barbosa)
3a0e76fc1 Replace remaining 0 with nullptr in Qt code (Ben Woosley)
9096276e0 Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) (practicalswift)
fac2f5eca Use C++11 default member initializers (MarcoFalke)
d6b076c17 Drop IsLimited in favor of IsReachable (Ben Woosley)
8ac34140d configure: bitcoin-tx doesn't need libevent, so don't pull it in (Luke Dashjr)
9d0e52834 implements different disk sizes for different networks on intro (marcoagner)
fad058a79 build: Allow to configure --with-sanitizers=fuzzer (MarcoFalke)
332b3dd7c util: Make ToLower and ToUpper take a char (Wladimir J. van der Laan)
edb5bb350 util: remove unused [U](BEGIN|END) macros (Wladimir J. van der Laan)
7fa238c70 Replace use of BEGIN and END macros on uint256 (Wladimir J. van der Laan)
fa48baf23 wallet: Avoid leaking locktime fingerprint when anti-fee-sniping (MarcoFalke)
453803adc [test] wallet_txn_clone: Correctly clone txin sequence (MarcoFalke)
5282608e9 docs: Add FreeBSD build notes link to doc/README.md (fanquake)
ef5ebc6d8 docs: Clarifying testing instructions (benthecarman)
2d5f1ea2e [tests] move wallet util functions to wallet_util.py (John Newbery)
6be64ef02 [tests] tidy up wallet_importmulti.py (John Newbery)
93009618b Fix start with the `-min` option (Hennadii Stepanov)
369d7b392 Fix download link (Martin Erlandsson)
8931a95be Include util/strencodings.h which is required for IsSpace(...) (practicalswift)
7c9f79076 Update KNOWN_VIOLATIONS: Remove fixed violations (practicalswift)
587924f00 Use IsSpace(...) instead of boost::is_space (practicalswift)
c5fd143ed Use ToLower(...) instead of std::tolower (practicalswift)
e70cc8983 Use IsDigit(...) instead of std::isdigit (practicalswift)
6dc4593db IsReachable is the inverse of IsLimited (DRY). Includes unit tests (marcaiaf)
ca126d490 Fix out-of-bounds write in case of failing mmap(...) in PosixLockedPageAllocator::AllocateLocked (practicalswift)
ba8c8b222 Fail if either disk space check fails (Ben Woosley)
8cff83124 Error if rpcpassword contains hash in conf sections (MeshCollider)
fa2510d5c Use C++11 default member initializers (MarcoFalke)
ed12d5df1 index: Fix for indexers skipping genesis block. (Jim Posen)
7e4bd1978 Add BitcoinApplication & RPCConsole tests (Russell Yanofsky)
ca20b65cc Move BitcoinApplication to header so it can be tested (Russell Yanofsky)
fab17e827 test: Add basic test for BIP34 (MarcoFalke)
f12e1d0b5 rpc: Avoid permanent cs_main lock in getblockheader (João Barbosa)
fa38d3df6 [rpc] Correct reconsiderblock help text, add test (MarcoFalke)
fab3f1467 rpc: Document bytessent_per_msg and bytesrecv_per_msg (MarcoFalke)
c98f8866f Fix the build problem in libbitcoin_server (Alexey Poghilenkov)
fac4e731a test: Run invalid_txs.InputMissing test in feature_block (MarcoFalke)
91b0c5b09 qt: Use WalletModel* instead of wallet name in console window (João Barbosa)
b2ce86c3a qt: Use WalletModel* instead of wallet name in main window (João Barbosa)
d2a1adffe qt: Factor out WalletModel::getDisplayName() (João Barbosa)
4f4993fe2 Remove UBSan suppression (practicalswift)
958e1a307 streams: Remove unused seek(size_t) (practicalswift)
6b25f29a9 Use std::vector API for construction of test data. (Daniel Kraft)
b9f226b41 rpc: Remove cs_main lock from blockToJSON and blockHeaderToJSON (João Barbosa)
343b98cbc rpc: Specify chain tip instead of chain in GetDifficulty (João Barbosa)
54dc13b6a rpc: Fix SoftForkMajorityDesc and SoftForkDesc signatures (João Barbosa)
75778a072 test: Correct ineffectual WithOrVersion from transactions_tests (Ben Woosley)
e58985c91 Log progress while verifying blocks at level 4. (Daniel Kraft)
a62e66729 docs: Add more Doxygen information to Developer Notes (Jon Layton)
698d0f882 Remove misplaced Q_UNUSED and others enhancements (Hennadii Stepanov)
cc341adbb gui: Fix for Incorrect application name when passing -regtest (Ben Carman)
5bb0164ce depends: Enable unicode support on dbd for Windows (Chun Kuan Lee)
79f0a3f1f Get more info about GUI-related issue on Linux (Hennadii Stepanov)
1db71d4a2 Add names to Travis jobs (Graham Krizek)
751436125 Correct misleading "overridden options" label (Hennadii Stepanov)
f3d7d75e4 Release notes: integrate detached release notes (David A. Harding)
97fbe6794 Release notes: update notes through fb52d0684 (David A. Harding)
c8d9d9093 Fix broken notificator on GNOME (Hennadii Stepanov)
59e387705 test: add invalid tx templates for use in functional tests (James O'Beirne)
c9066f07c Allow running rpc_bind.py --nonloopback test without IPv6 (Kristaps Kaupe)
4927bf2f2 Increase maxconnections limit when using poll. (Patrick Strateman)
11cc491a2 Implement poll() on systems which support it properly. (Patrick Strateman)
28211a4bc Move SocketEvents logic to private method. (Patrick Strateman)
7e403c0ae Move GenerateSelectSet logic to private method. (Patrick Strateman)
1e6afd0db Introduce and use constant SELECT_TIMEOUT_MILLISECONDS. (Patrick Strateman)
de23739b2 test: Fix rpc_net.py "pong" race condition (Ben Woosley)
b60ac00d2 Botbot.me (IRC logs) not available anymore (Antti Majakivi)
3019ba28d Making supported operating systems more clear (Ben Carman)
1a49a0e31 Bump manpages (DrahtBot)
06ba77973 Update copyright headers to 2018 (DrahtBot)
ae5594d51 [Trivial] Update license year range to 2019 (Emil Engler)
4999992c3 whitespace: Split ~300 char line into multiple ones (MarcoFalke)
fa71b3816 scripted-diff: Rename rpc_timewait to rpc_timeout (MarcoFalke)
fa3e5786d scripted-diff: Remove unused 'split' parameter to setup_network (MarcoFalke)
2474de026 Fix running individually through test_runner.py, as suggested by @MarcoFalke (#14732) (Kristaps Kaupe)
b6f0db69a Increase timeout of featuer_assumevalid test to fix flaky tests (Graham Krizek)
aa9aca85f If tests are ran with (ASan + LSan), Docker needs access to ptrace (Graham Krizek)
a3b8b4366 Update Travis base OS to Xenial (Graham Krizek)
cb53b825c scripted-diff: Replace boost::bind with std::bind (Chun Kuan Lee)
2196c5182 refactor: Use boost::scoped_connection in signal/slot, also prefer range-based loop instead of std::transform (Chun Kuan Lee)
b74a52192 fix testmempoolaccept CLI syntax (1Il1)
84104c781 clarifying getrawtransaction[time] get help text (Ben Carman)
be5ca825a doc: update NetBSD build instructions for 8.0 (fanquake)
523785042 Modify build instructions to work with Command Prompt as well as PowerShell; other minor changes (Murray Nesbitt)
72b63bc90 Fix minor grammar error in doc (bitcoinhodler)
fa3e874d6 test: pruning: Check that verifychain can be called when pruned (MarcoFalke)
488563ea1 doc: Add historical release notes for 0.17.1 (Wladimir J. van der Laan)
eacff95de Add release notes (Pieter Wuille)
bdacbda25 Overhaul importmulti logic (Pieter Wuille)
66e15e8f9 Explain GetAncestor check for m_failed_blocks in AcceptBlockHeader (Sjors Provoost)
57281199b lint/format-strings: Correctly exclude escaped percent symbols (Luke Dashjr)
dae1423e5 Add locking annotations to feeStats, shortStats and longStats (practicalswift)
764e42fee scripted-diff: Rename from cs_feeEstimator to m_cs_fee_estimator (practicalswift)
9a789d4dc policy: Add Clang thread safety annotations for variables guarded by cs_feeEstimator (practicalswift)
e4ed8ce2c blockfilter: Remove default clause in switch statement. (Jim Posen)
c30620983 blockfilter: Additional constructors for BlockFilter. (Jim Posen)
20b812993 blockfilter: Refactor GCS params into struct. (Jim Posen)
fabcd645b test: Avoid racy test p2p_timeouts (MarcoFalke)
d2ce315fb [docs] add release note for change to GBT (John Newbery)
0025c9eae [mining] segwit option must be set in GBT (John Newbery)
fa05d52af test: Bump timeout to run tests in travis thread sanitizer (MarcoFalke)
f3f6dde56 Test coinbase category in wallet rpcs (andrewtoth)
e982f0b68 Add all category options to wallet rpc help (andrewtoth)
6c10037f7 rpc: Fix data race (UB) in InterruptRPC() (practicalswift)
fa9a5bc1a RPCHelpMan: Support required arguments after optional ones (MarcoFalke)
fa61202ca test: Add comment to g_insecure_rand_ctx (MarcoFalke)
fa0d3c440 test: Undo thread_local g_insecure_rand_ctx (MarcoFalke)
eaf4070e3 Add suppression for InterruptRPC (fRPCRunning) data race (practicalswift)
5e5138a72 travis: Use trap and set -e errtrace (Chun Kuan Lee)
069752b72 build: Enable functional tests in the ThreadSanitizer (TSan) build job (practicalswift)
82687b503 docs: add NSIS setup/install steps to windows docs (luciana)
4d454dcb6 Refactoring with QString::toNSString (Hennadii Stepanov)
8b9171ccf wallet: Initialize stop_block to nullptr in CWallet::ScanForWalletTransactions (Ben Woosley)
faee59103 test: Fix race in mempool_accept (MarcoFalke)
3e21b690d [Qt] Restore < Qt5.6 compatibility for addAction (Jonas Schnelli)
d98a29ec4 Fix cuckoocache_tests TSAN failure introduced in #14935. Fixes#14967. (practicalswift)
95a5a9fcc qt: Remove ellipsis from sending/receiving addresses (João Barbosa)
a96c0df35 qt: Add Window menu (João Barbosa)
9ea38d022 qt: Allow to inspect RPCConsole tabs (João Barbosa)
c84c2b8c9 tests: Test for expected return values when calling functions returning a success code (practicalswift)
fa30a0e7f test: mempool_persist: Verify prioritization is dumped correctly (MarcoFalke)
fa4b8c90d test: add_nodes can only be called once after set_test_params (MarcoFalke)
faa831102 Revert "tests: Support calling add_nodes more than once" (MarcoFalke)
0e75f44a0 Replace CAffectedKeysVisitor with descriptor based logic (Pieter Wuille)
faead93c6 test: Make g_insecure_rand_ctx thread_local (MarcoFalke)
4de11a368 Remove Python 2 import workarounds (practicalswift)
fc91c1f28 Revert "travis: Save cache on build error" (Chun Kuan Lee)
98a1846b0 tests: Support calling add_nodes more than once (Steven Roose)
fbaaf782c validation: assert that pindexPrev is non-null when required (Karl-Johan Alm)
a46c8476e depends: disable unused qt features (fanquake)
73b46eeb7 depends: qt 5.9.7 (fanquake)
095e76597 depends: expat 2.2.6 (fanquake)
aaaa8eb1e test: consensus: Check that final transactions are valid (MarcoFalke)
fae3617d7 test: Correctly deserialize without witness (MarcoFalke)
fa694f706 test: Add tests for truncated scripts (MarcoFalke)
e414486d5 Do not permit copying FastRandomContexts (Pieter Wuille)
022cf47dd Simplify testing RNG code (Pieter Wuille)
fd3e7973f Make unit tests use the insecure_rand_ctx exclusively (Pieter Wuille)
8d98d4261 Bugfix: randbytes should seed when needed (non reachable issue) (Pieter Wuille)
273d02580 Use a FastRandomContext in LimitOrphanTxSize (Pieter Wuille)
3db746beb Introduce a Shuffle for FastRandomContext and use it in wallet and coinselection (Pieter Wuille)
8098379be Use a local FastRandomContext in a few more places in net (Pieter Wuille)
9695f31d7 Make addrman use its local RNG exclusively (Pieter Wuille)
78542a3f3 doc: Fix PSBT howto and example parameters (priscoan)
dcb70b152 Indicate -rpcauth option password hashing alg (Carl Dong)
31926ee8c [test] functional framework: add CScript hex() for Python 3.4 (Sjors Provoost)
74ce32683 [test] Travis: enforce Python 3.4 support in functional tests (Sjors Provoost)
c9ba253f4 Add E711 to flake8 check (Daniel Ingram)
17b55202d Compare to None with is/is not (Daniel Ingram)
1b89074ae Change '== None' to 'is None' (Daniel Ingram)
16d293772 Handle exception as ImportError (Daniel Ingram)
8db0c3d42 Removed implicit CTransaction conversion from benchmaks (lucash-dev)
ed61abedb Removed implicit CTransaction constructor from tests (lucash-dev)
9b51b158f Add nice table to files.md (Emil Engler)
8e209340c build: Add CLIENT_VERSION_BUILD to CFBundleGetInfoString (fanquake)
b7bee6af7 doc: Update minimum required qt (fanquake)
bd3b0361d Add stop_block out arg to ScanForWalletTransactions (Ben Woosley)
3002d6cf3 Return a status enum from ScanForWalletTransactions (Ben Woosley)
bb24d6865 Make CWallet::ScanForWalletTransactions args and return value const (Ben Woosley)
26879509f Add comments to descriptor tests (Pieter Wuille)
82df4c64f Add descriptor expansion cache (Pieter Wuille)
1eda33aab [refactor] Combine the ToString and ToPrivateString implementations (Pieter Wuille)
24d3a7b3a [refactor] Use DescriptorImpl internally, permitting access to new methods (Pieter Wuille)
6be0fb4b3 [refactor] Add a base DescriptorImpl with most common logic (Pieter Wuille)
ee3b21dcc [tests] Add docstring for wallet_importmulti.py (John Newbery)
fbdba4059 [tests] add test_address method to wallet_import.py (John Newbery)
fd3a02c38 [tests] add test_importmulti method to wallet_import.py (John Newbery)
08a4a0f70 [tests] add get_multisig function to wallet_importmulti.py (John Newbery)
7c99614b4 [tests] add get_key function to wallet_importmulti.py (John Newbery)
e5a8ea8f1 [tests] tidy up imports in wallet_importmulti.py (John Newbery)
cb41ade6b [tests] fix flake8 warnings in wallet_importmulti.py (John Newbery)
0dcac5104 wallet_keypool_topup.py: Test for all keypool address types (Gregory Sanders)
522b80b33 add `--retry 5` to curl opts in install_db4.sh (qubenix)
fa0c24c96 rpc: Document default values for optional arguments (MarcoFalke)
e09a5875c rpc: Assert named arguments are unique in RPCHelpMan (João Barbosa)
45842c3d2 Improve documentation for running verify-commits.py script (Jameson Lopp)
4ab638b79 http -> https (Dimitris Apostolou)
0b4a5786b Use window() instead of obsolete topLevelWidget() (Hennadii Stepanov)
d6b3790d1 tests: check readability of cookie file (Chun Kuan Lee)
5c40e7b91 test: allows test_runner command line to receive parameters for each test (marcoagner)
fa4c8679e rpc: Avoid creating non-standard raw transactions (MarcoFalke)
7d1b60ce9 Cleanup SplashScreen class (Hennadii Stepanov)
b7df96f45 refactor: Drop boost::this_thread::interruption_point and boost::thread_interrupted in main thread (Chun Kuan Lee)
fa4fc8856 validation: Add and use HaveTxsDownloaded where appropriate (MarcoFalke)
6bbdb2077 squashme: connect thru node interface (João Barbosa)
a0f8df365 qt: Call noui_connect to prevent boost::signals2::no_slots_error in early calls to InitWarning (João Barbosa)
58c5cc9ce Adjust configure so that only bip70 is disabled when protobuf is missing instead of the GUI (James Hilliard)
28479f926 qa: Test bitcond shutdown (João Barbosa)
8d3f46ec3 http: Remove timeout to exit event loop (João Barbosa)
e98a9eede http: Remove unnecessary event_base_loopexit call (João Barbosa)
6b13580f4 http: Unlisten sockets after all workers quit (João Barbosa)
18e968581 http: Send "Connection: close" header if shutdown is requested (João Barbosa)
02e1e4eff rpc: Add wait argument to stop (João Barbosa)
a67d71311 [doc] developer-notes.md: point out that UniValue deviates from upstream (Sjors Provoost)
1ca050254 scripts: Add trusted key for Samuel Dobson (Wladimir J. van der Laan)
688f665a5 Scripts and tools & Docs: Used #!/usr/bin/env bash instead of obsolete #!/bin/bash, added linting for .sh files shebang and updated the Developer Notes. (vim88)
cf4b0327e Use std::numeric_limits<UNSIGNED>::max()) instead of (UNSIGNED)-1 (practicalswift)
6b82fc59e Use const in COutPoint class (Hennadii Stepanov)
43f909990 scripted-diff: Run scripted-diff in subshell (Carl Dong)
fabca42c6 RPCHelpMan: Add space after colons in extended description (MarcoFalke)
fafd040f7 rpc: Add description to fundrawtransaction vout_index (MarcoFalke)
1db0096f6 rpc: Pass argument descriptions to RPCHelpMan (MarcoFalke)
b14948e2e Remove duplicate libconsensus linking in test make (Amir Abrams)
f3cf95ffd tests: Modify rpc_bind to conform to #14532 behaviour. (Carl Dong)
48b37db50 make peertimeout a debug argument, remove error message translation (Zain Iqbal Allarakhia)
8042bbfbf p2p: allow p2ptimeout to be configurable, speed up slow test (Zain Iqbal Allarakhia)
af1ed206f Fix broken Gmane URLs (Craig Younkins)
467461030 Log env path in BerkeleyEnvironment::Flush (João Barbosa)
6c6ee8af8 Less confusing documentation for `torpassword` (Chakib Benziane)
2012d4df2 Add CScriptNum decode python implementation in functional suite (Gregory Sanders)
1c28feb7d qt: Remove hidden columns in coin control dialog (João Barbosa)
d3ecc3d69 travis: Save cache on build error (Chun Kuan Lee)
82d6c5aad gui: Show watch-only eye instead of HD disabled (Chun Kuan Lee)
fe1ff5026 Hide spendable label if priveate key is disabled (Chun Kuan Lee)
c5ed6e73d Move CheckBlock() call to critical section (Hennadii Stepanov)
bf2e01097 uint256: Remove unnecessary crypto/common.h use (Karl-Johan Alm)
c1825b9d3 [tests] Add wallet_balance.py (John Newbery)
0fb2e6981 CreateTransaction: Assume minimum p2sh-p2wpkh spend size for unknown change (Gregory Sanders)
b06483c96 Remove stale comment in CalculateMaximumSignedInputSize (Gregory Sanders)
4aabadbf4 tests: have combine_logs default to most recent test dir (James O'Beirne)
fa5cef0f7 bench: Destroy wallet txs instead of leaking their memory (MarcoFalke)
4894133dc Add missing lock in CNode::copyStats(...) (practicalswift)
b312cd770 Add missing locking annotations (practicalswift)
29aeed173 Bugfix: test/functional/mempool_accept: Ensure oversize transaction is actually oversize (Luke Dashjr)
6541d59dd Add LSan suppression warnings (practicalswift)
ff7212ec3 Add ASan Travis build (practicalswift)
ebd3bf259 Make test p2p_invalid_messages.py pass: Allow for expected Travis ASAN memory increase (practicalswift)
109699dd3 Add release notes (Pieter Wuille)
b65326b56 Add matching descriptors to scantxoutset output + tests (Pieter Wuille)
16203d5df Add descriptors to listunspent and getaddressinfo + tests (Pieter Wuille)
9b2a25b13 Add tests for InferDescriptor and Descriptor::IsSolvable (Pieter Wuille)
225bf3e3b Add Descriptor::IsSolvable() to distinguish addr/raw from others (Pieter Wuille)
4d78bd93b Add support for inferring descriptors from scripts (Pieter Wuille)
c77f09230 Fix descriptor_tests not checking ToString output of public descriptors (Russell Yanofsky)
fa739d4bd qa: Add wallet_encryption error tests (MarcoFalke)
fa71eb519 Convert comments to thread safety annotations (MarcoFalke)
5a1f57646 qa: clean up assert_memory_usage_stable utility (James O'Beirne)
0cf1632f0 qa: fix p2p_invalid_messages on macOS (James O'Beirne)
848077f94 clarify RPC rawtransaction documentation (Jameson Lopp)
e4eee7d09 Add Benchmark to test input de-duplication worst case (Jeremy Rubin)
af9a9918b Fix detection of copyright holders (Cornelius Schumacher)
fa7d36b8e test: Move UBSAN suppressions to test/sanitizer_suppressions/ubsan (MarcoFalke)
fa36d4e45 travis: --disable-hardening for xenial thread sanitizer (MarcoFalke)
89bf196c8 travis: Run thread sanitizer (MarcoFalke)
60ae463a6 Fix `bitcoin-qt -version` output formatting (Hennadii Stepanov)
b81a18605 GetPubKey: make sigdata const (Gregory Sanders)
f7beb95a1 remove redundant KeyOriginInfo access, already done in CreateSig (Gregory Sanders)
75a4bf699 Update release-process.md to include RC version bumping (Andrew Chow)
04b0bc742 build: include rc number in version number (Andrew Chow)
895e6bbb2 build: if VERSION_BUILD is non-zero, include it in the package version (Andrew Chow)
0c69ff617 clarify rpcwallet flag url change (Jordan Baczuk)
b7b36deca fix uninitialized read when stringifying an addrLocal (Kaz Wesley)
8ebbef016 add test demonstrating addrLocal UB (Kaz Wesley)
fa5e0452e rpc: Documentation fixups (MarcoFalke)
fa91e8eda Use RPCHelpMan for all RPCs (MarcoFalke)
fa520e72f lint: Must use RPCHelpMan to generate the RPC docs (MarcoFalke)
828475670 A few minor formatting fixes and clarifications to descriptors.md (John Newbery)
3d2c7d6f9 Add regtest for JSON-RPC batch calls. (Daniel Kraft)
fa21ca09a test: Add BOOST_REQUIRE to getters returning optional (MarcoFalke)
d6cde007d rpcauth: Improve by using argparse and getpass modules (João Barbosa)
27c44ef9c rpcbind: Warn about exposing RPC to untrusted networks (Luke Dashjr)
d6a128748 CNetAddr: Add IsBindAny method to check for INADDR_ANY (Luke Dashjr)
361500395 net: Always default rpcbind to localhost, never "all interfaces" (Luke Dashjr)
69ca48717 Implement prevector::fill once (Ben Woosley)
7bad78c2c Drop defunct IS_TRIVIALLY_CONSTRUCTIBLE handling from prevector.h (Ben Woosley)
3fb09b988 Warn unrecognized sections in the config file (Akio Nakamura)
fa7da0617 qa: Check specific reject reasons in feature_block (MarcoFalke)
6be7d14d2 Properly generate salt in rpcauth.py, update tests (Carl Dong)
feeef7d30 Do not specify sudo in .travis (Julian Fleischer)
591203149 wallet: Create IsDatabaseLoaded function (Chun Kuan Lee)
15c93f075 wallet: Add trailing wallet.dat when detecting duplicate wallet if it's a directory. (Chun Kuan Lee)
c456fbd8d Refactor: Move m_db pointers into BerkeleyDatabase (Russell Yanofsky)
e816b341a revert removal of fstream.hpp header in fs.h (Karl-Johan Alm)
c54e5a41c Remove unreferenced boost headers (Murray Nesbitt)
b08af10fb disallow oversized CBlockHeaderAndShortTxIDs (Kaz Wesley)
6bed4b374 fix a deserialization overflow edge case (Kaz Wesley)
051faf7e9 add a test demonstrating an overflow in a deserialization edge case (Kaz Wesley)
07e286d94 Improve scripted-diff developer docs (Carl Dong)
9cc0230cf Add NODISCARD to all {Decode,Parse}[...](...) functions returning bool. Sort includes. (practicalswift)
579497e77 tests: Explicitly ignore the return value of DecodeBase58(...) (practicalswift)
145fe95ec tests: Check return value of ParseParameters(...) (practicalswift)
7c5bc2a52 miner: Default to DEFAULT_BLOCK_MIN_TX_FEE if unable to parse -blockmintxfee (practicalswift)
da427dbd4 Rename ListTransactions filter variable (Russell Yanofsky)
65b740f92 [wallet] Restore ability to list incoming transactions by label (Russell Yanofsky)
b4f6e58ca Better error message for user when corrupt wallet unlock fails (MeshCollider)
86cddf085 doc: add detached release notes for #14060 (mruddy)
ba8f0c6c8 Release notes: integrate detached release notes (David A. Harding)
6062f0e61 Release notes: update notes through to 11e1ac3ae0 (David A. Harding)
2bc3f114d Bump the minimum Qt version to 5.2 (Hennadii Stepanov)
5c5902acc build: Add bitcoin-tx.exe into Windows installer (Chun Kuan Lee)
fa0815c30 rpc: Correctly name arguments (Jon Layton)
Pull request description:
Catching up with upstream commit 519b0bc5dc.
Tree-SHA512: 2e0f768773c51a197a56cc4a7209fce306aeef2b44c82f8859e442684d89cb520b6b27812a451916bca0fac04f3c15e9005170a201eed202a24d4419f976957b
This is technically not 100% correct since if blinded addresses are
turned off, it will create a normal address for "blech32".
But it's the simplest thing to do.
8591de929 kill useless mapPeginsSpentToTxid (Gregory Sanders)
Pull request description:
Completely redundant since https://github.com/ElementsProject/elements/pull/260 when peg-in inputs have taken on deterministic prevouts, so normal mempool logic has taken over for accounting for double-spending peg-in proofs in the mempool.
resolves https://github.com/ElementsProject/elements/issues/624
Tree-SHA512: e5c0e7570657bd1418f54fdd47a6f3f815a5779e28ff15ba37c18e425780415385af64efa57be882ba12ad748e7a664fb723eae0e819bf1d5f197bb0b82b086b
I also moved some RPC methods that were not at the end of the file with
the other ELEMENTS RPC methods. This makes the diff on my machine look
crazy. Let's hope GitHub has more intelligent diffs..
I should have split this into one commit copying the entire folder and
one where I fix the ELEMENTS-based things. However, grepping the diff
for "elements" case-insensitive makes you catch all differences.
The next commit will contain the more subtle differences.
693f20608 fill checkqueue_tests vector for completion checking (Gregory Sanders)
3cc720592 Assert that queued checks are non-null (Gregory Sanders)
d21e0563c Address some linter complaints (Steven Roose)
ad3d496d7 Add extra lock check for OSX build (Steven Roose)
872d39fbe Prevent Travis from failing when tests are disabled (Steven Roose)
4ed0bb36b Fix dead-code linter issues (Steven Roose)
bf4f1d009 MERGE-FIX: Disable p2p_invalid_messages tests to fix later (Steven Roose)
ee0e510f3 MERGE-FIX: Fix other functional tests (Steven Roose)
5492cefcc MERGE-FIX: Fix fedpeg and pak tests for 0.18.0 (Steven Roose)
1a2a93a5f MERGE-FIX: General fixes for functional tests (Steven Roose)
3a8398024 MERGE-FIX: Fix upstream functional tests (Steven Roose)
71723f794 MERGE-FIX: Adapt bitcoin_functional (Steven Roose)
449ac89f3 MERGE-FIX: Copy bitcoin_functional from upstream (Steven Roose)
9f4f2e751 MERGE-FIX: Fix compilation errors (Steven Roose)
7256637da MERGE-FIX: Makefile fix (Steven Roose)
7afddfa8c importmulti: Don't add internal addresses to address book (Gregory Sanders)
fa483e13b rpc: Add RPCHelpMan for machine-generated help (MarcoFalke)
fa0d36f71 rpc: Include rpc/util.h where needed for RPCHelpMan (MarcoFalke)
fa5a6ce10 qa: Raise ci test_runner timeout to 40 mins (MarcoFalke)
fa3df025e travis: Avoid timeout on verify-commits check (MarcoFalke)
fa2156820 qa: Avoid race in p2p_invalid_block by waiting for the block request (MarcoFalke)
6c787d340 tests: Make feature_block pass on centos (MarcoFalke)
27154ce76 util.h: explicitly include required QString header (1Il1)
4e4de10f6 Throw error if CPubKey is invalid during PSBT keypath serialization (Gregory Sanders)
a16f44c04 qt: Remove "Pay only required fee" checkbox (Hennadii Stepanov)
8711cc0c7 qt: Improve BitcoinAmountField class (Hennadii Stepanov)
a6b5ec18f rpc: creates possibility to preserve labels on importprivkey (marcoagner)
88a79cb43 fix converttopsbt permitsigdata arg, add basic test (Gregory Sanders)
038510944 Add test for rpcpassword hash error (MeshCollider)
13fe258e9 Error if rpcpassword in conf contains a hash character (MeshCollider)
ec1201a36 Don't use systray icon on inappropriate systems (Hennadii Stepanov)
fa9ed38d5 test_node: get_mem_rss fixups (MarcoFalke)
0a656f85a qt: All tray menu actions call showNormalIfMinimized (João Barbosa)
6fc21aca6 qt: Use GUIUtil::bringToFront where possible (João Barbosa)
5796671e1 qt: Add GUIUtil::bringToFront (João Barbosa)
6b1d2972b Remove obj_c for macOS Dock icon menu (Hennadii Stepanov)
2464925e7 Use Qt signal for macOS Dock icon click event (Hennadii Stepanov)
53bb6be3f Remove obj_c for macOS Dock icon setting (Hennadii Stepanov)
76e13b586 warnings: Compiler warning on memset usage for non-trivial type (Lenny Maiorani)
1e0f3c449 macOS: disable AppNap during sync (Alexey Ivanov)
6b8d86ddb Require a public key to be retrieved when signing a P2PKH input (Andrew Chow)
e13fea975 Add regression test for PSBT signing bug #14473 (Glenn Willen)
565500508 Refactor PSBTInput signing to enforce invariant (Glenn Willen)
0f5bda2bd Simplify arguments to SignPSBTInput (Glenn Willen)
53e6fffb8 Add bool PSBTInputSigned (Glenn Willen)
65166d4cf New PartiallySignedTransaction constructor from CTransction (Glenn Willen)
4f3f5cb4b Remove redundant txConst parameter to FillPSBT (Glenn Willen)
fe5d22bc6 More concise conversion of CDataStream to string (Glenn Willen)
081accb87 Pass chain locked variables where needed (Russell Yanofsky)
79d579f4e Remove uses of cs_main in wallet code (Russell Yanofsky)
ea961c3d7 Remove direct node->wallet calls in init.cpp (Russell Yanofsky)
8db11dd0b Pass chain and client variables where needed (Russell Yanofsky)
7e2e62cf7 Add skeleton chain and client classes (Russell Yanofsky)
fa4da3c05 [doc] conf: Remove deprecated options from docs, Other cleanup (MarcoFalke)
7a90b1b9d build: Fix windows build error if `--disable-bip70` (Chun Kuan Lee)
b191c7dfb doc: add comment explaining recentRejects-DoS behavior (James O'Beirne)
c82190cdb tests: Add Python dead code linter (vulture) (practicalswift)
590a57fde tests: Remove unused testing code (practicalswift)
535203075 Avoid using numeric_limits for sequence numbers and lock times (Russell Yanofsky)
bafb92150 Remove duplicated code (Hennadii Stepanov)
e4dc39b3b Replace platform dependent type with proper const (Hennadii Stepanov)
053b6f42d align items in contrib init (Harry Moreno)
99d33a6be appveyor: Script improvement part II (Chun Kuan Lee)
4773fa820 Add llvm-symbolizer directory to PATH. Needed to get symbolized stack traces from the sanitizers. (practicalswift)
5c292dafc Add UBSan suppressions needed to pass test suite (practicalswift)
fced6b508 Add UBSan options: print_stacktrace + halt_on_error (practicalswift)
3d305e3b8 Send fewer spam messages in p2p_invalid_messages (James O'Beirne)
5a05aa2db Add metavar to match var name in help text + Change wording for better readability (Martin Erlandsson)
fef5adcc3 blockfilter: Use unordered_set instead of set in blockfilter. (Jim Posen)
4fb789e9b Extract CSipHasher to it's own file in crypto/ directory. (Jim Posen)
bbbbb3f88 qa: Add test to ensure node can generate all help texts at runtime (MarcoFalke)
d20a9fa13 tests: add tests for invalid P2P messages (James O'Beirne)
62f94d39f tests: add P2PConnection.send_raw_message (James O'Beirne)
5aa31f6ef tests: add utility to assert node memory usage hasn't increased (James O'Beirne)
825f779dc doc: Add historical release notes for 0.17.0.1 (Wladimir J. van der Laan)
9f49db733 Enable functional tests in UBSAN job. Enable -fsanitize=integer (part of UBSAN). Merge UBSAN Travis job with no depends. (practicalswift)
6c5355e43 example_test.py: fixup coinbase height argument, derive number clearly (Gregory Sanders)
b6022149e trivial: Don't translate in help text (ken2812221)
086fc8357 Tests: Fix a comment (fridokus)
dfef0df84 tests: Dry run bench_bitcoin (-evals=1 -scaling=0: <1 second running time) as part "make check" to allow for quick identification of assertion/sanitizer failures in benchmarking code (practicalswift)
00c6306a6 Remove RUN_BENCH logic (practicalswift)
a4edb168b ZMQ: add options to configure outbound message high water mark, aka SNDHWM (mruddy)
ab8c6f24d Add SAFE_CHARS[SAFE_CHARS_URI]: Chars allowed in URIs (RFC 3986) (practicalswift)
991248649 rpc: Make HTTP RPC debug logging more informative (practicalswift)
33ae98591 doc: Update OpenBSD build guide for 6.4 (fanquake)
6d247b114 gitignore contents of db4 folder (Marty Jones)
4ed730802 scripted-diff: Rename misleading 'defaultPort' to 'http_port' (Murray Nesbitt)
65f3672f3 wallet: Refactor to use WalletLocation (João Barbosa)
01a4c095c wallet: Add WalletLocation utility class (João Barbosa)
04972fefd Remove unused `adjustedTime` parameter (Hennadii Stepanov)
63c74d2d3 build: Remove illegal spacing in darwin.mk (Jon Layton)
2068f089c scripted-diff: Move util files to separate directory. (Jim Posen)
14a06525b tests: add test for 'getaddressinfo' RPC result 'ischange' field (whythat)
93d1aa9ab rpcwallet: add 'ischange' field to 'getaddressinfo' response (whythat)
fa4bcaf82 travis: Compile once on xenial (MarcoFalke)
fa4362661 test_runner: Remove travis specific code (MarcoFalke)
3fd7e76f6 [tests] Move deterministic address import to setup_nodes (John Newbery)
4fb3388db check that a separator is found for psbt inputs, outputs, and global map (Andrew Chow)
9605bbd31 Make clear function argument case in dev notes (Carl Dong)
fa77aaa5a doc: Add external interface consistency guarantees (MarcoFalke)
862d159d6 Add test for conversion from non-witness to witness UTXO (Pieter Wuille)
f8c171463 Convert non-witness UTXOs to witness if witness sig created (Andrew Chow)
0a0466761 FreeBSD: Document Python 3 requirement for 'gmake check' (Murray Nesbitt)
4bd125fff tests: Print dots by default (Chun Kuan Lee)
cf2f4306f gui: explicitly disable "Dark Mode" appearance on macOS (fanquake)
0e6de3aac added details about commit messages (Martin Erlandsson)
c11875c59 Add segwit address tests for importmulti (MeshCollider)
201451b1c Make getaddressinfo return solvability (MeshCollider)
1753d217e Add release notes for importmulti segwit change (MeshCollider)
353c06459 Fix typo in test_framework/blocktools (MeshCollider)
f6ed748cf Add SegWit support to importmulti with some ProcessImport cleanup (MeshCollider)
d8bf1071c Bugfix: RPC: Add address_type named param for createmultisig (Luke Dashjr)
15db77f4d Don't rely on locale dependent functions in base_blob<BITS>::SetHex(...) (uint256), DecodeBase58(...), ParseMoney(...) and ParseHex(...) (practicalswift)
36c8e6858 Various textual improvements in build docs (Martin Erlandsson)
fa511e8da Pass tx pool reference into CheckSequenceLocks (MarcoFalke)
fa78a2fc6 [tests] Test that nodes respond to getdata with notfound (MarcoFalke)
3387bb082 travis: avoid timeout without saving caches, also enable all qt (Chun Kuan Lee)
fbaccbf00 build: Fix Qt link order for Windows build (Chun Kuan Lee)
ed2e18398 Remove fs::relative call and fix listwalletdir tests (João Barbosa)
3be209d10 rpc: Always throw in getblockstats if -txindex is required (João Barbosa)
43719e0a3 [macOS] Remove DS_Store WindowBounds bytes object (Jonas Schnelli)
4dca7d0a9 appveyor: Enable multiwallet test (Chun Kuan Lee)
4ea77320c tests: add test case for loading copied wallet twice (Chun Kuan Lee)
2d796faf6 wallet: Fix duplicate fileid (Chun Kuan Lee)
96c509e4d show the progress of functional test (Isidoro Ghezzi)
8907df9e0 qa: Ensure wallet unload during walletpassphrase timeout (João Barbosa)
321decffa rpc: Fix wallet unload during walletpassphrase timeout (João Barbosa)
48439b3c1 Don't link SSL_LIBS with GUI unless BIP70 is enabled (James Hilliard)
fbb643d2a Add BIP70 deprecation warning (James Hilliard)
38b98507c qt: cleanup: Move BIP70 functions together in paymentserver (Wladimir J. van der Laan)
9dcf6c0df build: Add --disable-bip70 configure option (Wladimir J. van der Laan)
585b47cfe rpc: Prevent concurrent savemempool (João Barbosa)
2b91e42ec [docs] Add release note for removing getwitnessaddress (John Newbery)
ebec90ac9 [wallet] Remove deprecated addwitnessaddress RPC method (John Newbery)
07e3f585a [test] Remove deprecated addwitnessaddress from feature_segwit.py (John Newbery)
82f2fa03a [test] Remove deprecated addwitnessaddress from wallet_bumpfee.py (John Newbery)
9d7ee187a [test] Remove deprecated addwitnessaddress from p2p_compactblocks.py (John Newbery)
3cf77f0b3 [tests] Remove deprecated addwitnessaddress call from wallet_dump.py (John Newbery)
bdefc9705 [tests] Remove deprecated addwitnessaddress call from feature_nulldummy (John Newbery)
67d7d67cf [test] Fix flake8 warnings in tests (John Newbery)
69e7ee2dd Add GUARDED_BY(cs_wallet) for setExternalKeyPool, mapKeyMetadata, m_script_metadata and setLockedCoins (practicalswift)
37b2538c2 Add GUARDED_BY(cs_wallet) for encrypted_batch, nWalletMaxVersion, m_max_keypool_index and nOrderPosNext (practicalswift)
dee42927c wallet: Add Clang thread safety analysis annotations (practicalswift)
1c7e25db0 wallet: Add missing locks (practicalswift)
008990536 Add compile time checking for cs_main locks which we assert at run time (practicalswift)
d4d70eda3 Fix listreceivedbyaddress not taking address as a string (Eric Scrivner)
ab9aca2bd [rpc] add 'getnewaddress' hint to 'generatetoaddress' help text. (John Newbery)
c9f02955b [wallet] Deprecate the generate RPC method (John Newbery)
aab81720d [tests] Add generate method to TestNode (John Newbery)
c26920933 [tests] Small fixups before deprecating generate (John Newbery)
591820430 Removed explicit mention of storage requirement (squashed) (Martin Erlandsson)
8afb16687 Update documentation to incude origin information (Pieter Wuille)
ff37459ab Add tests for key origin support (Pieter Wuille)
2c6281f18 Add key origin support to descriptors (Pieter Wuille)
eeeaa2921 descriptors.md: Refer to descriptors as describing instead of matching (Russell Yanofsky)
eb4941256 doc/descriptors.md tweaks (Russell Yanofsky)
8640631eb docs: Document lint tests (Mason Simon)
97ddc6026 validation: Pass chainparams in AcceptToMemoryPoolWorker(...) (practicalswift)
fadffae17 Revert "Make qt wallet test compatible with qt4" (MarcoFalke)
1fb3c167c Add `doc/bitcoin-conf.md` (Hennadii Stepanov)
94e21c150 test: forward timeouts properly in send_blocks_and_test (James O'Beirne)
b6b991531 Textual improvements (Martin Erlandsson)
29ed2d64f Improve CAmount tests (Hennadii Stepanov)
a3197c529 Disable wallet and address book Qt tests on macOS minimal platform (Russell Yanofsky)
1f01fe025 bitcoin-tx: Use constant for n pubkeys check (Antoine Le Calvez)
369244f65 utils: Fix broken Windows filelock (Chun Kuan Lee)
bc60c615a Avoid 1 << 31 (UB) in calculation of SEQUENCE_LOCKTIME_DISABLE_FLAG (practicalswift)
7e18673f0 Fix typo (Kristaps Kaupe)
ca6d86c32 tests: Stop node before removing the notification file (Chun Kuan Lee)
d56a06893 docs: Add release notes for listwalletdir RPC (João Barbosa)
0cb3cad16 qa: Add tests for listwalletdir RPC (João Barbosa)
cc3377360 rpc: Add listwalletdir RPC (João Barbosa)
d1b03b8e5 interfaces: Add getWalletDir and listWalletDir to Node (João Barbosa)
fc4db35bf wallet: Add ListWalletDir utility (João Barbosa)
96f6dc9fc Avoid triggering undefined behaviour in base_uint<BITS>::bits() (practicalswift)
2ab9140c9 Add tooltips for both datadir and blocksdir (Hennadii Stepanov)
304570450 Add "Blocksdir" to Debug window (Hennadii Stepanov)
b0510d78a Set C locale for amountWidget (Hennadii Stepanov)
2d471636e wallet: Remove trailing separators from -walletdir arg (Pierre Rochard)
ea3009ee9 wallet: Add walletdir arg unit tests (Pierre Rochard)
43c7fbb1e Make MSVC compiler read the source code using utf-8 (Chun Kuan Lee)
f86a571ed tests: Add test case for std::ios_base::ate (Chun Kuan Lee)
a554cc901 Move boost/std fstream to fsbridge (Chun Kuan Lee)
86eb3b3f1 utils: Add fsbridge fstream function wrapper (Chun Kuan Lee)
d56202707 [doc] getblocktemplate: use SegWit in example (Sjors Provoost)
081cc02a9 Fix QCompleter popup regression (Hennadii Stepanov)
ee0b7c4e8 build: Pin to specific versions of Python packages we install from PyPI in Travis (practicalswift)
c32cf6a0f Add ignored word: mut (practicalswift)
4ae50daaa Revert "qa: Fix codespell error and have lint-spelling error instead of warn" (practicalswift)
032488e6e Move SocketHandler logic to private method. (Patrick Strateman)
2af9cff11 Move InactivityCheck logic to private method. (Patrick Strateman)
7479b63d9 Move DisconnectNodes logic to private method. (Patrick Strateman)
edb5350c3 Move NotifyNumConnectionsChanged logic to private method. (Patrick Strateman)
7d173c4cd qt: Revert "Force TLS1.0+ for SSL connections" (Tim Ruffing)
36323e2ac Clean systray icon menu for -disablewallet mode (Hennadii Stepanov)
2f6b466ae Stop requiring imported pubkey to sign non-PKH schemes (Pieter Wuille)
b8edb9810 [rpc] Descriptions: Textual consistency fixes (Jon Layton)
a48e44bd4 Fix CLEAN_BITCOIN_TEST to remove .log files for all BITCOIN_TESTS files (James O'Beirne)
3e9f6c821 Add missing locks and locking annotations for CAddrMan (practicalswift)
f149e31ea depends: qt: avoid system harfbuzz and bz2 (Cory Fields)
854c85ae9 test: allow arguments to be forwarded to flake8 in lint-python.sh (James O'Beirne)
3f5ac2720 Include some files currently missed by 'make distclean'. (murrayn)
3b706212a doc: RPC documentation (Karel Bílek)
0bd64dc6d Fix macOS files description (Hennadii Stepanov)
faa4043c6 qa: Run more tests with wallet disabled (MarcoFalke)
62c304ea4 tests: Allow closed http server in assert_start_raises_init_error (Chun Kuan Lee)
59a50c217 appveyor: trivial build cache modifications (Chun Kuan Lee)
42a995ae4 [tests] Remove rpc_zmq.py (John Newbery)
b09c81454 Don't access out of bounds array entry array[sizeof(array)] (Ben Woosley)
64937fda6 [docs] path to descriptors.md fixed (Damian Mee)
380c84321 utils: Convert Windows args to utf-8 string (Chun Kuan Lee)
4a9f064ea Fix typos (Dimitris Apostolou)
86eddd466 doc: miss install (poiuty)
d10f2cd7d travis: set codespell version to avoid breakage (MarcoFalke)
fad95e8da doc: Split build linux dependencies (MarcoFalke)
000000901 doc: Split depends installation instructions per arch (MarcoFalke)
ff94da788 tests: Make appveyor run with --usecli (practicalswift)
db0183936 test: Add missing call to skip_if_no_cli() (practicalswift)
1f59c6f3e doc: Remove "temporary file" notice from 0.17.0 release notes (Wladimir J. van der Laan)
5aaf1a047 doc: Add historical release notes for 0.17.0 (Wladimir J. van der Laan)
d813266db [gitian] use versioned unsigned tarballs instead of generically named ones (Andrew Chow)
fa69ac761 doxygen: Fix member comments (MarcoFalke)
430bf6c7a depends: fix bitcoin-qt back-compat with older freetype versions at runtime (Cory Fields)
0809e68a9 doc: Add historical release notes for 0.14.3 and 0.15.2 (Wladimir J. van der Laan)
fae9e84cb doc: Add GitHub pr template (MarcoFalke)
c7b3e487f tests: exclude all tests with difference parameters (Chun Kuan Lee)
fa84723e7 amount: Move CAmount CENT to unit test header (MarcoFalke)
9c5af58d5 Consolidate redundant implementations of ParseHashStr (Ben Woosley)
66b3fc543 Skip stale tip checking if outbound connections are off or if reindexing. (Gregory Maxwell)
a2a04a5ab Bugfix: Only run bitcoin-tx tests when bitcoin-tx is enabled (Luke Dashjr)
92af71cea configure: Make it possible to build only one of bitcoin-cli or bitcoin-tx (Luke Dashjr)
e46023287 Document fixed attribute behavior in critical test framework classes. (Justin Turner Arthur)
17b42f412 Check for specific tx acceptance failures based on script signature (Justin Turner Arthur)
3a4449e9a Strictly enforce instance attrs in critical functional test classes. (Justin Turner Arthur)
1d0ce94a5 Fix for incorrect version attr set on functional test segwit block. (Justin Turner Arthur)
ba923e32a test: Fix broken segwit test (practicalswift)
7ac911afe [docs] Add release notes for removing `-usehd` (John Newbery)
25548b295 [wallet] Remove -usehd (John Newbery)
20442f617 [wallet] remove redundand restart node (gustavonalle)
db1580566 [wallet] Ensure wallet is unlocked before signing (gustavonalle)
2c3eade70 Make fs::path::string() always return utf-8 string (Chun Kuan Lee)
fa6b30c40 lcov: filter /usr/lib/ from coverage reports (MarcoFalke)
ff40357da AppVeyor: Move AppVeyor YAML to dot-file-style YAML (Mitchell Cash)
67654b640 tests: write the notification to different files to avoid race condition (Chun Kuan Lee)
6fa901fb4 Don't edit Chainparams after initialization (Jorge Timón)
980b38f8a MOVEONLY: Move versionbits info out of versionbits.o (Jorge Timón)
661ac15a4 appveyor: Run functional tests on appveyor (Chun Kuan Lee)
2148c36b6 tests: Make it possible to run functional tests on Windows (Chun Kuan Lee)
5eb20f81d Consistently use ParseHashV to validate hash inputs in rpc (Ben Woosley)
1eb9a9b52 [RPC] Remove warning for removed estimatefee RPC (John Newbery)
30973e984 [REST] improve performance for JSON calls (Antoine Le Calvez)
a23a7f60a wallet: Avoid potential use of unitialized value bnb_used in CWallet::CreateTransaction(...) (practicalswift)
b6718e373 tests: Use MakeUnique to construct objects owned by unique_ptrs (practicalswift)
3ccfa34b3 convert C-style (void) parameter lists to C++ style () (Arvid Norberg)
fa910e430 init: Remove deprecated args from hidden args (MarcoFalke)
52beb9ed8 Add autogen.sh in ARM Cross-compilation (Walter)
a2eb6f540 [rpc] Add getnodeaddresses RPC command (chris-belcher)
fd5c95cc4 doc: Add historical release notes for 0.16.3 (Wladimir J. van der Laan)
9b4a36eff [qa] Test for duplicate inputs within a transaction (Suhas Daftuar)
b8f801964 Fix crash bug with duplicate inputs within a transaction (Suhas Daftuar)
0ca4c8b3c Changed functional tests which do not require wallets to run without (sanket1729)
f1bd03eb0 [depends, zmq, doc] upgrade zeromq to 4.2.5 and avoid deprecated zeromq api functions (mruddy)
be54f42e5 use integer division instead of double conversion and multiplication for computing amounts (Arvid Norberg)
Pull request description:
Currently this catches up until Core commit f617e05c38 and has everything working except the `p2p_invalid_messages` unit test that gets some updates in later upstream commits.
I'm planning to continue to catch up to 519b0bc5dc next, which is the merge-base between upstream master and upstream v0.18.0.
Fixes#532.
Tree-SHA512: a8da8fe1c03d3317fc42d610b2203b7b84ac403ecdff88cf54be525c7a94b0b366ae8741b2652274152f9da657631c221bf2540b79c9c121b5b1e74facd197c1
Apparently my upstream checkpoint was in the middle of a series of
commits by ianofsky separating wallet from the main code. This means
that I have to add this main lock which will be replaced by the
locked_chain interface in a subsequence catchup.
