Commit graph

18827 commits

Author SHA1 Message Date
Gregory Sanders
2a50ec1d5a Liquid gitian builds: move more to liquid name 2019-04-22 15:46:26 -04:00
Steven Roose
b89a64c36b
Merge #591: Add testdummy deployment for versionbits to squash warnings
88b380211 Add testdummy deployment for versionbits to squash warnings (Gregory Sanders)

Pull request description:

  liquidv1 has a testdummy deployment like other common chains, sync this up.

Tree-SHA512: a4dfccc284e11bc3a69463fc553138c1b8d560d2bf9539679c815acea7754aca4fbd78ec3d23dbccd825c59da7cce8044d42b1dfbc2bff78c332556afdbaa7f3
2019-04-22 12:31:34 +01:00
Steven Roose
59def74d27
Merge #588: CreateTransaction: Place blinding pubkey into nNonce in case of fundraw
7fd6b88c9 claimpegins should arrive in witness destinations (Gregory Sanders)
a4a051e75 Add tests for fundrawtransaction placing back blinding keys properly (Gregory Sanders)
48958a6db CreateTransaction: Place blinding pubkey into nNonce in case of fundraw (Gregory Sanders)
2e6191d73 QA: Hack around no issuance an non-witness tx bug issue#473 (Gregory Sanders)

Pull request description:

  Currently any fundrawtransaction call will result in unblinded change output. Automated flow isn't effected by this bug.

Tree-SHA512: ee09a58bd8d5ac35f8d090a0e8928efebb7f9d8e886105bff7188ad4983406d53e4693b46b1e4f70ba76d3e06a420bd778b4c879de183d02d7ec3c7ccbac3f8e
2019-04-22 10:41:53 +01:00
Steven Roose
346c54401a
Merge #587: CreateTransaction should still print blinded tx info during fundraw etc
dc1ede8f2 CreateTransaction should still print blinded tx info during fundraw etc (Gregory Sanders)

Pull request description:

  This should result in better diagnosing of `fundrawtransaction` behavior in case of bugs with blinding.

Tree-SHA512: 4bbd3d58f24dbb0d21fe150154c55eeb617734a2edb6211ff743448d744367e089ee8196aa06ec6fb9fb38e45ca5e1bb4c490dcb9fdda75a288fbec2112b1078
2019-04-22 10:03:52 +01:00
Gregory Sanders
88b3802114 Add testdummy deployment for versionbits to squash warnings 2019-04-20 15:19:36 -04:00
Gregory Sanders
7fd6b88c97 claimpegins should arrive in witness destinations 2019-04-19 07:39:32 -04:00
Gregory Sanders
a4a051e756 Add tests for fundrawtransaction placing back blinding keys properly 2019-04-19 07:39:32 -04:00
Gregory Sanders
48958a6db5 CreateTransaction: Place blinding pubkey into nNonce in case of fundraw 2019-04-19 07:39:32 -04:00
Gregory Sanders
2e6191d73a QA: Hack around no issuance an non-witness tx bug issue#473 2019-04-19 07:39:32 -04:00
Gregory Sanders
dc1ede8f20 CreateTransaction should still print blinded tx info during fundraw etc 2019-04-18 16:03:31 -04:00
Gregory Sanders
5735322a06
Merge #574: configure option --enable-liquid for default liquidv1 chain
ff12bf7 QT: --enable-liquid needs to use different QAPP name for QSettings (Gregory Sanders)
f475780 QT: WalletModel should always check for balance changes once (Gregory Sanders)
93e2660 QT: dummy address needs fully valid pubkey (Gregory Sanders)
c227c65 QT: Cache the blinded destination values on transactions we create, like -cli (Gregory Sanders)
5622a83 QT: remove GetAmounts calls or put behind bitcoind mode only (Gregory Sanders)
17229bf QT: Add bracket to not reassign values on non-tx (Gregory Sanders)
88c256f Split out liquid gitian build descriptors (Gregory Sanders)
7bd0667 Change gitian defaults back to elements, leave commented out lines as switch (Gregory Sanders)
6d6ddc5 Rename binaries to liquid naming at end of gitian process (Gregory Sanders)
aa2af38 --enable-liquid: liquid.conf and liquid.pid (Gregory Sanders)
3b1ca17 --enable-liquid: change default datadir to .liquid (Gregory Sanders)
1f67fec --enable-liquid for gitian builds (Gregory Sanders)
1fdc059 Add travis build for --enable-liquid (Gregory Sanders)
7eea59a configure option --enable-liquid for default liquidv1 chain (Gregory Sanders)

Pull request description:

  The only behavior it modifies is that the default chain becomes `liquidv1`. Also added a Travis test for coverage and adapted a unit test, and enabled this mode for gitian descriptors.

Tree-SHA512: 9a19267a51ee7a8906b6a8af9c511a4838ec529c5ea2873de215eb849111d2d2380679b524e7198f53606810b47cd85ef46a8fc5816c86e78ebedd8c30de0da7
2019-04-18 13:19:59 -04:00
Gregory Sanders
28ae91d7de
Merge #586: RawFillBlinds needs to push blank pubkeys if output it already blinded
b08fcb1 RawFillBlinds needs to push blank pubkeys if output it already blinded (Gregory Sanders)

Pull request description:

Tree-SHA512: 7b6f718f00d01cfdfae698c89c7c1ba5d09c7624a27cce4bc1a3d6ea9ceebd03684da1c867fec6ac22f4520e0afaa2bd934bfda979402cc3364750b1dd98af70
2019-04-18 13:17:11 -04:00
Gregory Sanders
ff12bf7250 QT: --enable-liquid needs to use different QAPP name for QSettings 2019-04-18 12:06:28 -04:00
Gregory Sanders
b08fcb1f9a RawFillBlinds needs to push blank pubkeys if output it already blinded 2019-04-18 10:52:22 -04:00
Gregory Sanders
f47578083e QT: WalletModel should always check for balance changes once 2019-04-17 15:35:27 -04:00
Gregory Sanders
93e26608c2 QT: dummy address needs fully valid pubkey 2019-04-17 15:35:27 -04:00
Gregory Sanders
c227c65a13 QT: Cache the blinded destination values on transactions we create, like -cli 2019-04-17 14:23:23 -04:00
Gregory Sanders
5622a838c2 QT: remove GetAmounts calls or put behind bitcoind mode only 2019-04-17 14:22:57 -04:00
Gregory Sanders
17229bfb8c QT: Add bracket to not reassign values on non-tx 2019-04-17 11:16:17 -04:00
Gregory Sanders
88c256f751 Split out liquid gitian build descriptors 2019-04-17 10:44:40 -04:00
Gregory Sanders
7bd066705c Change gitian defaults back to elements, leave commented out lines as switch 2019-04-16 12:43:59 -04:00
Gregory Sanders
6d6ddc55b3 Rename binaries to liquid naming at end of gitian process 2019-04-16 12:36:39 -04:00
Gregory Sanders
aa2af38715 --enable-liquid: liquid.conf and liquid.pid 2019-04-15 16:59:49 -04:00
Gregory Sanders
3b1ca174d7 --enable-liquid: change default datadir to .liquid 2019-04-15 16:59:49 -04:00
Steven Roose
aea8fa2a82
Merge #575: mempool_package: make sure small UTXOs aren't selected for spending c…
fb184c830 mempool_package: make sure small UTXOs aren't selected for spending chain (Gregory Sanders)

Pull request description:

  …hain

  Was causing random errors depending on the response of listunspent, which may be including smaller UTXOs for whatever reason.

Tree-SHA512: 1a083026f67131374478cc70abd41a3c4918f7867d0ede75a3ddf331e485ed11bc8a46477a7ecf733faa40130529f2b83f7b1a8a56d8434a3908a0592cdd61ef
2019-04-15 16:06:28 +01:00
Gregory Sanders
fb184c8303 mempool_package: make sure small UTXOs aren't selected for spending chain 2019-04-15 08:45:52 -04:00
Steven Roose
8c02193a66
Merge #577: Add a couple comments on (re)issueasset to let users know about raw v…
1cccb6ebb Add a couple comments on (re)issueasset to let users know about raw versions (Gregory Sanders)

Pull request description:

  …ersions

Tree-SHA512: e431d2efffd18a3a606c179b8bc44f61f4fb04a3812725c670c2d119c92fc89246e63f1b2f6f035f0eeb7c83fbebe225cf219898f74dd96de4494aa426832fed
2019-04-15 10:52:05 +01:00
Gregory Sanders
1cccb6ebb8 Add a couple comments on (re)issueasset to let users know about raw versions 2019-04-13 14:59:03 -04:00
Gregory Sanders
1f67fec0e9 --enable-liquid for gitian builds 2019-04-12 17:08:25 -04:00
Gregory Sanders
1fdc0595d3 Add travis build for --enable-liquid 2019-04-12 13:27:01 -04:00
Gregory Sanders
7eea59a2ca configure option --enable-liquid for default liquidv1 chain 2019-04-12 13:27:01 -04:00
Gregory Sanders
a32cd1d363
Merge #573: Add issuance serialization in python, tighten up DoS rules
d70367b Add broken python serialization to always give issuance input, test for decode failure (Gregory Sanders)
2cb47d1 Disallow coinbase output witness data, since outputs are explicit anyways (Gregory Sanders)
8b2e885 Test for block-blinding by txinwit-overstuffed block (Gregory Sanders)
789d4b9 Disallow output witness data in coinbase transactions (Gregory Sanders)
e64324e Test coinbase witness data consensus rules (Gregory Sanders)
ac98ca4 python test support for issuance and peg-in serialization and data (Gregory Sanders)
8140a87 Reject unneeded pegin witness by policy (Gregory Sanders)
97356e8 test_framework: Fix CTxInWitness.is_null with pegin_witness (Gregory Sanders)
2309508 feature_fedpeg.py: change sidechain's parent bech32 prefix to match (Gregory Sanders)

Pull request description:

  resolves https://github.com/ElementsProject/elements/issues/530

Tree-SHA512: 89d78bfe512ba573304e0033798ed1de27decfbdbda78ed158ce1ee205e9f57054bb3c53d7e1e8aba9da2b865c33b9852551b0d4cc1c3c807a0b8dbae130ee86
2019-04-12 13:23:17 -04:00
Gregory Sanders
34aa9faf3a
Merge #572: Fix some const clang complaints
3ef0e6d Fix some const clang complaints (Gregory Sanders)

Pull request description:

  Resolves https://github.com/ElementsProject/elements/issues/571

Tree-SHA512: c2dd4287d22678da570f0a9c053929c373e7377b1e1f8eff12e3df4d43cfa6c21d5be1d45c44db76c5686ea40c925c94250ed245451174cf0190b6e58cca9268
2019-04-12 12:48:28 -04:00
Gregory Sanders
d70367bcf8 Add broken python serialization to always give issuance input, test for decode failure 2019-04-12 11:50:01 -04:00
Gregory Sanders
2cb47d1705 Disallow coinbase output witness data, since outputs are explicit anyways 2019-04-12 11:50:01 -04:00
Gregory Sanders
8b2e8859d6 Test for block-blinding by txinwit-overstuffed block 2019-04-12 11:50:01 -04:00
Gregory Sanders
789d4b97f7 Disallow output witness data in coinbase transactions 2019-04-12 11:50:01 -04:00
Gregory Sanders
e64324e3ec Test coinbase witness data consensus rules 2019-04-12 11:50:01 -04:00
Gregory Sanders
ac98ca4eb1 python test support for issuance and peg-in serialization and data 2019-04-12 11:50:01 -04:00
Gregory Sanders
8140a87dec Reject unneeded pegin witness by policy 2019-04-12 11:50:01 -04:00
Gregory Sanders
97356e8c14 test_framework: Fix CTxInWitness.is_null with pegin_witness 2019-04-12 11:50:01 -04:00
Gregory Sanders
23095087f6 feature_fedpeg.py: change sidechain's parent bech32 prefix to match 2019-04-12 11:50:01 -04:00
Steven Roose
12387b2348
Merge #569: Qt port from Liquid-qt
003fb1933 QT: Carbon copy 0.14-based transaction accounting (Gregory Sanders)
633316632 QT: get fee directly from elementsmode transactions (Gregory Sanders)
a337b7634 QT: Fixup OSX build (Gregory Sanders)
962690743 QT: Disable URI unit tests since unused (Gregory Sanders)
95d098197 QT: Fix QT to work in non-elementsmode (Gregory Sanders)
027aeef83 QT: Remove ^M and trailing whitespace (Gregory Sanders)
c299dd24a QT: fix qt linter (Gregory Sanders)
8adf59159 QT include linting (Gregory Sanders)
ab21387c8 QT: Always return blinded address (Gregory Sanders)
dbac2afd0 QT: Enter a s/Bitcoin/Liquid/ address (Gregory Sanders)
1dde8a7ff Update blech32 checkbox text (Gregory Sanders)
7108ab76e Add unix build notes for Elements-QT dependencies (Gregory Sanders)
967ed8385 f'init: If bitcoind is unreachable, explain where the user can get it' (Gregory Sanders)
acf243683 f'GUI: Pre-render amount for transaction notifications so asset is correct' (Gregory Sanders)
d51b9edcd f'GUI: Display label rather than address on popups' (Gregory Sanders)
f7f5bb7cb f'GUI: Disable Subtract fee from amount' (Gregory Sanders)
084a2fdc9 f'GUI: Make liquidv1 the' (Gregory Sanders)
0aff67508 f'GUI: Add liquidv1 network style' (Gregory Sanders)
cbf93b9b6 Added liquid.conf template (Daniel Olaya)
1a654f449 fix logo position and size on retina displays (Riccardo Casatta)
3241af9d4 GUI: Adjust recommended number of blocks confirmed to 2 (Luke Dashjr)
3779ae290 Bugfix: GUI: Re-enable Show/Remove buttons on Receive tab (Luke Dashjr)
f96392040 GUI: Pre-render amount for transaction notifications so asset is correct (Luke Dashjr)
3bedac45a GUI: Drop "(GUI node for Bitcoin)" from program description (Luke Dashjr)
33f54fb53 GUI: Remove unnecessary references to Bitcoin (Luke Dashjr)
be7527f50 GUI: Replace "Bitcoin" with "Liquid" in appropriate strings (Luke Dashjr)
f62c0d3bf GUI: Replace "Bitcoin" with "Liquid" in appropriate strings (Luke Dashjr)
737e99a35 GUI: Make liquidv1 the "normal title bar" style (Luke Dashjr)
d82eee9d2 GUI: Add liquidv1 network style (Luke Dashjr)
ce752c0bd GUI: Remove access to unported "transaction details" display (Luke Dashjr)
0a3f58905 init: If bitcoind is unreachable, explain where the user can get it (Luke Dashjr)
680265806 GUI: Adjust blockchain and chainstate sizes in Intro (Luke Dashjr)
d522775b8 Bugfix: GUI: Ensure negative symbol is before whole number in GUIUtil::formatAssetAmount (Luke Dashjr)
36ebb131d GUI: Disable "Subtract fee from amount" checkbox when a non-pegged asset is selected (Luke Dashjr)
1f0b6886b GUI: Emit BitcoinAmountField::valueChanged when unit changes even if the current value is invalid (Luke Dashjr)
954f7758a Bugfix: GUI: Receive: Don't try to update label for non-existent Amount column (Luke Dashjr)
bbb5a4cc3 Gitian: Remove libconsensus from Windows/macOS builds (Luke Dashjr)
08aea0ecc configure: Rename binary to elements name (Gregory Sanders)
795f7f1a5 Gitian: Use newer librsvg so Liquid logo renders correctly (Luke Dashjr)
4c678d1e3 GUI: Receive: Eliminate "Copy URI" from receive request dialog (Luke Dashjr)
9ee46291d GUI: Add "L-" prefix to Bitcoin units (Luke Dashjr)
6879be703 GUI: Liquid branding (Luke Dashjr)
3f1764afd Generate bitcoin_testnet.ico using ImageMagick (Luke Dashjr)
f60462d45 Rather than clean generated icons, plan to distribute them (Luke Dashjr)
d389515e8 Render NSIS wizard sidebar image (Luke Dashjr)
ff6a0a103 Render some icons when possible (Luke Dashjr)
ec8e73a4d Make a modified copy of qrc file for VPATH builds (Luke Dashjr)
06b30cfad Travis: Include dependencies for building icons (Luke Dashjr)
4fa10fe4e gitian: Dependencies for rendering icons (Luke Dashjr)
335149944 Reuse Windows ICO for Windows installer (Luke Dashjr)
749e0a83c clientversion: Fix CLIENT_NAME to "Elements Core" (Luke Dashjr)
20bf9c5cd GUI: Disable coin control (non-functional) (Luke Dashjr)
82dfd3ff1 GUI: Receive: Eliminate URI, and make QR code of just the address (Luke Dashjr)
273aa76f8 GUI: Receive: Split up long addresses across multiple lines, in QR code image (Luke Dashjr)
25600f90d GUI: Receive: Remove URI-specific parameters for now (Luke Dashjr)
20479e4ad GUI: Receive: Replace "Copy URI" with "Copy address" (Luke Dashjr)
d4d45b6f0 GUI: Use CT address for examples (Luke Dashjr)
0d11cd0de GUI: Transactions: Remove "to yourself" filter, no longer applicable (Luke Dashjr)
66ac3e62e GUI: Move the "Recent Transactions" view below "Balances" (Luke Dashjr)
6ab7bcc4e Bugfix: GUI: Overview: Fix hiding of immature when balances are zero (Gregory Sanders)
8048a6d8b QT: have output amounts propagated for subtractfeefromoutput logic (Gregory Sanders)
2a334b73e Slightly smarter change key vector padding (Gregory Sanders)
79e0cb74f GUI: Support for sending assets (Luke Dashjr)
f4d5552f6 GUI: Clone SendCoinsRecipient to SendAssetsRecipient (Luke Dashjr)
70458f6f9 Pad change keys for wallet interface pending txs (Gregory Sanders)
466b3d03f CAmountMap::operator! to check if empty (Luke Dashjr)
af726c7c3 GUI: BitcoinAmountField: Limit issued assets to 21M (Luke Dashjr)
2ebae1ab8 GUI: SendCoinsEntry: Propagate asset types available to amount field (Luke Dashjr)
a163be0ae GUI: WalletModel: Track asset type collection (Luke Dashjr)
7f00087b5 GUI: BitcoinAmountField: Allow changing allowed assets after construction (Luke Dashjr)
3e669cd31 GUI: BitcoinAmountField: Allow code to set assets not in allowed_assets (Luke Dashjr)
2c75c4441 GUI: BitcoinAmountField: Support for non-bitcoin assets (Luke Dashjr)
a1a884855 GUI: GUIUtil::parseAssetAmount abstraction (Luke Dashjr)
881862c9c bugfix: issuance to self not a debit (Gregory Sanders)
047799cb1 CAsset: GetIdentifier to get label or hex id (Luke Dashjr)
d81c9f7b3 AmountSpinBox: Resolve singleStep default when making steps (Luke Dashjr)
295361348 GUI: Option to remove asset name for GUIUtil::formatAssetAmount (Luke Dashjr)
85f0ad80d replace bitcoin-qt with elements-qt (Lawrence Nahum)
f027ca0c6 GUI: Always include bitcoins in formatMultiAssetAmount (Luke Dashjr)
f5fb840cd GUI: Overview: Show all assets in balances (Luke Dashjr)
6342d80d7 GUI: Add GUIUtil::formatMultiAssetAmount to handle a CAmountMap (Luke Dashjr)
988ed5eff GUI: Abstract asset+amount formatting into new GUIUtil::formatAssetAmount (Luke Dashjr)
89275ebf2 GUI: TransactionRecord: Special-case the common scenario where assets are simply issued to myself (Luke Dashjr)
906cc4c40 Wallet: GetIssuanceAssets to get CAmountMap for issuances (Luke Dashjr)
4ea8f8827 GUI: TransactionRecord: When time/index/etc match, sort fee, issuance, send, then receive (Luke Dashjr)
51e789722 GUI: TransactionRecord: Add asset issuance record type (Luke Dashjr)
e6b3676b3 Wallet: GetIssuanceAssets to just get CAssets for issuances (Gregory Sanders)
2bcd24313 GUI: Overview: Use formatted amount text from TransactionTableModel (Luke Dashjr)
eef551a58 GUI: TransactionTableModel: Remove bitcoin unit from Amount column header (Luke Dashjr)
19c87c0ae GUI: TransactionTableModel: Include unit name with formatted amount (Luke Dashjr)
a582fe03e GUI: TransactionRecord: Turn non-bitcoin fees into entries (Luke Dashjr)
ef2f717e6 GUI: TransactionRecord: Add asset field (Gregory Sanders)
060ad2f56 GUI: TransactionRecord: Collapse credit+debit fields to just amount (Luke Dashjr)
0aeab14f7 GUI: Ignore explicit fee output when determining if a transaction is send-to-self (Luke Dashjr)
1655947c1 gui: Alternate row background based on txid (João Barbosa)
3edcdf8f0 gui: Add transaction record type Fee (João Barbosa)
41c8d4c89 gui: Avoid TransactionRecord instance for IsMine outputs (João Barbosa)

Pull request description:

  Splash page is always Liquid-themed like before. Pegged asset is assumed to be `L-BTC`. Default network for QT is still `elementsregtest`. Do we want it to be `liquidv1`?

  resolves https://github.com/ElementsProject/elements/issues/528

Tree-SHA512: cd7c07262195c344185f5b7bd779985cf7ee26f0fdf1fa105a4ce93b51cbbd83cc78884e3ed711d884697a48904c2d76647eba76509f6a22210b75f6fcdc13c5
2019-04-12 15:56:59 +01:00
Steven Roose
6c4f6efb64
Merge #563: Some more standard pegout testing
30eb323e9 ensure pak wallet is returning right kind of addresses (Gregory Sanders)
9e56c87ec have validateaddress give useful parent chain addr info (Gregory Sanders)
894d76e7c test all single-key pegout address types (Gregory Sanders)
40a62a151 DestinationEncoder: don't assert when a parent destination is unblinded (Gregory Sanders)

Pull request description:

  Added more utility to `validateaddress` for parent addresses by returning an additional object `parent_address_info`, then used it to enhance various tests.

Tree-SHA512: 941ef1dc8b7469c3274a50907ea788fe520398809d5c4ac901ef057dfa688f63b45f0be298de14c07c250015d02de8f2f4687e430da121fba759e3879823947f
2019-04-12 15:34:40 +01:00
Gregory Sanders
003fb1933e QT: Carbon copy 0.14-based transaction accounting 2019-04-11 15:38:35 -04:00
Steven Roose
8fd8a45011
Merge #568: Adapt Elements default adress prefix bytes to elements-0.14 style
91294ca01 Adapt Elements default adress prefix bytes to elements-0.14 style (Gregory Sanders)
410d5fa08 sendtomainchain_base should be decoding parent destination (Gregory Sanders)

Pull request description:

  Also chose `ert` as bech32 hrp, just to make it distinct.

  Clustered the various address parameters for ease of the reader.

  resolves https://github.com/ElementsProject/elements/issues/567

Tree-SHA512: aae4b31b0c5ead9801dad13a50ddfc934216df783d6294bb4e2ae515bba27960a9643ccaae87a60c9637c44aeb6d4b0329eeb70846b07e6e88e9133edcd74315
2019-04-11 17:25:33 +01:00
Gregory Sanders
6333166320 QT: get fee directly from elementsmode transactions 2019-04-11 07:34:44 -04:00
Gregory Sanders
91294ca01a Adapt Elements default adress prefix bytes to elements-0.14 style 2019-04-10 16:08:39 -04:00
Gregory Sanders
a337b76346 QT: Fixup OSX build 2019-04-10 15:01:50 -04:00
Gregory Sanders
410d5fa083 sendtomainchain_base should be decoding parent destination 2019-04-10 14:18:48 -04:00