Commit graph

42449 commits

Author SHA1 Message Date
Byron Hambly
0876350fe6
test: fix for intermittent issue in wallet_resendwallettransactions.py
FIXME investigate why this call to `send` would sometimes result in a
"not BIP 125 replaceable" transaction
2025-01-06 11:28:00 +02:00
Byron Hambly
625932b53a
coinselection: fix assert error in getselectionwaste
fix for intermittent assertion error in getselectionwaste
introduced in f46275d011 as part of merge
for bitcoin/bitcoin#25647

the assertion would trigger in a fundrawtransaction call in
feature_confidential_transactions.py where the transaction inputs
included a non-policy asset.

during the loop in getselectionwaste, if the non-policy input waste was
calculated first the assertion would be triggered because
selected_effective_value has not yet met the selection target, because
non-policy coins have 0 effective value

the fix changed the assertion to an if statement, only adding to the
waste metric when selected_effective_value meets the target.
2024-12-20 12:35:09 +02:00
Byron Hambly
f3ccfc53ba
compile: clean up warnings for unused 2024-12-20 11:46:24 +02:00
Byron Hambly
72cac1605e
doc: clean up some fixme comments 2024-12-20 11:45:04 +02:00
Byron Hambly
a6f8dc6a86
tidy: fixes for clang tidy ci job 2024-12-04 14:16:45 +02:00
Byron Hambly
8499b13762
lint: fix lint issues 2024-12-03 14:02:33 +02:00
Byron Hambly
b4b6a0705e net_processing: fix for merge of bitcoin/bitcoin#25717 where have_headers_sync was unused 2024-12-03 10:06:38 +02:00
Byron Hambly
7fde338945
Merge 60cf64e070 into merged_master (Elements PR #1374)
Some refactoring around the pegged asset name during this merge, please
check in the GUI.
2024-12-03 09:15:20 +02:00
Byron Hambly
70c819546f Merge aa2420cd18 into merged_master (Elements PR #1368) 2024-12-02 09:20:42 +02:00
Byron Hambly
d78604da4c Merge 2534141e19 into merged_master (Elements PR ElementsProject/elements#1219) 2024-12-02 08:51:39 +02:00
Byron Hambly
bf18cb4ee3 Merge 6e11e20340 into merged_master (Bitcoin PR bitcoin/bitcoin#26121) 2024-11-27 11:44:43 +02:00
Byron Hambly
fb832dd2ca Merge 9f650062fc into merged_master (Bitcoin PR bitcoin/bitcoin#26005) 2024-11-27 11:36:17 +02:00
Byron Hambly
c3fa0dddac Merge 55e1deb745 into merged_master (Bitcoin PR bitcoin/bitcoin#25540) 2024-11-27 11:26:08 +02:00
Byron Hambly
24ef305cd0 Merge a9ffebddbe into merged_master (Bitcoin PR bitcoin/bitcoin#26075) 2024-11-27 11:25:12 +02:00
Byron Hambly
ee7ac3f6b6 Merge a688ff9046 into merged_master (Bitcoin PR bitcoin/bitcoin#26087) 2024-11-27 11:25:01 +02:00
Byron Hambly
e3d3f8cdb2 Merge 9fefd00d8e into merged_master (Bitcoin PR bitcoin/bitcoin#26107) 2024-11-27 11:24:26 +02:00
Byron Hambly
082dc1e933 Merge 3d892d8695 into merged_master (Bitcoin PR bitcoin/bitcoin#26086) 2024-11-27 11:15:58 +02:00
Byron Hambly
e66c56af15 Merge 5a724d1161 into merged_master (Bitcoin PR bitcoin/bitcoin#25918) 2024-11-27 11:14:53 +02:00
Byron Hambly
d02e816fb6 Merge 5eb9781763 into merged_master (Bitcoin PR bitcoin/bitcoin#25971) 2024-11-27 11:04:06 +02:00
Byron Hambly
09e2cad10f Merge 08785aa75b into merged_master (Bitcoin PR bitcoin/bitcoin#25499) 2024-11-27 10:47:04 +02:00
Byron Hambly
222570ec21 Merge 1d6c605165 into merged_master (Bitcoin PR bitcoin/bitcoin#26057) 2024-11-27 10:47:00 +02:00
Byron Hambly
0cfc7e07a1 Merge 2530a24689 into merged_master (Bitcoin PR bitcoin/bitcoin#26105) 2024-11-27 10:46:49 +02:00
Byron Hambly
b3cd991947 Merge 19526d937f into merged_master (Bitcoin PR bitcoin/bitcoin#26065) 2024-11-27 10:46:41 +02:00
Byron Hambly
b29ae90f29 Merge 27351fb915 into merged_master (Bitcoin PR bitcoin/bitcoin#26093) 2024-11-27 10:46:37 +02:00
Byron Hambly
fc8637248f Merge a56876e6b9 into merged_master (Bitcoin PR bitcoin/bitcoin#26024) 2024-11-27 10:39:27 +02:00
Byron Hambly
21d8cd57f3 Merge 96f1b2d34f into merged_master (Bitcoin PR bitcoin/bitcoin#26091) 2024-11-26 20:18:09 +02:00
Byron Hambly
9e852275f6 Merge f332c4f64d into merged_master (Bitcoin PR bitcoin/bitcoin#26090) 2024-11-26 20:18:04 +02:00
Byron Hambly
a338b10cb0 Merge 20f03a5aed into merged_master (Bitcoin PR bitcoin/bitcoin#26089) 2024-11-26 20:17:59 +02:00
Byron Hambly
eaf7efce1c Merge 718304d222 into merged_master (Bitcoin PR bitcoin/bitcoin#26084) 2024-11-26 20:17:51 +02:00
Byron Hambly
95fda73397 Merge 2e3cd26a1a into merged_master (Bitcoin PR bitcoin/bitcoin#26053) 2024-11-26 20:17:39 +02:00
Byron Hambly
282a6c4d52 Merge d190003700 into merged_master (Bitcoin PR bitcoin-core/gui#669) 2024-11-26 15:34:01 +02:00
Byron Hambly
0dc9a6c400 Merge f523df1ee8 into merged_master (Bitcoin PR bitcoin-core/gui#664) 2024-11-26 15:33:56 +02:00
Byron Hambly
01fc1a5b60 Merge bc29c4d4a5 into merged_master (Bitcoin PR bitcoin-core/gui#663) 2024-11-26 15:33:51 +02:00
Byron Hambly
89296b2c3f Merge c67d6f5b5f into merged_master (Bitcoin PR bitcoin/bitcoin#26079) 2024-11-26 15:33:48 +02:00
Byron Hambly
c8f72ac378 Merge a8c3590890 into merged_master (Bitcoin PR bitcoin/bitcoin#25831) 2024-11-26 15:33:41 +02:00
Byron Hambly
f27a4980b0 Merge 13fd9ee5c2 into merged_master (Bitcoin PR bitcoin/bitcoin#26056) 2024-11-26 15:10:26 +02:00
Byron Hambly
dd73ace208 Merge 29d540b7ad into merged_master (Bitcoin PR bitcoin/bitcoin#26070) 2024-11-26 15:09:08 +02:00
Byron Hambly
cd60150aa4 Merge c85688347e into merged_master (Bitcoin PR bitcoin/bitcoin#26021) 2024-11-26 15:01:13 +02:00
Byron Hambly
b80b3aeff4 Merge 3a7e0a210c into merged_master (Bitcoin PR bitcoin/bitcoin#24513) 2024-11-26 14:42:49 +02:00
Byron Hambly
d7ccdef889 Merge 141540a71f into merged_master (Bitcoin PR bitcoin/bitcoin#25222) 2024-11-26 13:55:27 +02:00
Byron Hambly
74fbf6f59a Merge 94d17845d0 into merged_master (Bitcoin PR bitcoin/bitcoin#24991) 2024-11-26 13:54:42 +02:00
Byron Hambly
627bc0cfe6 Merge a361c6cae7 into merged_master (Bitcoin PR bitcoin/bitcoin#26047) 2024-11-26 13:54:37 +02:00
Byron Hambly
1d5e0e2049 Merge e9e943cfb7 into merged_master (Bitcoin PR bitcoin/bitcoin#26069) 2024-11-26 13:37:58 +02:00
Byron Hambly
ed3a451efb Merge 995fdef14a into merged_master (Bitcoin PR bitcoin/bitcoin#26059) 2024-11-26 13:36:21 +02:00
Byron Hambly
d06e8b7c42 Merge 5558d2f549 into merged_master (Bitcoin PR bitcoin/bitcoin#26048) 2024-11-26 13:19:38 +02:00
Byron Hambly
3b4249237a Merge 2e34374bf3 into merged_master (Bitcoin PR bitcoin/bitcoin#26003) 2024-11-26 13:12:15 +02:00
Byron Hambly
3564a2cee7 Merge bb378b6ccd into merged_master (Bitcoin PR bitcoin/bitcoin#26054) 2024-11-26 13:11:47 +02:00
Byron Hambly
94e8dc0d5d Merge 8ca51aa5fb into merged_master (Bitcoin PR bitcoin/bitcoin#26009) 2024-11-26 13:09:53 +02:00
Byron Hambly
fbcc874167 Merge ef5bb742f0 into merged_master (Bitcoin PR bitcoin/bitcoin#26040) 2024-11-26 13:09:29 +02:00
Byron Hambly
6b70e5124c Merge 3c5fb9691b into merged_master (Bitcoin PR bitcoin/bitcoin#26007) 2024-11-26 13:09:22 +02:00