Byron Hambly
f59db643ed
Merge 34118bfadd into merged_master (Bitcoin PR bitcoin/bitcoin#23784 )
2023-06-15 09:05:07 +00:00
Byron Hambly
31a33bbc87
Merge 28d5074343 into merged_master (Bitcoin PR bitcoin/bitcoin#23253 )
2023-05-11 10:21:19 +00:00
Byron Hambly
a1fbc62ba6
Merge fbbbc594ad into merged_master (Bitcoin PR bitcoin/bitcoin#23227 )
2023-05-10 13:56:33 +00:00
Sebastian Falbesoner
8bd34dc774
test: check that bitcoin-tx detects missing input amount for segwit transactions
2021-12-29 21:25:09 +01:00
MarcoFalke
fa6f29de51
bitcoin-tx: Reject non-integral and out of range multisig numbers
2021-10-12 12:45:55 +02:00
MarcoFalke
fafab8ea5e
bitcoin-tx: Reject non-integral and out of range sequence ids
2021-10-12 12:45:50 +02:00
MarcoFalke
fa53d3d826
test: Check that bitcoin-tx accepts whitespace around sequence id and multisig numbers
2021-10-12 12:44:41 +02:00
MarcoFalke
fa43e7c2d9
bitcoin-tx: Avoid treating overflow as OP_0
2021-10-11 09:17:28 +02:00
Andrew Poelstra
bb8e5d1ce4
Merge a196c89317 into merged_master (Bitcoin PR bitcoin/bitcoin#22270 )
...
Some PRs ago (in #19937 ) the bitcoin-util binary was added, which we
didn't notice and didn't rename to elements-util. This commit adds
some tests for it, which made me notice it ... so rename it here.
2021-07-28 18:18:31 +00:00
MarcoFalke
fa304929e2
test: Add bitcoin-util tests
2021-06-18 20:08:45 +02:00
Andrew Poelstra
575da3c422
Merge 46f0b2f976 into merged_master (Bitcoin PR #19851 )
2021-05-06 22:22:51 +00:00
Andrew Poelstra
0f623aede0
Merge 210b533a11 into merged_master (Bitcoin PR #18447 )
2020-11-26 01:08:03 +00:00
Andrew Poelstra
6a5b5f13ec
Merge b53af72b82 into merged_master (Bitcoin PR #18416 )
2020-11-26 01:08:03 +00:00
João Barbosa
c92387232f
refactor: Extract ParseOpCode from ParseScript
...
A second lookup in mapOpNames is also removed.
2020-10-06 12:34:05 +01:00
MarcoFalke
210b533a11
Merge #18447 : test: Add coverage for script parse error in ParseScript
...
dcda81c471 test: add coverage for script parse error in ParseScript (pierrenn)
Pull request description:
Follow up on this suggestion : https://github.com/bitcoin/bitcoin/pull/18416#issuecomment-603966799
This adds a test case to raise the `script parse error` in `ParseScript`.
ACKs for top commit:
instagibbs:
utACK https://github.com/bitcoin/bitcoin/pull/18447/commits/dcda81c47101196e53e379d965a2692515ef8363
Tree-SHA512: ae0ef2c00f34cee818c83582f190d5f4043159e922862f2b442b7b895b8ff3ca421533699247c12c367be77813b5205830a771cd47a18e8932807ccace2d6a1c
2020-03-27 09:58:12 -04:00
pierrenn
9ab14e4d21
Limit decimal range of numbers ParseScript accepts
2020-03-27 15:51:05 +09:00
pierrenn
dcda81c471
test: add coverage for script parse error in ParseScript
2020-03-27 12:10:31 +09:00
Steven Roose
7f894ae00b
UPSTREAM MERGE BROKEN: Merge commit ' f617e05c38' into master
2019-05-01 19:18:18 +01:00
Steven Roose
e1cd00cc6c
Change branding from bitcoin to elements
2019-03-22 10:12:04 +00:00
Gregory Sanders
8ea52eec38
Default to elementsregtest
2019-03-21 10:43:20 -04:00
Steven Roose
6493ad902a
Adapt bitcoin-tx to CA
2019-03-20 12:05:47 +00:00
Ben Woosley
9c5af58d51
Consolidate redundant implementations of ParseHashStr
...
This change:
* adds a length check to ParseHashStr, appropriate given its use to populate
a 256-bit number from a hex str.
* allows the caller to handle the failure, which allows for the more
appropriate JSONRPCError on failure in prioritisetransaction rpc
2018-09-25 09:14:52 -07:00
Daniel Kraft
57889e688d
bitcoin-tx: Stricter check for valid integers
...
Just calling atoi to convert strings to integers does not check for
valid integers very thoroughly; in particular, it just ignores
everything starting from the first non-numeral character. Even a string
like "foo" is fine and silently returns 0.
This meant that bitcoin-tx would not fail if such a string was passed in
various places where an integer is expected (like the locktime or an
input/output index); this means that it would, for instance, silently
accept a typo and interpret it in an unexpected way.
In this change, we use ParseInt64 for parsing strings to integers,
which actually verifies that the full string is valid as number.
New tests in the bitcoin-util-test cover the new error paths.
2018-07-07 14:25:09 +02:00
practicalswift
d27327c79a
Fix typos
2018-03-21 10:54:17 +01:00
Matt Corallo
28d4542a0a
Disallow uncompressed pubkeys in bitcoin-tx [multisig] output adds
2017-09-20 23:29:59 -04:00
John Newbery
19ecd1e2e1
Add tests for bitcoin-tx input checking
2017-03-30 16:37:53 -04:00
John Newbery
21704f6334
Check stderr when testing bitcoin-tx
2017-03-30 16:37:53 -04:00
John Newbery
63d66ba20a
Move src/test/bitcoin-util-test.py to test/util/bitcoin-util-test.py
2017-03-20 10:40:31 -04:00