Pablo Greco
20c5630f8c
Merge pull request #1277 from delta1/issues-1259
...
fix: assert failure on non-policy asset consolidation in CreateTransactionInternal
2023-10-27 12:38:05 -03:00
James Dorfman
e02024e53f
test: add new elements_code_tutorial functional test
2023-10-27 15:23:36 +00:00
James Dorfman
5b72ae23af
coinselection: fail if each non-policy asset doesn't have a solution
2023-10-23 16:51:09 +02:00
Byron Hambly
d3ffd2a380
test: add functional test for issue #1259
...
Adds a functional test to cover the issue uncovered in #1259 , where
calling fundrawtransaction with many non-policy inputs and no policy
recipients results in an assertion failure and a crash.
Fixed in #1258 .
(cherry picked from commit a8b0ed6f96
2023-10-23 16:43:20 +02:00
James Dorfman
c248983aab
Merge pull request #1276 from delta1/issues-1263
...
fix: segfault on getpeginaddress rpc when not in elements mode
2023-10-18 11:51:06 -04:00
Byron Hambly
181b9e5932
test: reduce sleep time in witness_script_test and bump precision for csv test
2023-10-18 14:09:09 +02:00
Byron Hambly
5326676ff3
fix: segfault on getpeginaddress rpc when not in elements mode
...
Fixes https://github.com/ElementsProject/elements/issues/1263
When not running in Elements mode, GetValidFedpegScripts returns an
empty vector. Subsequently `calculate_contract` is called with
`fedpegscripts.front().second` which is a null reference. This reference
is passed into `MatchLiquidWatchman` which tries to dereference the null
reference and causes a segfault.
This fix throws an exception in `getpeginaddress` if fedpegscripts is
empty, returning an error to the RPC caller. It also adds a functional
regression test.
2023-10-18 13:02:51 +02:00
James Dorfman
550563e04b
test: give env more time to settle in signrawtransaction.py
2023-10-17 21:00:59 +00:00
Byron Hambly
67bb197647
test: fix flaky CLTV test in signrawtransaction.py
2023-10-16 13:02:43 +02:00
Byron Hambly
4d825cd58d
test: specify legacy wallet for failing functional tests on macos13
...
In the "macOS 13 native arm64 [gui, sqlite only]" CI task, the
test_runner defaults to descriptor wallets, causing some Elements
specific tests to fail.
This commit explicitly runs those tests with `--legacy-wallet`.
2023-10-09 20:32:28 +00:00
James Dorfman
dabea18f29
rpc: fix bug in 'utxo_size_inc' calculation
2023-09-13 09:27:52 +02:00
Byron Hambly
3ead0ce841
test: fix node_fastmerkle exception in interface_zmq.py
2023-09-08 09:57:28 +02:00
Byron Hambly
860b2c3e4b
fix: move BlindDetails and IssuanceDetails to wallet.h
...
resolves the newly introduced circular dependencies correctly
2023-09-05 14:38:03 +02:00
Byron Hambly
c2c7d08de6
lint: add new circular dep to lint-circular-dependencies.sh
2023-09-01 16:38:38 +02:00
Byron Hambly
b59e244da3
lint: fix issues from lint-python.sh
2023-09-01 16:04:39 +02:00
Pablo Greco
3dfd7a4e9f
Linter fixes
2023-08-31 14:47:07 -07:00
James Dorfman
0b913592b2
Merge f20016d1ab into merged_master (Elements PR #1252 )
2023-08-29 04:36:30 +00:00
James Dorfman
d457ef7dbe
Merge 6802564be5 into merged_master (Elements PR #1246 )
2023-08-29 04:21:31 +00:00
James Dorfman
bb30fa363d
Fix feature_taproot functional test which has been failing since
...
the merge of bitcoin/bitcoin#23394 in 1beaa601b4
2023-08-11 16:39:14 +00:00
James Dorfman
1c5469b60c
Re-activate assertion which was disabled in the merge of bitcoin/bitcoin#23371 in 2110cca
...
A subsequent commit appears to have fixed that assertion. It works now.
2023-08-01 10:28:20 +02:00
James Dorfman
c1b2582a0b
Add elements-specific descriptions to assertions commented out in the merge of bitcoin/bitcoin#23201 in 7d759da52a
2023-08-01 10:28:19 +02:00
Byron Hambly
d9e021486f
lint: fix codespell lint issues
2023-07-28 12:07:19 +02:00
Byron Hambly
dcb3a05a44
lint: exclude src/secp256k1 from lint-python-utf8-encoding.sh
...
It doesn't make sense to use this upstream linter for secp256k1-zkp.
Currently this only affects musig2-vectors.py.
2023-07-28 11:59:15 +02:00
James Dorfman
8b21677a65
Add back comment which was deleted in the merge of bitcoin/bitcoin#23789 in fa3c0f4eaa
2023-07-24 17:50:33 +00:00
James Dorfman
b6f5c2de90
Add more detail to FIXME comment introduced in the merge of bitcoin/bitcoin#22019 in e3ab195851
2023-07-24 17:50:33 +00:00
James Dorfman
e815e6ad8c
Rename 'bitcoin-cli' -> 'elements-cli' in logging change introduced in the merge of bitcoin/bitcoin#23712 in 4c0504b349
2023-07-24 17:50:33 +00:00
James Dorfman
bbfdbf732c
Remove extraneous sync in rpc_signrawtransaction functional test
...
which should have been removed in the merge of bitcoin/bitcoin#23474 in bd68371fb6
2023-07-21 02:23:18 +00:00
James Dorfman
654752a8b3
Fix typos left over from the merge of bitcoin/bitcoin#23207 in f80332fee5
2023-07-21 01:39:36 +00:00
Byron Hambly
49c3ea309e
fix: getnewaddress - don't blind bech32 addresses
...
fixes #1245
2023-07-19 12:40:22 +02:00
Byron Hambly
8dbf577aaa
Merge cfc10a5dd6 into merged_master (Elements PR #1232 )
2023-07-03 13:48:57 +00:00
Byron Hambly
5e994b4aa6
Merge 1443d302ae into merged_master (Elements PR #1231 )
2023-07-03 12:27:53 +00:00
Byron Hambly
6f90a02548
Merge 30308cc380 into merged_master (Bitcoin PR bitcoin/bitcoin#20196 )
2023-07-03 11:17:52 +00:00
Byron Hambly
7a7253639a
Merge 267917f563 into merged_master (Bitcoin PR bitcoin/bitcoin#23304 )
2023-07-03 10:06:51 +00:00
Byron Hambly
7d91422a87
Merge 848b11615b into merged_master (Bitcoin PR bitcoin/bitcoin#22834 )
2023-07-03 09:33:46 +00:00
Byron Hambly
7e989c64b3
Merge 159f89c118 into merged_master (Bitcoin PR bitcoin/bitcoin#24365 )
2023-07-02 17:03:39 +00:00
Byron Hambly
b2b09ea422
Merge c7da61dcc3 into merged_master (Bitcoin PR bitcoin/bitcoin#24403 )
2023-07-02 16:55:32 +00:00
Byron Hambly
92d15f851b
Merge ee8c997125 into merged_master (Bitcoin PR bitcoin/bitcoin#24402 )
2023-07-02 16:24:37 +00:00
Byron Hambly
8211047b9c
Merge b00b60ed4f into merged_master (Bitcoin PR bitcoin/bitcoin#24201 )
2023-07-02 15:50:25 +00:00
Byron Hambly
1223ba95ca
Merge f1ce67f09f into merged_master (Bitcoin PR bitcoin/bitcoin#19013 )
2023-07-02 15:42:51 +00:00
Byron Hambly
b80c04e05a
Merge 358fe779cb into merged_master (Bitcoin PR bitcoin/bitcoin#24381 )
2023-07-02 14:47:05 +00:00
Byron Hambly
5002361bbd
Merge f9b522e50d into merged_master (Bitcoin PR bitcoin/bitcoin#24426 )
2023-07-02 14:31:10 +00:00
Byron Hambly
51fbed170b
Merge 3c565302aa into merged_master (Bitcoin PR bitcoin/bitcoin#24409 )
2023-07-02 13:45:31 +00:00
Byron Hambly
9ff19d7432
Merge f062abe529 into merged_master (Bitcoin PR bitcoin/bitcoin#24419 )
2023-07-02 07:50:11 +00:00
Byron Hambly
0e89b30f95
Merge 8add59d77d into merged_master (Bitcoin PR bitcoin/bitcoin#24367 )
2023-07-02 07:33:56 +00:00
Byron Hambly
5bbd79f15a
Merge 98b9d607a8 into merged_master (Bitcoin PR bitcoin/bitcoin#24390 )
2023-07-01 06:38:01 +00:00
Byron Hambly
ca0735a437
Merge 003523d239 into merged_master (Bitcoin PR bitcoin/bitcoin#24338 )
2023-06-30 20:58:14 +00:00
Byron Hambly
b6546f3091
Merge 1e8aa02ec5 into merged_master (Bitcoin PR bitcoin/bitcoin#24117 )
2023-06-30 17:42:41 +00:00
Byron Hambly
d2ee0b0b61
Merge 7164e00e1b into merged_master (Bitcoin PR bitcoin/bitcoin#24324 )
2023-06-30 17:34:42 +00:00
Byron Hambly
71acfa3da7
Merge 6b8e4977b8 into merged_master (Bitcoin PR bitcoin/bitcoin#24342 )
2023-06-30 17:03:39 +00:00
Byron Hambly
207c1ce338
Merge e0367e84b3 into merged_master (Bitcoin PR bitcoin/bitcoin#24301 )
2023-06-30 15:43:32 +00:00
