94074cb1d3 fix RPC documentation inconsistencies (Tom Trevethan)
d59af1ef12 Merge ElementsProject/elements#1570: rpc: fix fields describtion in man (merge-script)
69c23bfe82 Merge ElementsProject/elements#1560: rpc: fix fields description in a man in 'decodepsbt' (merge-script)
cda99dbfea Merge ElementsProject/elements#1559: rpc: use null for optional parameters (merge-script)
Pull request description:
Various fixes for RPC documentation accuracy.
Fixes for the correct usage of `null` for optional RPC parameters.
ACKs for top commit:
delta1:
ACK 94074cb1d3; tested locally
Tree-SHA512: 5ef0c4f48ba2819f50c1d0fe1769509fbaac8ec2ac1e67d93f3e73557ae343cfe706534dc6f47ff249a84a7aa0e1c7f40515f0ae708157ea932087b04d2cc586
ef1d2673d7 rpc: fix fields type in man in 'decodepsbt' (Ruslan Kasheparov)
91ae0e92e6 rpc: fix fields describtion in man in 'decodepsbt' (Ruslan Kasheparov)
Pull request description:
Top commit has no ACKs.
Tree-SHA512: 736f7ebfd3c54267aee8e7b25970a25356f9a4c38ac23caecd40a7f4b2a96c0142adc0e73bcbd6881243981297af2d5fcc68bae9023cca6179bee823d1dd9ecb
2b102c87e8 Update manpages (Pablo Greco)
bde2d5ed90 Bump version to 23.4.0-rc3 (Pablo Greco)
fecf4f1cf1 fix help man (Ruslan Kasheparov)
7647638730 add 'src/rpc/blockchain.cpp:.*trim' to the KNOWN_VIOLATIONS lint checks (Ruslan Kasheparov)
8408b79dff fix help man (Ruslan Kasheparov)
60a97d1b09 Enable ELIP203 by default in liquidv1 (Pablo Greco)
7577eb93a6 Enable ELIP203 by default in liquidtestnet (Pablo Greco)
72e4e1cf21 use break-system-packages for pip (Tom Trevethan)
6515f58351 change test order in feature_discount_ct to fix intermittent failure (Tom Trevethan)
Pull request description:
Updates master to dee90f21c1, which fixes CI, enables ELIP 203 by default. and includes several RPC fixes.
As usual, bump version and update manpages
ACKs for top commit:
tomt1664:
Tested ACK 2b102c87e8
delta1:
ACK 2b102c87e8; tested locally
Tree-SHA512: 8b94a7106ab6104f784c196d4b2b5997a3e80c010892fadf0e1ff49d0d1e4b04e7863dc2c562ec0ff0406b0ee7fa343b402c45fc873a47a555a7b2edcd4bfdb0
0331feb018 Remove cirrus YML file (Tom Trevethan)
09d9486fa0 Migrate CI to GHA (Tom Trevethan)
Pull request description:
Migration of Elements CI from Cirrus (which is closing 1st June) to Github actions.
Notes:
GHA runners have IPV6 disabled in their linux containers. So `feature_proxy.py` and `rpc_blind.py --ipv6` disabled for these, as in https://github.com/bitcoin/bitcoin/pull/30193
`windows-2019` is being deprecated and no runners appear to be readily available. https://github.com/actions/runner-images/issues/12045 (consider changing to `windows-2022`) for `win64-msvc` jobs.
`previous-releases` requires a persistent self-hosted runner. This job was being skipped by Cirrus (with `No public persistent worker pools found!`).
ACKs for top commit:
delta1:
ACK 0331feb018; tested locally
Tree-SHA512: 5c1976a9afc4faa8d41f403f10f1e771763509e751506f9ffcf13e8174ba7a6c1464cfe2045c72f497177654df566f355f2c9e760ffa2ade81cd6c34dc094710
a189d636184b1c28fa4a325b56c1fab8f44527b1 add release note for datacarriersize default change (Greg Sanders)
a141e1bf501bb2660f3a62083a65678250085e56 Add more OP_RETURN mempool acceptance functional tests (Peter Todd)
0b4048c73385166144d0b3e76beb9a2ac4cc1eca datacarrier: deprecate startup arguments for future removal (Greg Sanders)
63091b79e70b8e230a122fa6fb3dac91c80638e7 test: remove unnecessary -datacarriersize args from tests (Greg Sanders)
9f36962b07eff2369577a17c8adeaa0433697e1c policy: uncap datacarrier by default (Greg Sanders)
Pull request description:
Retains the `-datacarrier*` args, marks them as deprecated, and does not require another startup argument for multiple OP_RETURN outputs.
If a user has set `-datacarriersize` the value is "budgeted" across all seen OP_RETURN output scriptPubKeys. In other words the total script bytes stays the same, but can be spread across any number of outputs. This is done to not introduce an additional argument to support multiple outputs.
I do not advise people use the option with custom arguments and it is marked as deprecated to not mislead as a promise to offer it forever. The argument itself can be removed in some future release to clean up the code and minimize footguns for users.
Tree-SHA512: 3da2f1ef2f50884d4da7e50df2121bf175cb826edaa14ba7c3068a6d5b2a70beb426edc55d50338ee1d9686b9f74fdf9e10d30fb26a023a718dd82fa1e77b038
8a0afee1f2 Merge bitcoin/bitcoin#26777: rpc: Remove duplicate field in RPCHelpMan for gettransactions (MarcoFalke)
Pull request description:
Merge https://github.com/bitcoin/bitcoin/pull/26777: rpc: Remove duplicate field in RPCHelpMan for gettransactions
090ad51c80 rpc: Remove duplicate field in RPCHelpMan for gettransactions (Joshua Kelly)
Pull request description:
The field 'comment' appears twice in TransactionDescriptionString, incorrectly - this commit removes the instance of the comment field without a description, preserving the one with a description.
On master, the duplicate fields can be be viewed here: https://github.com/bitcoin/bitcoin/blob/master/src/wallet/rpc/transactions.cpp#L419-L423
TransactionDescriptionString is included in RPC calls such as listtransactions which have functional tests.
ACKs for top commit:
delta1:
ACK 8a0afee1f2; tested locally
Tree-SHA512: c0f0349c571c62e14b2145691e72fbe079c8815015a8e5a26d45fe88a1a68cd39153dba11300084f0e7a8b74a10a836b2b850654bbc338868bf616f73c851d40
090ad51c80 rpc: Remove duplicate field in RPCHelpMan for gettransactions (Joshua Kelly)
Pull request description:
The field 'comment' appears twice in `TransactionDescriptionString`, incorrectly - this commit removes the instance of the comment field without a description, preserving the one with a description.
On master, the duplicate fields can be be viewed here: https://github.com/bitcoin/bitcoin/blob/master/src/wallet/rpc/transactions.cpp#L419-L423
`TransactionDescriptionString` is included in RPC calls such as `listtransactions` which have functional tests.
ACKs for top commit:
w0xlt:
ACK https://github.com/bitcoin/bitcoin/pull/26777/commits/090ad51c80fe02a73f8988c1d5b867d2e90ab2f3
Tree-SHA512: 4bacdafdb517dda2af6d1c193f331b634ae74bd62ac6289c0c288957f39f98a73d07aeab72fbe5bf1ece5532406d4a40a5b8a2277be50115f76c92bb938e21fa
a76dc401d6 Merge bitcoin/bitcoin#24502: wallet: don't create long chains by default (MarcoFalke)
Pull request description:
Cherry pick of bitcoin/bitcoin#24502 with additional functional test to check rejection.
ACKs for top commit:
delta1:
ACK a76dc401d6; tested locally
Tree-SHA512: e053109dfda4cc2603a286641a1376d83f3d6cbaa42603d23d38e02d77e6c56d1e0192d2fb504b70c6ba44d92850f449c65d5bc22cba8bf108eb6cb5bb64ab82
b6369329ce wallettool: do not use fs::remove_all in createfromdump cleanup (Ava Chow)
086e185a8d wallet: introduce method to return all db created files (furszy)
552ce5ca2c use break-system-packages for pip (Tom Trevethan)
53cef282f4 change test order in feature_discount_ct to fix intermittent failure (Tom Trevethan)
Pull request description:
Cherry pick of https://github.com/bitcoin/bitcoin/pull/34215
Required new Files() method to return all db created files for sqlite and bdb (1de423e0a0)
ACKs for top commit:
delta1:
ACK b6369329ce; tested locally
Tree-SHA512: effa9fbaf2c2c2381b1e0f937da4761ded7b017afd0e5d308182767848806df31a318545cd132e0c0f1959b3a16f43d98f72825f4b46285257abfacd52278cea
03d9d8308c Update manpages (Pablo Greco)
d5c0e5bc11 Bump version to 23.4.0-rc2 (Pablo Greco)
6e079ea838 updated documentation for elements chain types (Tom Trevethan)
56b2572cef enabled > 21m for issued assets in GUI amount field (Tom Trevethan)
Pull request description:
Updates master to 8db19e90c8, which fixes a GUI issue after ELIP 203 and a small documentation fix.
Also and bumps version/manpages
ACKs for top commit:
delta1:
ACK 03d9d8308c; tested locally
tomt1664:
Tested ACK 03d9d8308c
Tree-SHA512: a892c33e413dde5c6243e8c7b21987fae8c791154cb356a4c78b68a46cbe8e151df1bc7786d11343def99a92eee22e60efe15d5691c708e5f456a301a8df557d
72e4e1cf21 use break-system-packages for pip (Tom Trevethan)
Pull request description:
Add --break-system-packages to PIP_PACKAGES in macos CI, to allow for macos-runner images to update homebrew packages.
ACKs for top commit:
delta1:
ACK 72e4e1cf21; fixes macos ci task
Tree-SHA512: 27dc712309940afde1d21c9f465c244eb49d0d1bb8bbf2faba3bf64d00a63f975943825019cd45f1c32e462ab6b5d74490cb0876aeb5e6397da20e668fff2823
6515f58351 change test order in feature_discount_ct to fix intermittent failure (Tom Trevethan)
Pull request description:
Prevents blinded output being selected intermittently and resulting in vszie and fee assertions failing.
ACKs for top commit:
delta1:
ACK 6515f58351; fixes discount_ct test flakiness
Tree-SHA512: 32d8c64011125e5531dd19ce84dbe39b2d4496a02c5bf5ece0cbc2f0c2bf6660816d6d61593fe32a615dd96a8632d94cba6bc09e792ffa6ea57fbdc4f52424da
6e079ea838 updated documentation for elements chain types (Tom Trevethan)
Pull request description:
Change config and RPC documentation for Elements chain type options.
ACKs for top commit:
delta1:
ACK 6e079ea838; just an RPC documentation update
Tree-SHA512: 4128669f5dda2700562706f7d341f37fecbd8e1c5deee2aed56869b20995f474e51af86d6228246c06a2c90fda1251066a7f86bb2fa55732ab46e58deb55b476
56b2572cef enabled > 21m for issued assets in GUI amount field (Tom Trevethan)
Pull request description:
Only pegged asset limited to `MAX_MONEY` for the GUI amount field. Issued assets can have amounts displayed > MAX_MONEY.
ACKs for top commit:
delta1:
ACK 56b2572cef; ran tests locally but have not tested the GUI
Tree-SHA512: 9a04ed9016b420a32bbaa98b80712725691619c5ca854a6b6d0b07e5a91c9ff818e6367a93f6f5c54ae8e0e9e799b6367042c0f823b6c066c5e25a9624b8adc2
de274e59be Update manpages (Pablo Greco)
a36a96175c Bump version to 23.4.0-rc1 (Pablo Greco)
56eb713150 Log status of ELIP 203 (Pablo Greco)
d8052363f3 liquidv1: allow enabling -acceptunlimitedissuances (Pablo Greco)
bd59321098 contrib: upstream my merge-prs.sh changes (Byron Hambly)
Pull request description:
Updates master to c990492c48, which adds support for enabling ELIP 203 in liquidv1. ELIP 202 support was added in 23.3.3rc1, which was renamed to 24.x. Also and bumps version/manpages
ACKs for top commit:
delta1:
ACK de274e59be; tested locally
tomt1664:
Tested ACK de274e59be
Tree-SHA512: 073080a6392cd1c10ce3b26e2faef061f583f7f1759fa3c76a71d8418aa5f9e20c0f128cae244910bacb4c09f69039dd70361bd3ab359845f27e8bb12ab21f95
