GlcoinCore/RTL
1
0
Fork 0
mirror of https://github.com/Ride-The-Lightning/RTL.git synced 2026-08-13 12:33:07 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix CLN channel View Info modal blanking for disconnected channels (#1606)

Browse source 
The channel information modal renders a block-explorer link from
selNode.settings.blockExplorerUrl, but the pending/inactive channels table
opened the modal without passing selNode. With it undefined, that binding threw
during change detection and blanked every field below it — State, Connected,
Private and the balances all rendered without a value. A disconnected channel
moves to the pending/inactive table, so this is what surfaced on View Info for a
disconnected channel (the symptom in the original report).

Pass selNode from the pending table (matching the open table), and guard the
modal's explorer link (*ngIf + a no-op click when the url is absent) so a missing
selNode can no longer blank the whole dialog. Add a regression test asserting the
pending table passes selNode when opening the modal.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
saubyk 2026-07-17 10:53:02 -07:00 • committed by Suheb
parent b790dc7abf
commit c15fa04986
5 changed files with 35 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

11
release-notes/Release-notes-0.15.9.md
View file

@ -16,6 +16,17 @@ this release should add its entry under the appropriate section below.
sync, and the list columns read `peer_connected` directly. Regression tests were added for
both channel tables.
- **Core Lightning: fix the channel View Info modal rendering blank for disconnected channels**
([#1625](https://github.com/Ride-The-Lightning/RTL/pull/1625), fixes
[#1606](https://github.com/Ride-The-Lightning/RTL/issues/1606)).
The channel information modal renders a block-explorer link from `selNode.settings.blockExplorerUrl`,
but the pending/inactive channels table opened the modal without passing `selNode`. With it
undefined, that binding threw during change detection and blanked every field below it — State,
Connected, Private and the balances all showed no value. Because a disconnected channel moves to
the pending/inactive table, this is exactly what was seen on "View Info" for a disconnected
channel. The pending table now passes `selNode` (matching the open table), and the modal guards
the explorer link so a missing `selNode` can no longer blank the dialog.
## Developer Tooling
- **Added a Core Lightning node to the regtest docker fixture**