From 6684f2e3322cc5dab0ffdead5bf92be0ea3faccf Mon Sep 17 00:00:00 2001 From: Jonathan Zernik Date: Thu, 16 Sep 2021 10:14:52 -0700 Subject: [PATCH] Fail gracefully and return None on failure to create offer (#1305) --- squeaknode/node/squeak_controller.py | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/squeaknode/node/squeak_controller.py b/squeaknode/node/squeak_controller.py index 4c20c000..c0e0ac3e 100644 --- a/squeaknode/node/squeak_controller.py +++ b/squeaknode/node/squeak_controller.py @@ -217,12 +217,16 @@ class SqueakController: secret_key = self.get_squeak_secret_key(squeak_hash) if squeak is None or secret_key is None: return None - sent_offer = self.squeak_core.create_offer( - squeak, - secret_key, - peer_address, - price_msat, - ) + try: + sent_offer = self.squeak_core.create_offer( + squeak, + secret_key, + peer_address, + price_msat, + ) + except Exception: + logger.exception("Failed to create offer.") + return None self.squeak_db.insert_sent_offer(sent_offer) return sent_offer