From 24e64fc30b1a4c07dcb7f8d9561aec5625dbf40b Mon Sep 17 00:00:00 2001
From: Jonathan Zernik <yzernik@gmail.com>
Date: Sun, 3 Oct 2021 19:49:22 -0700
Subject: [PATCH] Mock out db in unit test (#1485)

* Simplify fixtures in squeak node unit test

* Mock out get connection string which creates data dir
---
 tests/node/test_squeak_node.py | 75 ++++++++++++++++++----------------
 1 file changed, 39 insertions(+), 36 deletions(-)

diff --git a/tests/node/test_squeak_node.py b/tests/node/test_squeak_node.py
index a17fe7ba..d752ebfa 100644
--- a/tests/node/test_squeak_node.py
+++ b/tests/node/test_squeak_node.py
@@ -26,47 +26,50 @@ from squeaknode.config.config import SqueaknodeConfig
 from squeaknode.node.squeak_node import SqueakNode
 
 
-# TODO: move to conftest.
-@pytest.fixture
-def config():
-    squeaknode_config = SqueaknodeConfig(
-        dict_config={
-            'node': {
-                'network': 'mainnet'
-            },
-        },
+@pytest.fixture()
+def mock_lightning_client():
+    yield mock.patch('squeaknode.node.squeak_node.LNDLightningClient', autospec=True)
+
+
+def get_config(config_dict):
+    config = SqueaknodeConfig(
+        dict_config=config_dict,
     )
-    squeaknode_config.read()
-    return squeaknode_config
+    config.read()
+    return config
 
 
-@pytest.fixture
-def config_webadmin_enabled():
-    squeaknode_config = SqueaknodeConfig(
-        dict_config={
-            'node': {
-                'network': 'mainnet'
-            },
-            'webadmin': {
-                'enabled': 'true'
-            },
-        },
-    )
-    squeaknode_config.read()
-    return squeaknode_config
+mainnet_config = {
+    'node': {
+        'network': 'mainnet'
+    },
+}
 
 
-@mock.patch('squeaknode.node.squeak_node.LNDLightningClient', autospec=True)
-def test_start_stop(mock_lightning_client, config):
-    squeak_node = SqueakNode(config)
-
-    squeak_node.start_running()
-    squeak_node.stop_running()
-
-
-@mock.patch('squeaknode.node.squeak_node.LNDLightningClient', autospec=True)
-def test_start_stop_webadmin_enabled(mock_lightning_client, config_webadmin_enabled):
-    squeak_node = SqueakNode(config_webadmin_enabled)
+webadmin_enabled_config = {
+    'node': {
+        'network': 'mainnet'
+    },
+    'webadmin': {
+        'enabled': 'true'
+    },
+}
 
+
+@pytest.fixture(scope="module", params=[mainnet_config, webadmin_enabled_config])
+def squeak_node(request):
+    print('--------request.param---------')
+    print(request.param)
+    with mock.patch('squeaknode.node.squeak_node.LNDLightningClient', autospec=True), \
+            mock.patch('squeaknode.node.squeak_node.get_connection_string', autospec=True), \
+            mock.patch('squeaknode.node.squeak_node.get_engine', autospec=True), \
+            mock.patch('squeaknode.node.squeak_node.SqueakDb', autospec=True):
+        config = get_config(request.param)
+        yield SqueakNode(config)
+
+
+def test_start_stop(squeak_node):
+    print('--------squeak_node.config---------')
+    print(squeak_node.config)
     squeak_node.start_running()
     squeak_node.stop_running()