From 24414ee6ce573d79abbfe36f2776e1c7514c38be Mon Sep 17 00:00:00 2001 From: Jonathan Zernik Date: Fri, 10 Sep 2021 10:14:36 -0700 Subject: [PATCH] Add finally block after connection to stop peer (#1271) --- squeaknode/network/network_manager.py | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/squeaknode/network/network_manager.py b/squeaknode/network/network_manager.py index 1ed98ed0..e604ce6d 100644 --- a/squeaknode/network/network_manager.py +++ b/squeaknode/network/network_manager.py @@ -128,11 +128,15 @@ class NetworkManager(object): logger.debug( 'Setting up connection for peer address {} ...'.format(address)) - with Connection(peer, squeak_controller).connect( - self.connection_manager - ) as connection: - connection.handle_connection() - logger.debug('Stopped connection for peer address {}.'.format(address)) + try: + with Connection(peer, squeak_controller).connect( + self.connection_manager + ) as connection: + connection.handle_connection() + finally: + peer.stop() + logger.debug( + 'Stopped connection for peer address {}.'.format(address)) @property def local_address(self) -> PeerAddress: