Commit graph

10 commits

Author SHA1 Message Date
k9ert
15d5c414b5
Fix floating point rounding in wallet balance properties (#2583)
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-02 14:02:00 +02:00
k9ert
e8c5e3f4e6
Bugfix: method getaddressinfo not implemented (#2313)
This PR fixes #2312 which are four things:
* getaddressinfo was not implemented in spectrum which results in "method not found"
* There was an unrelated KeyError which occured in Transactions where one the output was a change-address. It's a bit unknown why that hasn't occured earlier. At least it was diffcult to spot as the fetch_transactions call was way to huge and very confusing. So ...
* the fetch_transactions call was refactored in its own class, TxFetcher. As we did that,  we also moved two other related files in a newly created wallet-package.
* Tiny bug around tx["amount"] which only exists as tx["flow_amount"] for transactions.
2023-03-27 21:22:56 +02:00
Manolis Mandrapilias
c1413e4f82
Bugfix: Multiple outputs in the same tx are smashed together in one UTXO (#2259)
* have multiple tx items with different vouts in the same tx

* pytest added

* additions to pytest

* account for the funding utxo

---------

Co-authored-by: k9ert <k9ert@gmx.de>
2023-03-02 10:20:50 +01:00
k9ert
fa9605d6c9
Bugfix: Clarification of Amounts in tables (fixes #1861) (#2026)
* refactoring categories and amounts + improvements of amounts

* clear cache functionality in wallet settings

* refactoring of wallet settings

* clean up and frontend wallet-refactoring

* some documentation about psbt and embit

* intermediate commit

* moar testing

* proper descriptor

* updated tests

* finalize WalletAwareTxItem Test

* coming closer

* fix tests

* Update src/cryptoadvance/specter/templates/includes/tx-table.html

Co-authored-by: Manolis Mandrapilias <70536101+moneymanolis@users.noreply.github.com>

* Update src/cryptoadvance/specter/templates/includes/tx-table.html

Co-authored-by: Manolis Mandrapilias <70536101+moneymanolis@users.noreply.github.com>

* Update src/cryptoadvance/specter/templates/wallet/settings/wallet_settings.jinja

Co-authored-by: Manolis Mandrapilias <70536101+moneymanolis@users.noreply.github.com>

* Update src/cryptoadvance/specter/templates/wallet/settings/wallet_settings.jinja

Co-authored-by: Manolis Mandrapilias <70536101+moneymanolis@users.noreply.github.com>

* Update src/cryptoadvance/specter/server_endpoints/wallets/wallets.py

Co-authored-by: Manolis Mandrapilias <70536101+moneymanolis@users.noreply.github.com>

* fix cypress

* refactoring  some parts of the psbt-creation-process and wallet.txlist

* fix cypress

* fix broken csv-download

* bugfix confirmations: null

* Bugfix: accidental Speed-up-button on confirmed TXs

* fix test

* fix test (part2)

* Liquid specific fixes

* improve cache usage

* refactoring wallet.check_utxo()

* reimplemented the whole check_utxo method

Co-authored-by: Manolis Mandrapilias <70536101+moneymanolis@users.noreply.github.com>
2023-01-20 09:45:40 +01:00
kdmukai
aba2afe9bd
Feature: Add taproot psbt fields (#1837)
* Adds BIP-371 Taproot bip32 derivation fields

Co-authored-by: moneymanolis <moneymanolis@protonmail.com>
Co-authored-by: Stepan Snigirev <snigirev.stepan@gmail.com>
2022-11-11 17:18:35 +00:00
Manolis Mandrapilias
59779fc755
Chore: Refactoring of wallet tests (#1943)
* refactoring of fixtures and wallet tests
* bottleneck mark
2022-10-26 13:15:01 +02:00
Kim Neunert
9dbde39c2d
Chore: Refactor UTXO scan (and timeout bugfix for utxo_scan) (#1687)
* refactor fixtures and add testnet fixture

* make timeouts configurable

* test timeout more properly

* refactor utxo_scanning

* refactor psbt_creator and utxo_scanner into commands (pattern)

* basic testing based on testnet

* import fix

* Update tests/test_commands_utxo_scanner.py

Co-authored-by: Manolis <70536101+moneymanolis@users.noreply.github.com>

* Update tests/fix_testnet.py

* changes after the review

* black and updating black

Co-authored-by: Manolis <70536101+moneymanolis@users.noreply.github.com>
2022-05-03 18:52:48 +02:00
Manolis
b6bd82a90c
UIUX: Overhaul of UTXO list, handling of locked UTXOs and scrollbar added to tx-table web component (#1580)
* Added tests/bitcoin to gitignore

* Ensure locked UTXO can't be used for transactions, fix rounding error in coin selection, fix styling/text in general settings.

* overhaul of checkbox logic in utxolist including mouseover event for checkboxes, manage psbt button action added, icon info popups added,design changes in utxo- and txlist to make the display quieter

* change of balance display, scrollbars for main and tx table, bugfixes (pagination, coin selection, unsigned labeling) & some styling finetuning

* deleted locked utxo balance calculations, added doc strings regarding balances

* jinja comment added in tx table, making scrollbar less vivid, tx table settings changed to no compact view toggle and scrollbar on by default

* more granular amount properties, little test fix.

* applying new amount properties to the frontend and other parts of the code & improving balance display design

* refactored a_simple_wallet to be only used in test_rest once

* tests for amounts and test performance optimisations.

* fix spec_node_configured

* fix spec_wallet_send.js

* fix spec_wallet_utxo.js

* keep action teaser div hidden on wallets overview.

* minor bug fix in tx-table, added includeShadowDom to cypress.json, adapted spec_wallet_utxo.js to new utxo list logic and added tests of new functionality to it.

* fix spec_plugins.js and switch back to includeShadowDom false
The problem with true is, that you are no longer able to spot
when you need to apply the workaround described in
https://docs.cypress.io/api/commands/shadow#Known-Issue
as you only need to apply in a shadow-DOM.
Feel free to switch it back in any test you see fit.
Cypress.config('includeShadowDom',true)

* better organisation of wallet utxo spec file

* some wait-tweaks to cypress tests to make them run smoother on cirrus, note: cypress tests green in local dev.

* longer wait in spec_elm_multi_segwit_wallet.js

* fixing spec_elm_multi_segwit_wallet.js

* more checks whether checkboxes get selected and additional waits for cirrus in spec_wallet_utxo.js.

Co-authored-by: Kim Neunert <k9ert@gmx.de>
2022-04-08 11:07:01 +02:00
Kim Neunert
18c232bf0f
Bugfix: Price data edge-case, fixes #1554 (#1624)
* fix the edge-case that someone uses dollar with bitstamp or coindesk

* Tests and removed unnecessary param

* bugfixes

* fix utxo-export

* more nice logging

* refactor mnemonic helpers into dedicated util file

* improved styling of price provider selection

* added unrelated wallet-tests

Co-authored-by: moneymanolis <moneymanolis@protonmail.com>
2022-03-08 16:23:15 +01:00
Kim Neunert
e33a178a21
Bugfix: TXs in csv and in the UI now get blocktime for time if confirmed fixes #1552 (#1559)
* initial blocktime (tests)

* regtest tx

* json loads

* bit more testing

* complete txlist-test

* internediate commit

* Feature: prevent_mining for bitcoind

* speedup ctrl-c

* proper handling of len() == 0

* having automatic invalidation in the txlist cache

* fix cypress automatic build

* kick

* blocktime vs. mempooltime in UI

* fix blocktime

* correct time for including historical pricedata

* time is not a good var name

* remove print-statements

* work on tests

* finally fix the test
2022-02-24 14:23:25 +01:00