GlcoinCore/specter-desktop
1
0
Fork 0
mirror of https://github.com/cryptoadvance/specter-desktop.git synced 2026-08-13 12:33:29 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Fix locked change output-bug (#2485)

Browse source
This commit is contained in:
Manolis Mandrapilias 2025-01-03 16:22:47 +01:00 • committed by GitHub
parent aac086b356
commit eadbe69edc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 24 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

34
src/cryptoadvance/specter/wallet/wallet.py
View file

@ -712,19 +712,33 @@ class Wallet(AbstractWallet):
tx_copy["locked"] = txid_vout in locked_utxo_dict.keys()
# Adding the more complicated stuff address and amount
if utxo != {}: # an unlocked one with values!
if utxo != {}: # an unlocked output
tx_copy["amount"] = utxo.get("amount")
tx_copy["address"] = utxo["address"]
else:
else: # a locked output
# In the case of locked outputs, the listlockunspent call does not contain reasonable UTXO data,
# so we need to get the data from the original transaction.
tx_from_core = self.rpc.gettransaction(tx_copy["txid"])
# in the case of locked amounts, the stupid listlockunspent call does not contain reasonable utxo-data
searched_vout = [
_tx
for _tx in tx_from_core["details"]
if _tx["vout"] == utxo_vout
][0]
tx_copy["amount"] = searched_vout["amount"]
tx_copy["address"] = searched_vout["address"]
searched_vout = next(
(
_tx
for _tx in tx_from_core["details"]
if _tx["vout"] == utxo_vout
),
None,
)
if searched_vout:
tx_copy["amount"] = searched_vout["amount"]
tx_copy["address"] = searched_vout["address"]
else:
# Sometimes gettransaction doesn't include all outputs (for example it does not include change outputs).
# In this case, we get the raw transaction and decode it using embit to get the additional data we need.
raw_transaction_hex = tx_from_core["hex"]
parsed_transaction = self.TxCls.from_string(raw_transaction_hex)
out = parsed_transaction.vout[utxo_vout]
tx_copy["amount"] = round(out.value * 1e-8, 8)
tx_copy["address"] = out.script_pubkey.address(self.network)
# Append the copy to the _full_utxo list
_full_utxo.append(tx_copy)