From aa5aaeb6dbd56b629f461feaa99bc78ef7066fae Mon Sep 17 00:00:00 2001
From: Manolis Mandrapilias <70536101+moneymanolis@users.noreply.github.com>
Date: Wed, 15 Mar 2023 13:29:46 +0100
Subject: [PATCH] Chore: comments for macos build script (#2228)

Co-authored-by: k9ert <k9ert@gmx.de>
---
 utils/build-osx.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/utils/build-osx.sh b/utils/build-osx.sh
index af8437927..32f435d0f 100755
--- a/utils/build-osx.sh
+++ b/utils/build-osx.sh
@@ -13,10 +13,10 @@ function create_virtualenv_for_pyinstaller {
         echo "    --> Deleting .buildenv"
         rm -rf .buildenv
     fi
-    # linux:
-    # virtualenv --python=python3 .buildenv
-    # we do:
-    virtualenv --python=/usr/local/bin/python3 .buildenv
+    # This currently assumes to be run with: Python 3.10.4
+    # Important: pyinstaller needs a Python binary with shared library files
+    # With pyenv, for example, you get this like so: env PYTHON_CONFIGURE_OPTS="--enable-shared" pyenv install 3.10.4
+    virtualenv .buildenv
     source .buildenv/bin/activate
     pip3 install -e ".[test]"
 }