UIUX: Do not hide elements by default (#1854)

* autohide_sensitive_info_timeout_minutes = never
* fix server error + testing defaults

Co-authored-by: moneymanolis <moneymanolis@protonmail.com>

src/cryptoadvance/specter/managers/config_manager.py

@@ -65,7 +65,7 @@ class ConfigManager(GenericDataManager):
             "fee_estimator": "bitcoin_core",
             "fee_estimator_custom_url": "",
             "hide_sensitive_info": False,
-            "autohide_sensitive_info_timeout_minutes": 20,
+            "autohide_sensitive_info_timeout_minutes": None,
             "autologout_timeout_hours": 4,
             # TODO: remove
             "bitcoind": False,

src/cryptoadvance/specter/server_endpoints/settings.py

@@ -118,7 +118,8 @@ def general():
             app.specter.update_merkleproof_settings(
                 validate_bool=validate_merkleproof_bool
             )
-            app.specter.service_manager.set_active_services(active_services)
+            if current_user.is_admin:
+                app.specter.service_manager.set_active_services(active_services)
             app.specter.update_fee_estimator(
                 fee_estimator=fee_estimator,
                 custom_url=fee_estimator_custom_url,

src/cryptoadvance/specter/specter.py

@@ -642,7 +642,7 @@ class Specter:
 
     @property
     def autohide_sensitive_info_timeout(self):
-        return self.user_config.get("autohide_sensitive_info_timeout_minutes", 20)
+        return self.user_config.get("autohide_sensitive_info_timeout_minutes", None)
 
     @property
     def autologout_timeout(self):

tests/test_managers_config.py

@@ -15,3 +15,6 @@ def test_ConfigManager(empty_data_folder):
     user_mock = Mock()
     cm.update_explorer("CUSTOM", {"url": "meh"}, user_mock, "regtest")
     cm.update_fee_estimator("bitcoin_core", "blub", user_mock)
+    # Check defaults for hiding sensitive info
+    assert cm.data["hide_sensitive_info"] == False
+    assert cm.data["autohide_sensitive_info_timeout_minutes"] == None