This includes upgrading the logging framework to the V2 framework. This
new framework lets us deprecate the `maxlogfiles` and
`maxlogfilesize` config options.
This commit prepares for a change in lndclient, where each sub server
client needs to implement a specific method.
Because of that requirement we cannot have a single mock that implements
two of those methods and we need to split the wallet and signer mocks
apart.
This commit bumps the compile time dependency of lnd and lndclient to
the 0.16.x branch. This makes the code forward compatible but does not
yet change anything with respect to the minimum required version the
user needs to run.
This commit reformulates transaction labels as JSON strings. The JSON contains the following fields:
* An `action` field which takes one of the following values: create, deposit, withdraw, renew, or close.
* `key` which is the account key.
* `expiry_height` which is an integer block height at which the account expires. This value is important to ease the process of account recovery.
* `output_index` which is an integer denoting the account balance transaction output.
* `expiry_spend` which is a boolean denoting whether the transaction spends via the expiry output path.
* `tx_fee` which is the onchain transaction fee for executing the account action.
* `balance_diff` which is a signed integer denoting the difference (+/-) in the account balance as a result of the transaction.
The poold specific transaction label prefix tag is also modified such that its prefixes spaces are removed.
The `.UnsignedTx` of a psbt does not include the related
SignatureScripts. Because SignatureScripts are not part of the signed
data, the partial signature for a psbt that does not include them is a
valid signature. However, the `TxHash` will change between a tx that has
SignatureScripts set and one that does not.
This behaviour led the auctioneer and the client to record the wrong
outpoint when using np2wkh.
With this commit we streamline the signing code somewhat to make it
easier to understand. With the new flow the spendPkg struct is no longer
needed as we directly pass back the (partially) signed TX.
Fixes#372.
This commit fixes the issue that if the lnd node the trader client is
connected to was also restored from seed, it is starting at account key
derivation index 0. So when recovering accounts we need to make sure we
re-derive the right number of keys from the wallet in order to allow
properly creating new accounts with the recovered node.
Split watcher logic in three pices:
- Controller: API + message dispatching
- ExpiryWatcher: handle account expirations
- EventHandler: implementation for each handler
If the account is currently participating in a batch
(`StatePendingBatch`) we disable the renewAccount command. After
enabling account autorenew it could be problematic to renew your
account before the batch is confirmed and you account expiry height
gets updated.
