From edf67bc1b0ed1ffb95b4e7307ef491d98ec39b52 Mon Sep 17 00:00:00 2001 From: Oliver Gugger Date: Thu, 29 Jul 2021 13:53:16 +0200 Subject: [PATCH] auctioneer: fix linter issue The new version of RPC structs contains an internal lock and therefore they shouldn't be memory copied anymore. The linter fortunately picked up on this and warned us, so we pass in the pointer here directly instead. --- auctioneer/client.go | 2 +- auctioneer/errors.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/auctioneer/client.go b/auctioneer/client.go index b71d024..753b3f7 100644 --- a/auctioneer/client.go +++ b/auctioneer/client.go @@ -641,7 +641,7 @@ func (c *Client) connectAndAuthenticate(ctx context.Context, // handled specifically so we return a typed error now. if errMsg.ErrorCode == auctioneerrpc.SubscribeError_INCOMPLETE_ACCOUNT_RESERVATION { return sub, true, AcctResNotCompletedErrFromRPC( - *errMsg.AccountReservation, + errMsg.AccountReservation, ) } diff --git a/auctioneer/errors.go b/auctioneer/errors.go index 655c103..0ac8340 100644 --- a/auctioneer/errors.go +++ b/auctioneer/errors.go @@ -60,7 +60,7 @@ func (e *AcctResNotCompletedError) Unwrap() error { // AcctResNotCompletedErrFromRPC creates a new AcctResNotCompletedError from an // RPC account message. func AcctResNotCompletedErrFromRPC( - rpcAcc auctioneerrpc.AuctionAccount) *AcctResNotCompletedError { + rpcAcc *auctioneerrpc.AuctionAccount) *AcctResNotCompletedError { result := &AcctResNotCompletedError{ Value: btcutil.Amount(rpcAcc.Value),