From 89081171d3990c299bcd4924746803af8e87b37c Mon Sep 17 00:00:00 2001 From: Felipe Knorr Kuhn Date: Tue, 13 Jan 2026 14:20:20 -0800 Subject: [PATCH] Bump node to v24.13 --- .github/workflows/backend-integration.yml | 2 +- .github/workflows/ci.yml | 13 +++++++------ .github/workflows/e2e_parameterized.yml | 4 ++-- .nvmrc | 2 +- docker/backend/Dockerfile | 8 ++++---- docker/frontend/Dockerfile | 2 +- production/README.md | 4 ++-- production/install | 4 ++-- production/mempool-start-all | 2 +- 9 files changed, 21 insertions(+), 20 deletions(-) diff --git a/.github/workflows/backend-integration.yml b/.github/workflows/backend-integration.yml index 61e55d3c7..e3f9407a5 100644 --- a/.github/workflows/backend-integration.yml +++ b/.github/workflows/backend-integration.yml @@ -12,7 +12,7 @@ jobs: if: "(github.event_name == 'pull_request' && !contains(github.event.pull_request.labels.*.name, 'ops') && !contains(github.head_ref, 'ops/')) || github.event_name == 'push'" strategy: matrix: - node: ["22.14.0"] + node: ["24.13.0"] fail-fast: false runs-on: ubuntu-latest diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index bd6611652..3799c66b3 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -12,7 +12,7 @@ jobs: if: "(github.event_name == 'pull_request' && !contains(github.event.pull_request.labels.*.name, 'ops') && !contains(github.head_ref, 'ops/')) || github.event_name == 'push'" strategy: matrix: - node: ["22.14.0"] + node: ["24.13.0"] flavor: ["dev", "prod"] fail-fast: false runs-on: ubuntu-latest @@ -96,7 +96,7 @@ jobs: name: "Cache assets for builds" strategy: matrix: - node: ["22.14.0"] + node: ["24.13.0"] runs-on: ubuntu-latest steps: - name: Checkout @@ -202,7 +202,7 @@ jobs: if: "(github.event_name == 'pull_request' && !contains(github.event.pull_request.labels.*.name, 'ops') && !contains(github.head_ref, 'ops/')) || github.event_name == 'push'" strategy: matrix: - node: ["22.14.0"] + node: ["24.13.0"] flavor: ["dev", "prod"] fail-fast: false runs-on: ubuntu-latest @@ -304,6 +304,7 @@ jobs: strategy: fail-fast: false matrix: + node: ["24.13.0"] module: ["mempool", "liquid", "testnet4"] name: E2E tests for ${{ matrix.module }} @@ -316,7 +317,7 @@ jobs: - name: Setup node uses: actions/setup-node@v3 with: - node-version: 22 + node-version: ${{ matrix.node }} cache: "npm" cache-dependency-path: ${{ matrix.module }}/frontend/package-lock.json @@ -324,9 +325,9 @@ jobs: uses: actions/cache@v4 with: path: ${{ matrix.module }}/frontend/node_modules - key: ${{ runner.os }}-e2e-${{ matrix.module }}-node-22-${{ hashFiles('${{ matrix.module }}/frontend/package-lock.json') }} + key: ${{ runner.os }}-e2e-${{ matrix.module }}-node-${{ matrix.node }}-${{ hashFiles('${{ matrix.module }}/frontend/package-lock.json') }} restore-keys: | - ${{ runner.os }}-e2e-${{ matrix.module }}-node-22- + ${{ runner.os }}-e2e-${{ matrix.module }}-node-${{ matrix.node }}- ${{ runner.os }}-e2e-${{ matrix.module }}- - name: Restore cached mining pool assets diff --git a/.github/workflows/e2e_parameterized.yml b/.github/workflows/e2e_parameterized.yml index 8b07ffe82..9f0cafeb8 100644 --- a/.github/workflows/e2e_parameterized.yml +++ b/.github/workflows/e2e_parameterized.yml @@ -43,7 +43,7 @@ jobs: - name: Setup Node uses: actions/setup-node@v3 with: - node-version: 22.14.0 + node-version: 24.13.0 registry-url: "https://registry.npmjs.org" - name: Install (Prod dependencies only) @@ -151,7 +151,7 @@ jobs: - name: Setup node uses: actions/setup-node@v3 with: - node-version: 22.14.0 + node-version: 24.13.0 cache: "npm" cache-dependency-path: ${{ matrix.module }}/frontend/package-lock.json diff --git a/.nvmrc b/.nvmrc index 53d1c14db..e8416a151 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -v22 +v24.13.0 diff --git a/docker/backend/Dockerfile b/docker/backend/Dockerfile index 942a8f9c8..049f13f6f 100644 --- a/docker/backend/Dockerfile +++ b/docker/backend/Dockerfile @@ -7,8 +7,8 @@ WORKDIR /build RUN apt-get update && \ apt-get install -y curl ca-certificates && \ - curl -fsSL https://deb.nodesource.com/setup_22.x | bash - && \ - apt-get install -y nodejs=22.14.0-1nodesource1 build-essential python3 pkg-config && \ + curl -fsSL https://deb.nodesource.com/setup_24.x | bash - && \ + apt-get install -y nodejs=24.13.0-1nodesource1 build-essential python3 pkg-config && \ apt-get clean && \ rm -rf /var/lib/apt/lists/* @@ -28,8 +28,8 @@ FROM rust:1.84-bookworm AS runtime RUN apt-get update && \ apt-get install -y curl ca-certificates && \ - curl -fsSL https://deb.nodesource.com/setup_22.x | bash - && \ - apt-get install -y nodejs=22.14.0-1nodesource1 && \ + curl -fsSL https://deb.nodesource.com/setup_24.x | bash - && \ + apt-get install -y nodejs=24.13.0-1nodesource1 && \ apt-get clean && \ rm -rf /var/lib/apt/lists/* diff --git a/docker/frontend/Dockerfile b/docker/frontend/Dockerfile index 23c1da3d4..6bbb2d5f3 100644 --- a/docker/frontend/Dockerfile +++ b/docker/frontend/Dockerfile @@ -1,4 +1,4 @@ -FROM node:22.14.0-bookworm-slim AS builder +FROM node:24.13-bookworm-slim AS builder ARG commitHash ENV DOCKER_COMMIT_HASH=${commitHash} diff --git a/production/README.md b/production/README.md index e6f2f2dcd..39777966a 100644 --- a/production/README.md +++ b/production/README.md @@ -82,11 +82,11 @@ pkg install -y zsh sudo git screen curl wget neovim rsync nginx openssl openssh- ### Node.js + npm -Build Node.js v22.14.0 and npm v9 from source using `nvm`: +Build Node.js v24.13.0 and npm v9 from source using `nvm`: ``` curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.0/install.sh | zsh source $HOME/.zshrc -nvm install v22.14.0 --shared-zlib +nvm install v24.13.0 --shared-zlib nvm alias default node ``` diff --git a/production/install b/production/install index 0e256fc47..e8a848f5e 100755 --- a/production/install +++ b/production/install @@ -1081,8 +1081,8 @@ echo "[*] Installing nvm.sh from GitHub" osSudo "${MEMPOOL_USER}" sh -c 'curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.2/install.sh | bash' echo "[*] Building NodeJS via nvm.sh" -osSudo "${MEMPOOL_USER}" zsh -c 'source ~/.zshrc ; CC=gcc CXX=g++ nvm install v22.14.0 --shared-zlib' -osSudo "${MEMPOOL_USER}" zsh -c 'source ~/.zshrc ; nvm alias default 22.14.0' +osSudo "${MEMPOOL_USER}" zsh -c 'source ~/.zshrc ; CC=gcc CXX=g++ nvm install v24.13.0 --shared-zlib' +osSudo "${MEMPOOL_USER}" zsh -c 'source ~/.zshrc ; nvm alias default 24.13.0' #################### # Tor installation # diff --git a/production/mempool-start-all b/production/mempool-start-all index 4bc3cf51e..9c627db3f 100755 --- a/production/mempool-start-all +++ b/production/mempool-start-all @@ -1,7 +1,7 @@ #!/usr/bin/env zsh export NVM_DIR="$HOME/.nvm" source "$NVM_DIR/nvm.sh" -nvm use v22.14.0 +nvm use v24.13.0 # start all mempool backends that exist for site in mainnet mainnet-lightning testnet testnet-lightning testnet4 signet signet-lightning liquid liquidtestnet;do