GlcoinCore/loop
1
0
Fork 0
mirror of https://github.com/lightninglabs/loop.git synced 2026-08-13 12:33:03 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Makefile: add release-tag target with SemVer validation

Browse source 
Add a `release-tag` target to the Makefile, mirroring the approach used
in taproot-assets. This target creates a signed Git tag derived from
`version.go`, and validates that it conforms to Semantic Versioning.
This prevents tagging with an invalid or non-compliant version.
This commit is contained in:
ffranr 2025-11-27 21:18:56 +00:00
parent f76c15ca16
commit b5fe8f542d
No known key found for this signature in database
GPG key ID: C4A995ED1B728904
2 changed files with 68 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

17
Makefile
View file

@ -10,6 +10,7 @@ GOIMPORTS_PKG := github.com/rinchsan/gosimports/cmd/gosimports
GO_BIN := ${GOPATH}/bin
GOIMPORTS_BIN := $(GO_BIN)/gosimports
VERSION_GO_FILE := "version.go"
GOBUILD := CGO_ENABLED=0 GO111MODULE=on go build -v
GOINSTALL := CGO_ENABLED=0 GO111MODULE=on go install -v
@ -86,6 +87,22 @@ docker-release: docker-release-builder
@if [ "$(tag)" = "" ]; then echo "Must specify tag=<commit_or_tag>!"; exit 1; fi
$(DOCKER_RELEASE_BUILDER) bash release.sh $(tag)
# release-tag: Create a signed Git tag from version.go if valid
# Derives the tag name from version.go, validates that it conforms to
# Semantic Versioning (SemVer), and creates a signed Git tag. Ensures
# the tag matches the version declared in version.go to avoid accidental
# or incorrect releases.
release-tag:
@$(call print, "Adding release tag.")
tag=$$(./scripts/get-git-tag-name.sh ${VERSION_GO_FILE}); \
exit_status=$$?; \
if [ $$exit_status -ne 0 ]; then \
echo "Script encountered an error with exit status $$exit_status."; \
fi; \
echo "Adding git tag: $$tag"; \
git tag -as -m "Tag generated using command \`make release-tag\`." "$$tag";
rpc:
@$(call print, "Compiling protos.")
cd ./swapserverrpc; ./gen_protos_docker.sh

51
scripts/get-git-tag-name.sh Executable file
View file

@ -0,0 +1,51 @@
#!/bin/bash
# Derive a git tag name from the version fields defined in the given Go file.
set -e
get_git_tag_name() {
local file_path="$1"
if [ ! -f "$file_path" ]; then
echo "Error: File not found at $file_path" >&2
exit 1
fi
local app_major
app_major=$(grep -oP 'appMajor\s*uint\s*=\s*\K\d+' "$file_path")
local app_minor
app_minor=$(grep -oP 'appMinor\s*uint\s*=\s*\K\d+' "$file_path")
local app_patch
app_patch=$(grep -oP 'appPatch\s*uint\s*=\s*\K\d+' "$file_path")
local app_pre_release
app_pre_release=$(grep -oP 'appPreRelease\s*=\s*"\K([A-Za-z0-9.-]*)' "$file_path")
if [ -z "$app_major" ] || [ -z "$app_minor" ] || [ -z "$app_patch" ]; then
echo "Error: Could not parse version constants from $file_path" >&2
exit 1
fi
local tag_name="v${app_major}.${app_minor}.${app_patch}"
if [ -n "$app_pre_release" ]; then
tag_name+="-${app_pre_release}"
fi
echo "$tag_name"
}
file_path="$1"
echo "Reading version fields from file: $file_path" >&2
tag_name=$(get_git_tag_name "$file_path")
echo "Derived git tag name: $tag_name" >&2
if ! [[ "$tag_name" =~ ^v[0-9]+\.[0-9]+\.[0-9]+(-[0-9A-Za-z.-]+)?$ ]]; then
echo "Error: Derived tag \"$tag_name\" is not semver compliant" >&2
exit 1
fi
echo "$tag_name"