GlcoinCore/loop
1
0
Fork 0
mirror of https://github.com/lightninglabs/loop.git synced 2026-08-18 13:08:28 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

instantout: guard MuSig peer slice lengths

Browse source 
Peer MuSig data was indexed by reservation position before validating counts.

Short server responses could panic loopd instead of returning an error.
This commit is contained in:
Slyghtning 2026-05-20 21:48:08 +02:00
parent 60d43898f0
commit add29cf2d0
1 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

12
instantout/instantout.go
View file

@ -263,6 +263,12 @@ func (i *InstantOut) signMusig2Tx(ctx context.Context,
if err != nil {
return nil, err
}
if len(musig2sessions) != len(inputs) {
return nil, fmt.Errorf("invalid number of MuSig2 sessions")
}
if len(counterPartyNonces) != len(inputs) {
return nil, fmt.Errorf("invalid number of peer nonces")
}
prevOutFetcher := inputs.GetPrevoutFetcher()
sigHashes := txscript.NewTxSigHashes(tx, prevOutFetcher)
@ -329,6 +335,12 @@ func (i *InstantOut) finalizeMusig2Transaction(ctx context.Context,
if err != nil {
return nil, err
}
if len(musig2Sessions) != len(inputs) {
return nil, fmt.Errorf("invalid number of MuSig2 sessions")
}
if len(serverSigs) != len(inputs) {
return nil, fmt.Errorf("invalid number of peer signatures")
}
for idx := range inputs {
haveAllSigs, finalSig, err := signer.MuSig2CombineSig(