GlcoinCore/loop
1
0
Fork 0
mirror of https://github.com/lightninglabs/loop.git synced 2026-08-13 12:33:03 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

loopd: raise minimum lnd version to v0.18.4-beta

Browse source 
LoopMinRequiredLndVersion was 0.17.0, a value that only ever tracked the
go.mod lnd dependency rounded down and was never updated as the client
started depending on newer lnd RPC APIs. The client today uses RPC
fields that do not exist in 0.17.0:

  - routerrpc.SendPaymentRequest.first_hop_custom_records and
    lnrpc.Route.custom_channel_data, used by asset loop outs in
    loopout.go: both added in lnd v0.18.4-beta.
  - walletrpc.EstimateFeeResponse.min_relay_fee_sat_per_kw, read by the
    sweep batcher fee floor via lndclient WalletKit.MinRelayFee
    (sweepbatcher/, loopd/sweep_htlc.go): added in lnd v0.18.3-beta. On
    older lnd it silently decodes to 0, disabling the min-relay floor.

Raise the floor to the highest of these (v0.18.4-beta) so loopd fails
fast at startup rather than misbehaving at runtime, and document in
AGENTS.md the rule to keep this value pinned to the lnd APIs the client
actually uses instead of tracking go.mod.
This commit is contained in:
Boris Nagaev 2026-06-16 01:00:49 -05:00
parent 950b5f1772
commit 914a3eeced
No known key found for this signature in database
2 changed files with 37 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

18
loopd/run.go
View file

@ -24,10 +24,24 @@ var (
// LoopMinRequiredLndVersion is the minimum required version of lnd that
// is compatible with the current version of the loop client. Also all
// listed build tags/subservers need to be enabled.
//
// IMPORTANT: bump this whenever the client starts using an lnd RPC
// method or message field that does not exist in older lnd, to the lnd
// release that introduced that API (see the maintenance note in
// AGENTS.md). The current floor of v0.18.4-beta is set by the highest
// such dependency the client has today:
// - routerrpc.SendPaymentRequest.first_hop_custom_records and
// lnrpc.Route.custom_channel_data, used by asset loop outs
// (loopout.go): both added in lnd v0.18.4-beta.
// - walletrpc.EstimateFeeResponse.min_relay_fee_sat_per_kw, read by
// the sweep batcher fee floor via lndclient WalletKit.MinRelayFee
// (sweepbatcher/, loopd/sweep_htlc.go): added in lnd v0.18.3-beta.
// On older lnd this field silently decodes to 0, disabling the
// sweeper's min-relay fee floor.
LoopMinRequiredLndVersion = &verrpc.Version{
AppMajor: 0,
AppMinor: 17,
AppPatch: 0,
AppMinor: 18,
AppPatch: 4,
BuildTags: []string{
"signrpc", "walletrpc", "chainrpc", "invoicesrpc",
},