GlcoinCore/loop
1
0
Fork 0
mirror of https://github.com/lightninglabs/loop.git synced 2026-08-13 12:33:03 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

utils: document raw-key normalization semantics

Browse source 
Document that Loop's raw-key MuSig2 helper and hash-derived internal-key
helper both rely on btcec.PrivKeyFromBytes normalization semantics. This
makes the current protocol behavior explicit without changing it.
This commit is contained in:
Boris Nagaev 2026-05-05 17:47:50 -05:00
parent 533e626724
commit 895b7624ac
No known key found for this signature in database
2 changed files with 10 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
loopin.go
View file

@ -1214,7 +1214,10 @@ func (s *loopInSwap) setState(state loopdb.SwapState) {
}
// sharedSecretFromHash derives the shared secret from the swap hash using the
// swap.KeyFamily family and zero as index.
// swap.KeyFamily family and zero as index. The swap hash is first interpreted
// with btcec.PrivKeyFromBytes semantics, so the derived ephemeral pubkey uses
// the same modulo-N normalization as the internal-key code paths that consume
// the resulting shared secret.
func sharedSecretFromHash(ctx context.Context, signer lndclient.SignerClient,
hash lntypes.Hash) ([32]byte, error) {

8
utils/musig.go
View file

@ -10,7 +10,10 @@ import (
)
// MuSig2Sign will create a MuSig2 signature for the passed message using the
// passed raw private keys. It expects at least two signing keys.
// passed raw private keys. Raw keys are interpreted with
// btcec.PrivKeyFromBytes semantics, which normalize 32-byte inputs modulo the
// secp256k1 group order instead of rejecting out-of-range values. It expects
// at least two signing keys.
func MuSig2Sign(version input.MuSig2Version, keys [][32]byte,
tweaks *input.MuSig2Tweaks, msg [32]byte) ([]byte, error) {
@ -18,7 +21,8 @@ func MuSig2Sign(version input.MuSig2Version, keys [][32]byte,
pubKeys := make([]*btcec.PublicKey, len(keys))
// First parse the raw private keys and also create the corresponding
// public keys.
// public keys. This preserves the same normalization semantics used
// when these raw keys are turned into pubkeys elsewhere in the protocol.
for i, key := range keys {
privKeys[i], pubKeys[i] = btcec.PrivKeyFromBytes(key[:])