From 3abede2d8e0b7a9912eebb60c453f6a57975c0a7 Mon Sep 17 00:00:00 2001 From: Boris Nagaev Date: Sat, 9 May 2026 00:57:23 -0500 Subject: [PATCH] cmd/loop: fix openchannel help typo Correct the duplicated article in the static openchannel help text so the command summary reads cleanly. Refresh the recorded help fixtures that surface that summary directly, including the dedicated openchannel help output and the parent static command listing. --- cmd/loop/openchannel.go | 2 +- .../sessions/static-loop-in/04_loop-static.json | 12 ++---------- .../01_loop-static-openchannel-help.json | 2 +- docs/loop.1 | 2 +- docs/loop.md | 2 +- 5 files changed, 6 insertions(+), 14 deletions(-) diff --git a/cmd/loop/openchannel.go b/cmd/loop/openchannel.go index e7b18c60..fd31b744 100644 --- a/cmd/loop/openchannel.go +++ b/cmd/loop/openchannel.go @@ -24,7 +24,7 @@ var ( var openChannelCommand = &cli.Command{ Name: "openchannel", - Usage: "Open a channel to a an existing peer.", + Usage: "Open a channel to an existing peer.", Description: ` Attempt to open a new channel to an existing peer with the key node-key. diff --git a/cmd/loop/testdata/sessions/static-loop-in/04_loop-static.json b/cmd/loop/testdata/sessions/static-loop-in/04_loop-static.json index b86228be..607d51d6 100644 --- a/cmd/loop/testdata/sessions/static-loop-in/04_loop-static.json +++ b/cmd/loop/testdata/sessions/static-loop-in/04_loop-static.json @@ -32,16 +32,8 @@ " withdraw, w Withdraw from static address deposits.\n", " summary, s Display a summary of static address related information.\n", " in Loop in funds from static address deposits.\n", - " openchannel Open a channel to a an existing peer.\n", - "\n" - ] - } - }, - { - "time_ms": 2, - "kind": "stdout", - "data": { - "lines": [ + " openchannel Open a channel to an existing peer.\n", + "\n", "OPTIONS:\n", " --help, -h show help\n" ] diff --git a/cmd/loop/testdata/sessions/static-openchannel/01_loop-static-openchannel-help.json b/cmd/loop/testdata/sessions/static-openchannel/01_loop-static-openchannel-help.json index 0a20ef0c..3861060d 100644 --- a/cmd/loop/testdata/sessions/static-openchannel/01_loop-static-openchannel-help.json +++ b/cmd/loop/testdata/sessions/static-openchannel/01_loop-static-openchannel-help.json @@ -25,7 +25,7 @@ "data": { "lines": [ "NAME:\n", - " loop static openchannel - Open a channel to a an existing peer.\n", + " loop static openchannel - Open a channel to an existing peer.\n", "\n", "USAGE:\n", " loop static openchannel [options]\n", diff --git a/docs/loop.1 b/docs/loop.1 index 7d767cdf..93346a1b 100644 --- a/docs/loop.1 +++ b/docs/loop.1 @@ -590,7 +590,7 @@ Loop in funds from static address deposits. .SS openchannel .PP -Open a channel to a an existing peer. +Open a channel to an existing peer. .PP \fB--base_fee_msat\fP="": the base fee in milli-satoshis that will be charged for each forwarded HTLC, regardless of payment size (default: 0) diff --git a/docs/loop.md b/docs/loop.md index 3a847e96..1577881b 100644 --- a/docs/loop.md +++ b/docs/loop.md @@ -688,7 +688,7 @@ The following flags are supported: ### `static openchannel` subcommand -Open a channel to a an existing peer. +Open a channel to an existing peer. Attempt to open a new channel to an existing peer with the key node-key. The channel will be initialized with local-amt satoshis locally and push-amt satoshis for the remote node. Note that the push-amt is deducted from the specified local-amt which implies that the local-amt must be greater than the push-amt. Also note that specifying push-amt means you give that amount to the remote node as part of the channel opening. Once the channel is open, a channelPoint (txid:vout) of the funding output is returned. If the remote peer supports the option upfront shutdown feature bit (query listpeers to see their supported feature bits), an address to enforce payout of funds on cooperative close can optionally be provided. Note that if you set this value, you will not be able to cooperatively close out to another address. One can also specify a short string memo to record some useful information about the channel using the --memo argument. This is stored locally only, and is purely for reference. It has no bearing on the channel's operation. Max allowed length is 500 characters.