From 2b4dc4eaced14665b57e58fd392e60f8cf94e69a Mon Sep 17 00:00:00 2001 From: ziggie Date: Thu, 5 Mar 2026 15:51:59 +0100 Subject: [PATCH] scripts/bw-compat: use docker logs for log collection MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Switch collect_logs from docker cp to docker logs to reliably capture container output. The previous approach used docker cp to copy lnd log files from inside named volumes, which silently fails in CI — the directory gets created and the success echo prints, but no files are ever copied, causing upload-artifact to report "No files were found". docker logs reads directly from Docker's captured stdout/stderr buffer, bypassing the volume entirely, and works as long as the container exists. --- scripts/bw-compatibility-test/network.sh | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/scripts/bw-compatibility-test/network.sh b/scripts/bw-compatibility-test/network.sh index c712381f8..e58622960 100644 --- a/scripts/bw-compatibility-test/network.sh +++ b/scripts/bw-compatibility-test/network.sh @@ -307,9 +307,7 @@ function collect_logs() { for node in alice bob charlie dave bob-pr dave-pr; do if docker ps -a --format '{{.Names}}' | grep -q "^${node}$"; then - mkdir -p "$log_dir/$node" - docker cp "$node:/root/.lnd/logs/bitcoin/regtest/lnd.log" \ - "$log_dir/$node/lnd.log" 2>/dev/null || true + docker logs "$node" > "$log_dir/${node}.log" 2>&1 || true fi done