From 02a1b3130332181630ab1d088d1686c5159bf837 Mon Sep 17 00:00:00 2001 From: cyberguru1 Date: Mon, 22 Jun 2026 03:27:39 -0500 Subject: [PATCH] itest: fix testRequestLoggerDisable node cleanup The test node variable was reassigned in a later step. This broke the deferred cleanup closure and leaked the reqlog-on node process. The leaked process caused random cleanup timeouts under heavy test load. Fixed by copying the node to a local variable before the defer. --- itest/litd_firewall_test.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/itest/litd_firewall_test.go b/itest/litd_firewall_test.go index c1fb8573..be16725c 100644 --- a/itest/litd_firewall_test.go +++ b/itest/litd_firewall_test.go @@ -308,8 +308,9 @@ func testRequestLoggerDisable(ctx context.Context, net *NetworkHarness, "--autopilot.disable", ) require.NoError(t.t, err) + reqLogOnNode := node defer func() { - _ = net.ShutdownNode(node) + _ = net.ShutdownNode(reqLogOnNode) }() rawConn, err = connectLitRPC(