GlcoinCore/lightning-terminal
1
0
Fork 0
mirror of https://github.com/lightninglabs/lightning-terminal.git synced 2026-08-13 12:33:36 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Merge pull request #1303 from Cyberguru1/depreciate-new-balance

Browse source 
litcli: remove deprecated new_balance flag from update command
This commit is contained in:
Viktor Torstensson 2026-05-21 14:35:50 +02:00 • committed by GitHub
commit 767c6e83fb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 23 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

39
cmd/litcli/accounts.go
View file

@ -146,10 +146,9 @@ var updateAccountCommand = cli.Command{
Name: "update",
ShortName: "u",
Usage: "Update an existing off-chain account.",
ArgsUsage: "[id | label] new_balance new_expiration_date",
ArgsUsage: "[id | label] [new_expiration_date]",
Description: "Updates an existing off-chain account and sets " +
"a new balance, new expiration date and " +
"optionally a new label.",
"a new expiration date and optionally a new label.",
Flags: []cli.Flag{
cli.StringFlag{
Name: idName,
@ -166,19 +165,12 @@ var updateAccountCommand = cli.Command{
Name: "new_label",
Usage: "(optional) The new label of the account.",
},
cli.Int64Flag{
Name: "new_balance",
Usage: "(deprecated) The new balance of the account; " +
"-1 means do not update the balance.",
Value: -1,
Hidden: true,
},
cli.Int64Flag{
Name: "new_expiration_date",
Usage: "The new expiration date of the account " +
"expressed in seconds since the unix epoch; " +
"-1 means do not update the expiration date; " +
"0 means it does not expire.",
Usage: "(optional) The new expiration date of " +
"the account expressed in seconds since the " +
"unix epoch; -1 means do not update the " +
"expiration date; 0 means it does not expire.",
Value: -1,
},
},
@ -204,20 +196,8 @@ func updateAccount(cli *cli.Context) error {
}
var (
newBalance int64
expirationDate int64
expirationDate int64 = -1
)
switch {
case cli.IsSet("new_balance"):
newBalance = cli.Int64("new_balance")
case args.Present():
newBalance, err = strconv.ParseInt(args.First(), 10, 64)
if err != nil {
return fmt.Errorf("unable to decode balance %v", err)
}
args = args.Tail()
}
switch {
case cli.IsSet("new_expiration_date"):
expirationDate = cli.Int64("new_expiration_date")
@ -230,11 +210,14 @@ func updateAccount(cli *cli.Context) error {
}
args = args.Tail()
}
if args.Present() {
return fmt.Errorf("too many arguments provided")
}
req := &litrpc.UpdateAccountRequest{
Id: id,
Label: label,
AccountBalance: newBalance,
AccountBalance: -1,
ExpirationDate: expirationDate,
NewLabel: cli.String("new_label"),
}

12
docs/release-notes/release-notes-0.17.0.md
View file

@ -22,6 +22,11 @@
without negotiated ALPN, restoring LNC session establishment and the
`lnc_auth` flow after the `grpc-go` `v1.67.0` upgrade.
* [Fix default account update expiration](https://github.com/lightninglabs/lightning-terminal/pull/1303):
Fixed a bug in the `litcli accounts update` command where omitting the new
expiration date would overwrite it to 0 (never expires). It now correctly
defaults to -1 (no change).
### Functional Changes/Additions
* [Show asset information on
@ -33,6 +38,12 @@
Added the ability to rename off-chain accounts using the `litcli accounts
update` command with a new `--new_label` flag.
* [Removal of deprecated `--new_balance`](https://github.com/lightninglabs/lightning-terminal/pull/1303):
Removed the deprecated `--new_balance` flag and positional parameter logic from
the `litcli accounts update` command. Users should instead use the
`litcli accounts update debit` and `litcli accounts update credit` commands
to modify an account's balance.
### Technical and Architectural Updates
## RPC Updates
@ -58,4 +69,5 @@
# Contributors (Alphabetical Order)
* Boris Nagaev
* Cyberguru1
* darioAnongba