GlcoinCore/lightning-terminal
1
0
Fork 0
mirror of https://github.com/lightninglabs/lightning-terminal.git synced 2026-08-13 12:33:36 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

accounts: process requests before stopping service

Browse source 
Ensure that we don't stop the service while we're processing a request.
This is especially important to ensure that we don't stop the service
exactly after a user has made an rpc call to send a payment we can't
know the payment hash for prior to the actual payment being sent
(i.e. Keysend or SendToRoute). This is because if we stop the service
after the send request has been sent to lnd, but before TrackPayment
has been called, we won't be able to track the payment and debit the
account.
This commit is contained in:
Viktor Tigerström 2023-09-28 00:30:50 +02:00
parent 666f19cee8
commit 6f9f3244fb
No known key found for this signature in database
GPG key ID: B984570980684DCC
1 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

12
accounts/service.go
View file

@ -214,6 +214,18 @@ func (s *InterceptorService) Start(lightningClient lndclient.LightningClient,
// Stop shuts down the account service.
func (s *InterceptorService) Stop() error {
// We need to lock the request mutex to ensure that we don't stop the
// service while we're processing a request.
// This is especially important to ensure that we don't stop the service
// exactly after a user has made an rpc call to send a payment we can't
// know the payment hash for prior to the actual payment being sent
// (i.e. Keysend or SendToRoute). This is because if we stop the service
// after the send request has been sent to lnd, but before TrackPayment
// has been called, we won't be able to track the payment and debit the
// account.
s.requestMtx.Lock()
defer s.requestMtx.Unlock()
s.contextCancel()
close(s.quit)