From 5e07588b433ef6187acec1f5bf4a55818cd3c3ab Mon Sep 17 00:00:00 2001 From: Elle Mouton Date: Thu, 6 Jun 2024 12:49:35 -0400 Subject: [PATCH] firewalldb: address last few comments from #763 --- firewalldb/kvstores.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/firewalldb/kvstores.go b/firewalldb/kvstores.go index 5b653a20..26ced86e 100644 --- a/firewalldb/kvstores.go +++ b/firewalldb/kvstores.go @@ -12,7 +12,7 @@ The KVStores are stored in the following structure in the KV db. Note that the `perm` and `temp` buckets are identical in structure. The only difference is that the `temp` bucket is cleared on restart of the db. The reason persisting the temporary store changes instead of just keeping an in-memory store is that -we can then guarantee idempotency if changes are made to both the permanent and +we can then guarantee atomicity if changes are made to both the permanent and temporary stores. rules -> perm -> rule-name -> global -> {k:v} @@ -86,14 +86,14 @@ type KVStoreTx interface { // GlobalTemp is similar to the Global store except that its contents // is cleared upon restart of the database. The reason persisting the // temporary store changes instead of just keeping an in-memory store is - // that we can then guarantee idempotency if changes are made to both + // that we can then guarantee atomicity if changes are made to both // the permanent and temporary stores. GlobalTemp() KVStore // LocalTemp is similar to the Local store except that its contents is // cleared upon restart of the database. The reason persisting the // temporary store changes instead of just keeping an in-memory store is - // that we can then guarantee idempotency if changes are made to both + // that we can then guarantee atomicity if changes are made to both // the permanent and temporary stores. LocalTemp() KVStore }