GlcoinCore/lightning-terminal
1
0
Fork 0
mirror of https://github.com/lightninglabs/lightning-terminal.git synced 2026-08-13 12:33:36 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

multi: prepare for new non-constant string rule

Browse source 
In preparation for the next commit which bumps golang to a newer
version, we want to make some code changes that would otherwise render
some log-related calls problematic. With go1.24 a new govet rule was
added that disallows non-constant strings (i.e including a tag like
"%s") in calls to printf. See more in the related issue
https://github.com/golang/go/issues/60529.
This commit is contained in:
George Tsagkarelis 2025-09-18 11:55:00 +02:00
parent bce4c049a9
commit 3ccfc5231b
No known key found for this signature in database
GPG key ID: E08DEA9B12B66AF6
5 changed files with 16 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

10
status/manager.go
View file

@ -264,18 +264,20 @@ func (s *Manager) SetErrored(name string, errStr string,
s.mu.Lock()
defer s.mu.Unlock()
err := fmt.Sprintf(errStr, params...)
if len(params) > 0 {
errStr = fmt.Sprintf(errStr, params...)
}
log.Debugf("Setting the %s sub-server as errored: %s", name, err)
log.Debugf("Setting the %s sub-server as errored: %s", name, errStr)
ss, ok := s.subServers[name]
if !ok {
return
}
log.Errorf("could not start the %s sub-server: %s", name, err)
log.Errorf("could not start the %s sub-server: %s", name, errStr)
ss.running = false
ss.err = err
ss.err = errStr
ss.customStatus = ""
}