GlcoinCore/joinmarket
1
0
Fork 0
mirror of https://github.com/JoinMarket-Org/joinmarket-clientserver.git synced 2026-08-17 13:07:51 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Uppercase simple bech32 BIP21 URI's for QR code encoding

Browse source
This commit is contained in:
Kristaps Kaupe 2021-08-06 22:47:08 +03:00
parent 09d58d7f72
commit 7d884da1bc
No known key found for this signature in database
GPG key ID: 33E472FE870C7E5D
1 changed files with 13 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

15
scripts/joinmarket-qt.py
View file

@ -72,7 +72,8 @@ from jmclient import load_program_config, get_network, update_persist_config,\
BTCEngine, FidelityBondMixin, wallet_change_passphrase, \
parse_payjoin_setup, send_payjoin, JMBIP78ReceiverManager, \
detect_script_type, general_custom_change_warning, \
nonwallet_custom_change_warning, sweep_custom_change_warning, EngineError
nonwallet_custom_change_warning, sweep_custom_change_warning, EngineError,\
TYPE_P2WPKH
from jmclient.wallet import BaseWallet
from qtsupport import ScheduleWizard, TumbleRestartWizard, config_tips,\
@ -1461,7 +1462,17 @@ class JMWalletTab(QWidget):
menu.exec_(self.walletTree.viewport().mapToGlobal(position))
def openQRCodePopup(self, address):
popup = QRCodePopup(self, address, btc.encode_bip21_uri(address, {}))
bip21_uri = btc.encode_bip21_uri(address, {})
# From BIP173 (bech32) spec:
# For presentation, lowercase is usually preferable, but inside
# QR codes uppercase SHOULD be used, as those permit the use of
# alphanumeric mode, which is 45% more compact than the normal
# byte mode.
# So we keep case for QR popup title, but convert BIP21 URI to be
# encoded in QR code to uppercase, if possible.
if detect_script_type(mainWindow.wallet_service.addr_to_script(address)) == TYPE_P2WPKH:
bip21_uri = bip21_uri.upper()
popup = QRCodePopup(self, address, bip21_uri)
popup.show()
def updateWalletInfo(self, walletinfo=None):