GlcoinCore/joinmarket
1
0
Fork 0
mirror of https://github.com/JoinMarket-Org/joinmarket-clientserver.git synced 2026-08-17 13:07:51 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

QValidator port number restriction only for ports

Browse source 
Prior to this fix, the settings which were integers
were all restricted to numbers <= 65535, but this is
not acceptable for the tx_fees setting which can be
sats per kilobyte. Note that several other integer inputs
are left without any specific validation; this change
is considered important because there will be use cases
where a large sat/kB is needed.
This commit is contained in:
Adam Gibson 2020-05-27 15:50:08 +01:00
parent 018d45ef4d
commit 48f5ddf4fd
No known key found for this signature in database
GPG key ID: 141001A1AF77F20B
1 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
scripts/joinmarket-qt.py
View file

@ -271,7 +271,13 @@ class SettingsTab(QDialog):
else:
qt = QLineEdit(val)
if t == int:
qt.setValidator(QIntValidator(0, 65535))
if name in ["rpc_port", "socks5_port", "daemon_port"]:
qt.setValidator(QIntValidator(0, 65535))
elif name == "tx_fees":
# must account for both tx_fees settings type,
# and we set upper limit well above default absurd
# check just in case a high value is needed:
qt.setValidator(QIntValidator(1, 1000000))
else:
qt = QLineEdit(val)
label = 'Testnet' if name == 'network' else name