Commit graph

35 commits

Author SHA1 Message Date
autoblitzbot
1c8fb6f7a2
security: harden wallet credential temp files (#187)
* security: harden wallet credential temp files

* fix: reject path traversal in wallet arg, correct cleanup wording, trap parity

* test: add bats suite for the credential file handling + bats CI workflow

start.service.bats: password file validation in start.service.sh (missing,
symlink, outside-path, traversal, bad-mode rejection; validation order;
password over stdin, never in the unit; deleted after use).

password-to-file.bats: passwordToFile creates an unpredictable per-run
mode-600 file under /dev/shm, cleans up via EXIT trap and on cancel/ESC.

test-bats.yml runs 'bats -r tests' on push/PR - new .bats files are
discovered automatically. Suite verified locally: 12/12 pass.

* fix(test): guard the _functions.sh source against git describe failure

On a tagless shallow checkout (CI) the version block's git describe exits
128; under bats errexit that aborted the source before the function
definitions. '|| true' keeps the source errexit-immune. Verified locally
from a non-git CWD: 12/12 pass.

---------

Co-authored-by: autoblitzbot <autoblitzbot@users.noreply.github.com>
2026-08-16 07:51:00 +02:00
autoblitzbot
5115920569
security: constrain generated wallet service inputs (#189)
* security: constrain generated wallet service inputs

* fix: validate service inputs before credential creation, propagate failures

Addresses review: validation exits could strand /dev/shm/.pw and menu_MAKER
ignored start.service.sh's exit status.

---------

Co-authored-by: autoblitzbot <autoblitzbot@users.noreply.github.com>
2026-08-15 20:41:25 +02:00
autoblitzbot
82a82d392e
security: stop sourcing user-writable config as shell code (#195)
* security: parse joinin.conf as data instead of sourcing it as code

* fix: guard sourceConf availability in _functions.bitcoincore.sh

---------

Co-authored-by: autoblitzbot <autoblitzbot@users.noreply.github.com>
2026-08-15 17:40:31 +02:00
openoms
aa8d79c97d
fix(service): add memory and CPU limits to reduce OOM kills (#182) 2026-03-29 22:36:56 +02:00
openoms
46634e1da1
ob-watcher: add RPCoverTor support 2022-04-06 19:54:00 +01:00
openoms
1b85646f7b
remove all trailing white spaces
used:
find . -type f -name '*.txt' -exec /
 sed --in-place 's/[[:space:]]\+$//' {} \+
2022-03-06 13:41:40 +00:00
openoms
d9adf3010d
replace 'torify' with 'torsocks' 2021-10-03 00:37:34 +01:00
openoms
e06969bd69
default to KillMode=control-group in services
https://www.man7.org/linux/man-pages/man5/systemd.kill.5.html
2021-06-29 17:29:59 +01:00
openoms
8fcdd50362
add hardening measures to all systemd services 2021-05-23 16:31:44 +01:00
openoms
79ee578447
check for lockfile before wallet actions
fixing: https://github.com/openoms/joininbox/issues/13
2021-05-13 14:42:30 +01:00
openoms
f239ad1f9c
handle the Yield Generator password in the RAM 2021-03-04 23:52:03 +00:00
openoms
0c839f5c3c
wallet: fix removing lockfile 2020-08-19 08:42:12 +01:00
openoms
f844646887
show the wallet filename only without path 2020-07-16 13:03:31 +01:00
openoms
19e3e4dee9
start.service: make sure lockfile is deleted 2020-07-01 12:05:50 +01:00
openoms
54649f0ca2
menu.yg: show systemd status, YGwallet to conf 2020-06-26 10:56:00 +01:00
openoms
d33f74dccb
impove terminal output 2020-06-22 20:51:26 +01:00
openoms
6a35e10d6e
clean comments 2020-06-22 14:11:58 +01:00
openoms
9de982c9fb
start.service: better output 2020-06-21 01:06:50 +01:00
openoms
9b29ccd0a0
formatting 2020-06-21 01:03:29 +01:00
openoms
2520e6386b
RPCoverTor: fix values 2020-06-21 00:42:29 +01:00
openoms
29135a303a
comment
68997f61b7
2020-06-18 13:50:14 +01:00
openoms
68997f61b7
start.service: recreate and empty .pw file after shredding
related: https://github.com/openoms/joininbox/issues/5
2020-06-18 13:46:56 +01:00
openoms
aaf4a57a27
startservice: force killing yg process
process stays alive with systemd error:
https://github.com/openoms/joininbox/issues/5
2020-06-17 22:35:48 +01:00
openoms
63e16453a3
startservice: TimeoutSec to inifinity 2020-06-17 15:11:18 +01:00
openoms
ecd9b8b235
startservice: capture wallet reliably 2020-06-17 10:14:56 +01:00
openoms
3e5f11a8b3
startservice: simplify when RPC over Tor 2020-06-15 15:36:38 +01:00
openoms
51a1d08664
start.service: wait before shredding password 2020-06-13 22:30:53 +01:00
openoms
5af6383922
start.service: improve terminal output 2020-06-13 22:22:15 +01:00
openoms
91700dd555
start.service: securely delete password once used 2020-06-13 21:51:48 +01:00
openoms
9103ed3421
change scripts to bash 2020-06-13 19:25:26 +01:00
openoms
b15f078a00
script updates 2020-06-13 13:31:25 +01:00
openoms
26755a344c
add YG service with tor RPC 2020-04-15 14:23:29 +01:00
openoms
eb51a2847a
update to v0.6.2 and adapt paths 2020-03-18 11:21:40 +00:00
openoms
2d9514023b
change user to 'joinmarket' 2020-03-18 11:01:32 +00:00
openoms
4026c31778
rename files en masse 2020-02-17 10:51:04 +00:00
Renamed from scripts/servicemaker.sh (Browse further)