mirror of
https://github.com/ElementsProject/elements.git
synced 2026-08-17 13:07:54 +02:00
50bc017040
The following scripted-diff commit will replace ParseHex("...") with "..."_hex_u8, but this replacement will not work in cases where vectors are needed instead of arrays, and is not ideal in cases where std::byte is accepted.
For example, it is currently necessary to use _hex_v_u8 when calling CScript operator<< because that operator does not currently support std::array or std::byte.
Conversely, it is incorrect to use _hex_v instead of _hex in net_processing.cpp for the MakeAndPushMessage argument, because if the argument is a std::vector it is considered variable-length and serialized with a size prefix, but if the argument is a std::array or Span is it considered fixed length and serialized without a prefix.
By the same logic, it is also safe to change the NUMS_H constant in pubkey.cpp from a std::vector to std::array because it is never serialized.
|
||
|---|---|---|
| .. | ||
| bitcoinkernel.cpp | ||
| blockmanager_opts.h | ||
| chain.cpp | ||
| chain.h | ||
| chainparams.cpp | ||
| chainparams.h | ||
| chainstatemanager_opts.h | ||
| checks.cpp | ||
| checks.h | ||
| CMakeLists.txt | ||
| coinstats.cpp | ||
| coinstats.h | ||
| context.cpp | ||
| context.h | ||
| cs_main.cpp | ||
| cs_main.h | ||
| disconnected_transactions.cpp | ||
| disconnected_transactions.h | ||
| mempool_entry.h | ||
| mempool_limits.h | ||
| mempool_options.h | ||
| mempool_removal_reason.cpp | ||
| mempool_removal_reason.h | ||
| messagestartchars.h | ||
| notifications_interface.h | ||
| warning.h | ||