elements/src/script
Ava Chow ce1c881ccc
Merge bitcoin/bitcoin#30577: miniscript: Use ToIntegral instead of ParseInt64
6714276d72 miniscript: Use `ToIntegral` instead of `ParseInt64` (brunoerg)

Pull request description:

  Currently, miniscript code uses `ParseInt64` function for `after`, `older`, `multi` and `thresh` fragments. It means that a leading `+` or whitespace, among other things, are accepted into the fragments. However, these cases are not useful and cause Bitcoin Core to behave differently compared to other miniscript implementations (see https://github.com/brunoerg/bitcoinfuzz/issues/34). This PR fixes it.

ACKs for top commit:
  achow101:
    ACK 6714276d72
  tdb3:
    cr ACK 6714276d72
  danielabrozzoni:
    tACK 6714276d72
  darosior:
    utACK 6714276d72

Tree-SHA512: d9eeb93f380f346d636513eeaf26865285e7b0907b8ed258fe1e02153a9eb69d484c82180eb1c78b0ed77ad5f0e5b244be6672c2f890b1d9fddc9e844bee6dde
2024-08-06 20:11:38 -04:00
..
descriptor.cpp refactor: Mark some static global vars as const 2024-07-08 21:19:23 +02:00
descriptor.h descriptor: Be able to get the pubkeys involved in a descriptor 2024-02-20 11:20:58 -05:00
interpreter.cpp policy: make anchor spend standard 2024-07-30 14:06:58 -04:00
interpreter.h tidy: modernize-use-equals-default 2024-07-08 11:12:01 +02:00
keyorigin.h Implement operator< for KeyOriginInfo and CExtPubKey 2021-12-10 08:29:47 -05:00
miniscript.cpp miniscript: make operator_mst consteval 2024-05-03 11:38:14 -04:00
miniscript.h miniscript: Use ToIntegral instead of ParseInt64 2024-08-05 08:23:24 -03:00
parsing.cpp util: move spanparsing.h to script/parsing.h 2024-05-16 10:16:08 -05:00
parsing.h util: move spanparsing.h to script/parsing.h 2024-05-16 10:16:08 -05:00
script.cpp policy: Add OP_1 <0x4e73> as a standard output type 2024-07-30 14:06:58 -04:00
script.h policy: Add OP_1 <0x4e73> as a standard output type 2024-07-30 14:06:58 -04:00
script_error.cpp Implement Tapscript script validation rules (BIP 342) 2020-10-12 17:18:24 -07:00
script_error.h scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
sigcache.cpp kernel: De-globalize signature cache 2024-07-05 09:03:04 +02:00
sigcache.h kernel: De-globalize signature cache 2024-07-05 09:03:04 +02:00
sign.cpp policy: Add OP_1 <0x4e73> as a standard output type 2024-07-30 14:06:58 -04:00
sign.h tidy: modernize-use-equals-default 2024-07-08 11:12:01 +02:00
signingprovider.cpp ci: Bump TIDY_LLVM_V 2024-03-15 13:34:05 +00:00
signingprovider.h tidy: modernize-use-equals-default 2024-07-08 11:12:01 +02:00
solver.cpp policy: Add OP_1 <0x4e73> as a standard output type 2024-07-30 14:06:58 -04:00
solver.h policy: Add OP_1 <0x4e73> as a standard output type 2024-07-30 14:06:58 -04:00