elements/src/wallet
Wladimir J. van der Laan 976cc766c4
Merge #17381: LegacyScriptPubKeyMan code cleanups
05b224a175 Add missing SetupGeneration error handling in EncryptWallet (Russell Yanofsky)
bfd826a675 Clean up nested scope in GetReservedDestination (Russell Yanofsky)
491a599b37 Get rid of confusing LegacyScriptPubKeyMan::TopUpKeyPool method (Russell Yanofsky)
4a0abf694e Pass CTxDestination to ScriptPubKeyMan::GetMetadata (Russell Yanofsky)
b07b07cd87 Add EnsureLegacyScriptPubKeyMan and use in rpcwallet.cpp (Russell Yanofsky)

Pull request description:

  This PR implements suggested code cleanups from #17300 and #17304 review comments

ACKs for top commit:
  Sjors:
    re-ACK 05b224a
  laanwj:
    Code review ACK 05b224a175

Tree-SHA512: 12fd86637088515b744c028e0501c5d21a9cf9ee9c9cfd70e9cb65d44611ea5643abd5f6f101105caa5aff015d74de606f074f08af7dae8429f929d21288ab45
2019-11-06 17:28:58 +01:00
..
test test: Add ASSERT_DEBUG_LOG to unit test framework 2019-11-04 10:42:33 -05:00
coincontrol.cpp extract min & max depth onto coin control 2019-07-22 15:23:21 -04:00
coincontrol.h refactor: Replace all uses of boost::optional with our own Optional type 2019-10-30 14:27:31 +01:00
coinselection.cpp refactor: Replace all uses of boost::optional with our own Optional type 2019-10-30 14:27:31 +01:00
coinselection.h amount: Move CAmount CENT to unit test header 2018-09-17 14:34:56 -04:00
crypter.cpp Fix occurences of c_str() used with size() to data() 2019-10-28 13:41:45 +01:00
crypter.h Remove unused includes 2019-10-15 22:56:43 +00:00
db.cpp wallet: Avoid showing GUI popups on RPC errors 2019-10-08 13:02:14 -04:00
db.h Merge #17070: wallet: Avoid showing GUI popups on RPC errors 2019-10-21 13:48:27 +02:00
feebumper.cpp [wallet] Remove state argument from CWallet::CommitTransaction 2019-10-18 09:43:01 -04:00
feebumper.h change wallet pointers to references in feebumper 2019-10-10 17:46:59 -04:00
fees.cpp Remove unused includes 2019-10-15 22:56:43 +00:00
fees.h Remove uses of fee globals in wallet code 2019-02-22 15:43:02 -04:00
init.cpp Pass NodeContext, ConnMan, BanMan references more places 2019-10-28 10:30:51 -04:00
ismine.h Refactor: Split up CWallet and LegacyScriptPubKeyMan and classes 2019-10-25 19:20:24 -04:00
load.cpp wallet: Avoid showing GUI popups on RPC errors 2019-10-08 13:02:14 -04:00
load.h wallet: Fix documentation around WalletParameterInteraction 2019-09-03 14:10:25 -04:00
psbtwallet.cpp Refactor: Split up CWallet and LegacyScriptPubKeyMan and classes 2019-10-25 19:20:24 -04:00
psbtwallet.h Remove unused includes 2019-10-15 22:56:43 +00:00
rpcdump.cpp Add EnsureLegacyScriptPubKeyMan and use in rpcwallet.cpp 2019-11-05 10:13:43 -05:00
rpcwallet.cpp Pass CTxDestination to ScriptPubKeyMan::GetMetadata 2019-11-05 10:36:55 -05:00
rpcwallet.h Add EnsureLegacyScriptPubKeyMan and use in rpcwallet.cpp 2019-11-05 10:13:43 -05:00
scriptpubkeyman.cpp Clean up nested scope in GetReservedDestination 2019-11-05 10:47:07 -05:00
scriptpubkeyman.h Get rid of confusing LegacyScriptPubKeyMan::TopUpKeyPool method 2019-11-05 10:43:36 -05:00
wallet.cpp Add missing SetupGeneration error handling in EncryptWallet 2019-11-05 10:53:07 -05:00
wallet.h Merge #16766: wallet: Make IsTrusted scan parents recursively 2019-11-05 21:59:27 +13:00
walletdb.cpp Refactor: Split up CWallet and LegacyScriptPubKeyMan and classes 2019-10-25 19:20:24 -04:00
walletdb.h Merge #17070: wallet: Avoid showing GUI popups on RPC errors 2019-10-21 13:48:27 +02:00
wallettool.cpp Merge #17260: Split some CWallet functions into new LegacyScriptPubKeyMan 2019-10-29 08:19:23 -04:00
wallettool.h Remove unused includes 2019-10-15 22:56:43 +00:00
walletutil.cpp Merge #15870: wallet: Only fail rescan when blocks have actually been pruned 2019-05-16 11:18:27 -04:00
walletutil.h Move wallet enums to walletutil.h 2019-10-25 19:20:24 -04:00